mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Riccardo Cipolleschi
21d530208f
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/36461 This change breaks a dependency cycle between `ReactCommon` and `React-Core`. `React-Core` depends on `ReactCommon` to have access to the various `TurboModule` native files. `ReactCommon` depends on `React-Core` because the content of the `core/platform/ios` folder and the `samples` folder needs to access the `RCTBridge` and other files in Core. To break the circular dependency, we introduced two new `podspecs`: * `React-NativeModulesApple` for the content of `core/platform/ios`. * `ReactCommon-Samples` for the content of the `samples` folder. In this way, the new dependencies are linear as `React-NativeModulesApple` and `ReactCommon-Samples` depends on `React-Core` and `ReactCommon` and `React-Core` only depends on `ReactCommon`. While doing this, we also make sure that all the include path are aligned, to limit the amount of breaking changes. ## Changelog: [iOS][Breaking] - Split the `ReactCommon/react/nativemodule/core/platform/ios` and `ReactCommon/react/nativemodule/samples` in two separate pods to break circular dependencies. Reviewed By: mdvacca Differential Revision: D44023865 fbshipit-source-id: a97569506350db5735ac5534b1592471de196cbe
95 lines
4.0 KiB
Ruby
95 lines
4.0 KiB
Ruby
# Copyright (c) Meta Platforms, Inc. and affiliates.
|
||
#
|
||
# This source code is licensed under the MIT license found in the
|
||
# LICENSE file in the root directory of this source tree.
|
||
|
||
require "json"
|
||
|
||
package = JSON.parse(File.read(File.join(__dir__, "..", "..", "package.json")))
|
||
version = package['version']
|
||
|
||
source = { :git => 'https://github.com/facebook/react-native.git' }
|
||
if version == '1000.0.0'
|
||
# This is an unpublished version, use the latest commit hash of the react-native repo, which we’re presumably in.
|
||
source[:commit] = `git rev-parse HEAD`.strip if system("git rev-parse --git-dir > /dev/null 2>&1")
|
||
else
|
||
source[:tag] = "v#{version}"
|
||
end
|
||
|
||
folly_flags = ' -DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1'
|
||
folly_compiler_flags = folly_flags + ' ' + '-Wno-comma -Wno-shorten-64-to-32'
|
||
|
||
is_new_arch_enabled = ENV["RCT_NEW_ARCH_ENABLED"] == "1"
|
||
new_arch_enabled_flag = (is_new_arch_enabled ? " -DRCT_NEW_ARCH_ENABLED" : "")
|
||
is_fabric_enabled = is_new_arch_enabled || ENV["RCT_FABRIC_ENABLED"]
|
||
fabric_flag = (is_fabric_enabled ? " -DRN_FABRIC_ENABLED" : "")
|
||
other_cflags = "$(inherited)" + folly_flags + new_arch_enabled_flag + fabric_flag
|
||
|
||
use_hermes = ENV['USE_HERMES'] == '1'
|
||
use_frameworks = ENV['USE_FRAMEWORKS'] != nil
|
||
|
||
header_search_paths = [
|
||
"$(PODS_TARGET_SRCROOT)/ReactCommon",
|
||
"$(PODS_ROOT)/Headers/Private/React-Core",
|
||
"$(PODS_ROOT)/boost",
|
||
"$(PODS_ROOT)/DoubleConversion",
|
||
"$(PODS_ROOT)/RCT-Folly",
|
||
"${PODS_ROOT}/Headers/Public/FlipperKit",
|
||
"$(PODS_ROOT)/Headers/Public/ReactCommon",
|
||
"$(PODS_ROOT)/Headers/Public/React-RCTFabric"
|
||
].concat(use_hermes ? [
|
||
"$(PODS_ROOT)/Headers/Public/React-hermes",
|
||
"$(PODS_ROOT)/Headers/Public/hermes-engine"
|
||
] : []).concat(use_frameworks ? [
|
||
"$(PODS_CONFIGURATION_BUILD_DIR)/React-Fabric/React_Fabric.framework/Headers/",
|
||
"$(PODS_CONFIGURATION_BUILD_DIR)/React-graphics/React_graphics.framework/Headers/",
|
||
"$(PODS_CONFIGURATION_BUILD_DIR)/React-graphics/React_graphics.framework/Headers/react/renderer/graphics/platform/ios",
|
||
"$(PODS_CONFIGURATION_BUILD_DIR)/ReactCommon/ReactCommon.framework/Headers/react/nativemodule/core",
|
||
"$(PODS_CONFIGURATION_BUILD_DIR)/React-NativeModulesApple/React_NativeModulesApple.framework/Headers",
|
||
"$(PODS_CONFIGURATION_BUILD_DIR)/React-RCTFabric/RCTFabric.framework/Headers/",
|
||
] : []).map{|p| "\"#{p}\""}.join(" ")
|
||
|
||
Pod::Spec.new do |s|
|
||
s.name = "React-RCTAppDelegate"
|
||
s.version = version
|
||
s.summary = "An utility library to simplify common operations for the New Architecture"
|
||
s.homepage = "https://reactnative.dev/"
|
||
s.documentation_url = "https://reactnative.dev/docs/actionsheetios"
|
||
s.license = package["license"]
|
||
s.author = "Meta Platforms, Inc. and its affiliates"
|
||
s.platforms = { :ios => "12.4" }
|
||
s.source = source
|
||
s.source_files = "**/*.{c,h,m,mm,S,cpp}"
|
||
|
||
# This guard prevent to install the dependencies when we run `pod install` in the old architecture.
|
||
s.compiler_flags = other_cflags
|
||
s.pod_target_xcconfig = {
|
||
"HEADER_SEARCH_PATHS" => header_search_paths,
|
||
"OTHER_CPLUSPLUSFLAGS" => other_cflags,
|
||
"CLANG_CXX_LANGUAGE_STANDARD" => "c++17"
|
||
}
|
||
s.user_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/Headers/Private/React-Core\""}
|
||
|
||
s.dependency "React-Core"
|
||
s.dependency "RCT-Folly"
|
||
s.dependency "RCTRequired"
|
||
s.dependency "RCTTypeSafety"
|
||
s.dependency "ReactCommon/turbomodule/core"
|
||
|
||
if is_new_arch_enabled
|
||
s.dependency "React-RCTFabric"
|
||
s.dependency "React-graphics"
|
||
|
||
s.script_phases = {
|
||
:name => "Generate Legacy Components Interop",
|
||
:script => "
|
||
. ${PODS_ROOT}/../.xcode.env
|
||
${NODE_BINARY} ${REACT_NATIVE_PATH}/scripts/codegen/generate-legacy-interop-components.js -p #{ENV['APP_PATH']} -o ${REACT_NATIVE_PATH}/Libraries/AppDelegate
|
||
",
|
||
:execution_position => :before_compile,
|
||
:input_files => ["#{ENV['APP_PATH']}/react-native.config.js"],
|
||
:output_files => ["${REACT_NATIVE_PATH}/Libraries/AppDelegate/RCTLegacyInteropComponents.mm"],
|
||
}
|
||
end
|
||
end
|