mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Ramanpreet Nara
7b9490b4b1
Summary: ## Impact Fix the Static ViewConfig for <View/>. This diff fixes the base ViewConfig for all HostComponents on both platforms. Consequently, it simplifies SVC reconciliation efforts, by nearly eliminating the first of these classes of SVC errors: 1. Unexpected properties in SVC 2. Missing properties in SVC 3. Not matching properites in SVC ## What is the base ViewConfig on each iOS/Android? **On iOS:** - All props come from ViewManagers - All HostComponent ViewManagers extend <View/> ViewManager https://pxl.cl/1SxdF Therefore, the base ViewConfig for all components should be <View/>'s static ViewConfig. **On Android:** The component model is a bit more complicated: https://pxl.cl/1Vmp5 Takeaways: - Props come from Shadow Nodes **and** ViewManagers - Nearly all HostComponent ViewManagers extend BaseViewManager. But, that's not <View/>'s ViewManager. - <View/>'s ViewManager is [ReactViewManager](https://fburl.com/code/0zalv8zk), which is a descendent of BaseViewManager, and declares its own ReactProps. So, on Android, it's not safe for the base ViewConfig to be <View>'s ViewConfig: 1. No components actualy incorportate <View/>'s props 2. Some components don't even incorporate BaseViewManager's props. So, what should the base ViewConfig be on Android? - Nearly all components extend BaseViewManager. BaseViewManager must have a shadow node [that extends LayoutShadowNode](https://www.internalfb.com/code/fbsource/[47d68ebc06e64d97da9d069f1ab662b392f0df8a]/xplat/js/react-native-github/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java?lines=40). Therefore, we'll make the base ViewConfig on Android be generated by BaseViewManager + LayoutShadowNode. ## Changes In this diff, I removed ReactNativeViewViewConfig, and introduced a new view config called PlatformBaseViewConfig. This ViewConfig partial will capture all the props available on all HostComponents on **both** platforms. This may not necessarily be the props made available on <View/>. The only components that don't extend the base platform props are: RCTTextInlineImage. What we do with these components is TBD. Changelog: [Internal] Reviewed By: p-sun, yungsters Differential Revision: D33135055 fbshipit-source-id: 7299f60ae45ed499ce47c0d0a6309a047bff90bb
102 lines
3.2 KiB
JavaScript
102 lines
3.2 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @flow strict-local
|
|
* @format
|
|
*/
|
|
|
|
import * as NativeComponentRegistry from '../../NativeComponent/NativeComponentRegistry';
|
|
import {type HostComponent} from '../../Renderer/shims/ReactNativeTypes';
|
|
import codegenNativeCommands from '../../Utilities/codegenNativeCommands';
|
|
import {type ViewProps as Props} from './ViewPropTypes';
|
|
import Platform from '../../Utilities/Platform';
|
|
|
|
import * as React from 'react';
|
|
|
|
const ViewPartialViewConfig =
|
|
Platform.OS === 'android'
|
|
? {
|
|
uiViewClassName: 'RCTView',
|
|
validAttributes: {
|
|
// ReactClippingViewManager @ReactProps
|
|
removeClippedSubviews: true,
|
|
|
|
// ReactViewManager @ReactProps
|
|
accessible: true,
|
|
hasTVPreferredFocus: true,
|
|
nextFocusDown: true,
|
|
nextFocusForward: true,
|
|
nextFocusLeft: true,
|
|
nextFocusRight: true,
|
|
nextFocusUp: true,
|
|
|
|
borderRadius: true,
|
|
borderTopLeftRadius: true,
|
|
borderTopRightRadius: true,
|
|
borderBottomRightRadius: true,
|
|
borderBottomLeftRadius: true,
|
|
borderTopStartRadius: true,
|
|
borderTopEndRadius: true,
|
|
borderBottomStartRadius: true,
|
|
borderBottomEndRadius: true,
|
|
|
|
borderStyle: true,
|
|
hitSlop: true,
|
|
pointerEvents: true,
|
|
nativeBackgroundAndroid: true,
|
|
nativeForegroundAndroid: true,
|
|
needsOffscreenAlphaCompositing: true,
|
|
|
|
borderWidth: true,
|
|
borderLeftWidth: true,
|
|
borderRightWidth: true,
|
|
borderTopWidth: true,
|
|
borderBottomWidth: true,
|
|
borderStartWidth: true,
|
|
borderEndWidth: true,
|
|
|
|
borderColor: {process: require('../../StyleSheet/processColor')},
|
|
borderLeftColor: {process: require('../../StyleSheet/processColor')},
|
|
borderRightColor: {process: require('../../StyleSheet/processColor')},
|
|
borderTopColor: {process: require('../../StyleSheet/processColor')},
|
|
borderBottomColor: {
|
|
process: require('../../StyleSheet/processColor'),
|
|
},
|
|
borderStartColor: {process: require('../../StyleSheet/processColor')},
|
|
borderEndColor: {process: require('../../StyleSheet/processColor')},
|
|
|
|
focusable: true,
|
|
overflow: true,
|
|
backfaceVisibility: true,
|
|
},
|
|
}
|
|
: {
|
|
uiViewClassName: 'RCTView',
|
|
};
|
|
|
|
const ViewNativeComponent: HostComponent<Props> =
|
|
NativeComponentRegistry.get<Props>('RCTView', () => ViewPartialViewConfig);
|
|
|
|
interface NativeCommands {
|
|
+hotspotUpdate: (
|
|
viewRef: React.ElementRef<HostComponent<mixed>>,
|
|
x: number,
|
|
y: number,
|
|
) => void;
|
|
+setPressed: (
|
|
viewRef: React.ElementRef<HostComponent<mixed>>,
|
|
pressed: boolean,
|
|
) => void;
|
|
}
|
|
|
|
export const Commands: NativeCommands = codegenNativeCommands<NativeCommands>({
|
|
supportedCommands: ['hotspotUpdate', 'setPressed'],
|
|
});
|
|
|
|
export default ViewNativeComponent;
|
|
|
|
export type ViewNativeComponentType = HostComponent<Props>;
|