mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Valentin Shergin
6a10feacda
Summary: Storing a strong shared pointer to `ComponentDescriptor` can cause a memory leak. Therefore we enforce all call sides and params to be weak pointers. The only Scheduler preserves a retaining pointer to it (to prevent preliminary deallocation). Reviewed By: sammy-SC Differential Revision: D17115540 fbshipit-source-id: fdea7d19f742ff04d5ba5470dd9748a5b226aa7c
95 lines
3.4 KiB
C++
95 lines
3.4 KiB
C++
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include "TestComponent.h"
|
|
|
|
using namespace facebook::react;
|
|
|
|
TEST(ComponentDescriptorTest, createShadowNode) {
|
|
auto eventDispatcher = std::shared_ptr<EventDispatcher const>();
|
|
SharedComponentDescriptor descriptor =
|
|
std::make_shared<TestComponentDescriptor>(eventDispatcher);
|
|
|
|
ASSERT_EQ(descriptor->getComponentHandle(), TestShadowNode::Handle());
|
|
ASSERT_STREQ(descriptor->getComponentName(), TestShadowNode::Name());
|
|
ASSERT_STREQ(descriptor->getComponentName(), "Test");
|
|
|
|
const auto &raw = RawProps(folly::dynamic::object("nativeID", "abc"));
|
|
SharedProps props = descriptor->cloneProps(nullptr, raw);
|
|
SharedShadowNode node = descriptor->createShadowNode(ShadowNodeFragment{
|
|
/* .tag = */ 9,
|
|
/* .surfaceId = */ 1,
|
|
/* .props = */ props,
|
|
/* .eventEmitter = */ descriptor->createEventEmitter(0, 9),
|
|
});
|
|
|
|
ASSERT_EQ(node->getComponentHandle(), TestShadowNode::Handle());
|
|
ASSERT_STREQ(node->getComponentName(), TestShadowNode::Name());
|
|
ASSERT_STREQ(node->getComponentName(), "Test");
|
|
ASSERT_EQ(node->getTag(), 9);
|
|
ASSERT_EQ(node->getSurfaceId(), 1);
|
|
ASSERT_STREQ(node->getProps()->nativeId.c_str(), "abc");
|
|
}
|
|
|
|
TEST(ComponentDescriptorTest, cloneShadowNode) {
|
|
auto eventDispatcher = std::shared_ptr<EventDispatcher const>();
|
|
SharedComponentDescriptor descriptor =
|
|
std::make_shared<TestComponentDescriptor>(eventDispatcher);
|
|
|
|
const auto &raw = RawProps(folly::dynamic::object("nativeID", "abc"));
|
|
SharedProps props = descriptor->cloneProps(nullptr, raw);
|
|
SharedShadowNode node = descriptor->createShadowNode(ShadowNodeFragment{
|
|
/* .tag = */ 9,
|
|
/* .surfaceId = */ 1,
|
|
/* .props = */ props,
|
|
/* .eventEmitter = */ descriptor->createEventEmitter(0, 9),
|
|
});
|
|
SharedShadowNode cloned = descriptor->cloneShadowNode(*node, {});
|
|
|
|
ASSERT_STREQ(cloned->getComponentName(), "Test");
|
|
ASSERT_EQ(cloned->getTag(), 9);
|
|
ASSERT_EQ(cloned->getSurfaceId(), 1);
|
|
ASSERT_STREQ(cloned->getProps()->nativeId.c_str(), "abc");
|
|
}
|
|
|
|
TEST(ComponentDescriptorTest, appendChild) {
|
|
auto eventDispatcher = std::shared_ptr<EventDispatcher const>();
|
|
SharedComponentDescriptor descriptor =
|
|
std::make_shared<TestComponentDescriptor>(eventDispatcher);
|
|
|
|
const auto &raw = RawProps(folly::dynamic::object("nativeID", "abc"));
|
|
SharedProps props = descriptor->cloneProps(nullptr, raw);
|
|
SharedShadowNode node1 = descriptor->createShadowNode(ShadowNodeFragment{
|
|
/* .tag = */ 1,
|
|
/* .surfaceId = */ 1,
|
|
/* .props = */ props,
|
|
/* .eventEmitter = */ descriptor->createEventEmitter(0, 1),
|
|
});
|
|
SharedShadowNode node2 = descriptor->createShadowNode(ShadowNodeFragment{
|
|
/* .tag = */ 2,
|
|
/* .surfaceId = */ 1,
|
|
/* .props = */ props,
|
|
/* .eventEmitter = */ descriptor->createEventEmitter(0, 2),
|
|
});
|
|
SharedShadowNode node3 = descriptor->createShadowNode(ShadowNodeFragment{
|
|
/* .tag = */ 3,
|
|
/* .surfaceId = */ 1,
|
|
/* .props = */ props,
|
|
/* .eventEmitter = */ descriptor->createEventEmitter(0, 3),
|
|
});
|
|
|
|
descriptor->appendChild(node1, node2);
|
|
descriptor->appendChild(node1, node3);
|
|
|
|
auto node1Children = node1->getChildren();
|
|
ASSERT_EQ(node1Children.size(), 2);
|
|
ASSERT_EQ(node1Children.at(0), node2);
|
|
ASSERT_EQ(node1Children.at(1), node3);
|
|
}
|