react-native

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Gabriel Donadel Dall'Agnol 55b09da62a fix: Eslint on Danger not matching project config (#34980 )

Summary:
I've been noticing this for a while now, every time that someone changes a file inside rn-tester Danger comments a bunch of warnings regarding inline styles, e.g. https://github.com/facebook/react-native/pull/34567#issuecomment-1257956893, even though that is disabled inside .eslintrc https://github.com/facebook/react-native/blob/8edf4e9e3adcc85743e3c86a25ab3748b276a3da/packages/rn-tester/.eslintrc#L3

After some investigation, I realized that the problem was that the Eslint Node.js API used by [seadub/danger-plugin-eslint](https://www.npmjs.com/package/seadub/danger-plugin-eslint) was not able to locate any `.eslintrc` files due to the location of the directory where danger is invoked. By using `process.chdir` we can ensure that eslint will run from the root folder and that it will be able to find all .eslintrc files

## Changelog

[Internal] [Fixed] - fix eslint config when running Danger

Pull Request resolved: https://github.com/facebook/react-native/pull/34980

Test Plan:
run `yarn danger pr https://github.com/facebook/react-native/pull/34976`

After

![image](https://user-images.githubusercontent.com/11707729/195751496-5225a32f-f4b3-4ce2-833f-ae5723f647c0.png)

Before

![image](https://user-images.githubusercontent.com/11707729/195751673-34ba87fc-ce50-4020-9688-a486e3021c4f.png)

Reviewed By: cortinico

Differential Revision: D40384300

Pulled By: yungsters

fbshipit-source-id: e68eeafc42567dc9d7297dde3709a989cc70f4e2

2022-10-14 10:01:25 -07:00

.babelrc

Add bots as a yarn workspace and update danger action (#34652 )

2022-09-12 22:03:34 -07:00

code-analysis-bot.js

Add bots as a yarn workspace and update danger action (#34652 )

2022-09-12 22:03:34 -07:00

dangerfile.js

fix: Eslint on Danger not matching project config (#34980 )

2022-10-14 10:01:25 -07:00

datastore.js

Add bots as a yarn workspace and update danger action (#34652 )

2022-09-12 22:03:34 -07:00

make-comment.js

Add bots as a yarn workspace and update danger action (#34652 )

2022-09-12 22:03:34 -07:00

package.json

Add bots as a yarn workspace and update danger action (#34652 )

2022-09-12 22:03:34 -07:00

post-artifacts-link.js

Add bots as a yarn workspace and update danger action (#34652 )

2022-09-12 22:03:34 -07:00

README.md

Add bots as a yarn workspace and update danger action (#34652 )

2022-09-12 22:03:34 -07:00

report-bundle-size.js

Add bots as a yarn workspace and update danger action (#34652 )

2022-09-12 22:03:34 -07:00

README.md

Danger

Danger is a JavaScript runtime which helps you provide continuous feedback inside GitHub. It's used inside Github Actions to analyze the contents of a GitHub pull request.

If you want to test changes to Danger, I'd recommend checking out an existing PR and then running the danger pr command. You'll need a GitHub Public Access Token (PAT). It will look like ghp_<REDACTED>.

So, for example:

DANGER_GITHUB_API_TOKEN=ghp_<REDACTED> yarn danger pr https://github.com/facebook/react-native/pull/1234

Code Analysis Bot

The code analysis bot provides lint and other results as inline reviews on GitHub. It runs as part of the Circle CI analysis workflow.

If you want to test changes to the Code Analysis Bot, I'd recommend checking out an existing PR and then running the analyze pr command. You'll need a GitHub token. You can re-use this one: 312d354b5c36f082cfe9 07973d757026bdd9f196 (just remove the space). So, for example:

GITHUB_TOKEN=[ENV_ABOVE] GITHUB_PR_NUMBER=1234 yarn lint-ci