mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
fix: Eslint on Danger not matching project config (#34980)
Summary: I've been noticing this for a while now, every time that someone changes a file inside rn-tester Danger comments a bunch of warnings regarding inline styles, e.g. https://github.com/facebook/react-native/pull/34567#issuecomment-1257956893, even though that is disabled inside .eslintrc https://github.com/facebook/react-native/blob/8edf4e9e3adcc85743e3c86a25ab3748b276a3da/packages/rn-tester/.eslintrc#L3 After some investigation, I realized that the problem was that the Eslint Node.js API used by [seadub/danger-plugin-eslint](https://www.npmjs.com/package/seadub/danger-plugin-eslint) was not able to locate any `.eslintrc` files due to the location of the directory where danger is invoked. By using `process.chdir` we can ensure that eslint will run from the root folder and that it will be able to find all .eslintrc files ## Changelog [Internal] [Fixed] - fix eslint config when running Danger Pull Request resolved: https://github.com/facebook/react-native/pull/34980 Test Plan: run `yarn danger pr https://github.com/facebook/react-native/pull/34976` After  Before  Reviewed By: cortinico Differential Revision: D40384300 Pulled By: yungsters fbshipit-source-id: e68eeafc42567dc9d7297dde3709a989cc70f4e2
This commit is contained in:
committed by
Facebook GitHub Bot
parent
5580a22dad
commit
55b09da62a
+2
@@ -109,4 +109,6 @@ if (isMergeRefStable) {
|
||||
});
|
||||
}
|
||||
|
||||
// Ensures that eslint is run from root folder and that it can find .eslintrc
|
||||
process.chdir('../../');
|
||||
eslint.default();
|
||||
|
||||
Reference in New Issue
Block a user