Fix CQS signal modernize-use-using in xplat/js/react-native-github/packages [A] [A]

Reviewed By: rshest

Differential Revision: D78538428

packages/gradle-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/ReactPlugin.kt

@@ -18,7 +18,6 @@ import com.facebook.react.tasks.GenerateEntryPointTask
 import com.facebook.react.tasks.GeneratePackageListTask
 import com.facebook.react.utils.AgpConfiguratorUtils.configureBuildConfigFieldsForApp
 import com.facebook.react.utils.AgpConfiguratorUtils.configureBuildConfigFieldsForLibraries
-import com.facebook.react.utils.AgpConfiguratorUtils.configureBuildTypesForApp
 import com.facebook.react.utils.AgpConfiguratorUtils.configureDevServerLocation
 import com.facebook.react.utils.AgpConfiguratorUtils.configureNamespaceForLibraries
 import com.facebook.react.utils.BackwardCompatUtils.configureBackwardCompatibilityReactMap
@@ -85,7 +84,6 @@ class ReactPlugin : Plugin<Project> {
       configureAutolinking(project, extension)
       configureCodegen(project, extension, rootExtension, isLibrary = false)
       configureResources(project, extension)
-      configureBuildTypesForApp(project)
     }
 
     // Library Only Configuration

packages/gradle-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/AgpConfiguratorUtils.kt

@@ -19,7 +19,6 @@ import java.net.Inet4Address
 import java.net.NetworkInterface
 import javax.xml.parsers.DocumentBuilder
 import javax.xml.parsers.DocumentBuilderFactory
-import kotlin.plus
 import org.gradle.api.Action
 import org.gradle.api.Project
 import org.gradle.api.plugins.AppliedPlugin
@@ -28,26 +27,6 @@ import org.w3c.dom.Element
 @Suppress("UnstableApiUsage")
 internal object AgpConfiguratorUtils {
 
-  fun configureBuildTypesForApp(project: Project) {
-    val action =
-        Action<AppliedPlugin> {
-          project.extensions
-              .getByType(ApplicationAndroidComponentsExtension::class.java)
-              .finalizeDsl { ext ->
-                ext.buildTypes {
-                  val debug =
-                      getByName("debug").apply {
-                        manifestPlaceholders["usesCleartextTraffic"] = "true"
-                      }
-                  getByName("release").apply {
-                    manifestPlaceholders["usesCleartextTraffic"] = "false"
-                  }
-                }
-              }
-        }
-    project.pluginManager.withPlugin("com.android.application", action)
-  }
-
   fun configureBuildConfigFieldsForApp(project: Project, extension: ReactExtension) {
     val action =
         Action<AppliedPlugin> {

packages/react-native/React/CxxBridge/RCTCxxBridge.mm

@@ -66,7 +66,7 @@
 
 static NSString *const RCTJSThreadName = @"com.facebook.react.JavaScript";
 
-typedef void (^RCTPendingCall)();
+using RCTPendingCall = void (^)();
 
 using namespace facebook::jsi;
 using namespace facebook::react;

packages/react-native/React/DevSupport/RCTInspectorNetworkHelper.h

@@ -11,11 +11,11 @@
 
 #import <jsinspector-modern/ReactCdp.h>
 
-typedef facebook::react::jsinspector_modern::NetworkRequestListener RCTInspectorNetworkListener;
+using RCTInspectorNetworkListener = facebook::react::jsinspector_modern::NetworkRequestListener;
 
-typedef facebook::react::jsinspector_modern::ScopedExecutor<RCTInspectorNetworkListener> RCTInspectorNetworkExecutor;
+using RCTInspectorNetworkExecutor = facebook::react::jsinspector_modern::ScopedExecutor<RCTInspectorNetworkListener>;
 
-typedef facebook::react::jsinspector_modern::LoadNetworkResourceRequest RCTInspectorLoadNetworkResourceRequest;
+using RCTInspectorLoadNetworkResourceRequest = facebook::react::jsinspector_modern::LoadNetworkResourceRequest;
 
 /**
  * A helper class that wraps around NSURLSession to make network requests.

packages/rn-tester/android/app/src/debug/AndroidManifest.xml

@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="utf-8"?>
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools">
+
+    <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>
+
+    <application android:usesCleartextTraffic="true" tools:targetApi="28" tools:ignore="GoogleAppIndexingWarning" />
+</manifest>

packages/rn-tester/android/app/src/main/AndroidManifest.xml

@@ -50,7 +50,6 @@
     </queries>
 
     <application
-        android:usesCleartextTraffic="${usesCleartextTraffic}"
         android:name=".RNTesterApplication"
         android:allowBackup="true"
         android:banner="@drawable/tv_banner"