Compare commits

...
Author SHA1 Message Date
Mike Grabowski c85aa82cd0 [0.51.0-rc.1] Bump version numbers 2017-11-05 00:48:48 +01:00
Mehdi Mulani 91509751ef Fix memory leak in RCTSafeAreaView
Summary:
According to the retain code collector, RCTSafeAreaView is in a cycle:
-> _bridge -> RCTCxxBridge -> _moduleDataByName -> __NSDictionaryM -> RCTModuleData -> _instance -> RCTUIManager -> _viewRegistry -> __NSDictionaryM -> RCTSafeAreaView
This should break the cycle.

Reviewed By: shergin

Differential Revision: D6213668

fbshipit-source-id: efb9c1dd148b72f66fe4485b81c16cd4c2d18b17
2017-11-03 23:34:29 -07:00
James Ide 87e524b4a4 [podspec] Define pod_target_xcconfig for PrivateDatabase
We don't strictly need this since all the other subspecs that use this set up the header search path for ReactCommon anyway but do it just for correctness.
2017-11-03 17:09:10 -07:00
Joshua May 6817f05f63 Adds PrivateDatabase podspec
Summary:
Resolves #16663.

Walked through the reproduction steps in #16663, but with successful build.

We can also now see the files are included in the `Pods` project:

<img width="236" alt="screen shot 2017-11-03 at 7 43 21 pm" src="https://user-images.githubusercontent.com/33126/32390596-4a06c05c-c0cf-11e7-8616-3ae547f8cca2.png">

(I noticed a subspec called `_ignore_me_subspec_for_linting_` so do we have tests for the podspec?)

[IOS] [BUGFIX] [React.podspec] - Resolves build error about missing symbols for PrivateDatabase.{cpp,h}
Closes https://github.com/facebook/react-native/pull/16664

Differential Revision: D6238178

Pulled By: hramos

fbshipit-source-id: b57007ab8c7c8bd0faf1f2f11269a7a2c28183e5
2017-11-03 17:09:06 -07:00
Mike Grabowski 7f4fe158a2 [0.51.0-rc.0] Bump version numbers 2017-11-03 17:50:06 +01:00
7 changed files with 17 additions and 10 deletions
+2 -2
View File
@@ -14,7 +14,7 @@
exports.version = {
major: 0,
minor: 0,
minor: 51,
patch: 0,
prerelease: null,
prerelease: 'rc.1',
};
+7
View File
@@ -109,6 +109,7 @@ Pod::Spec.new do |s|
s.subspec "jschelpers" do |ss|
ss.dependency "Folly", "2016.09.26.00"
ss.dependency "React/PrivateDatabase"
ss.compiler_flags = folly_compiler_flags
ss.source_files = "ReactCommon/jschelpers/*.{cpp,h}"
ss.private_header_files = "ReactCommon/jschelpers/*.h"
@@ -116,6 +117,12 @@ Pod::Spec.new do |s|
ss.framework = "JavaScriptCore"
end
s.subspec "PrivateDatabase" do |ss|
ss.source_files = "ReactCommon/privatedata/*.{cpp,h}"
ss.private_header_files = "ReactCommon/privatedata/*.h"
ss.pod_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_TARGET_SRCROOT)/ReactCommon\"" }
end
s.subspec "cxxreact" do |ss|
ss.dependency "React/jschelpers"
ss.dependency "boost"
+2 -2
View File
@@ -11,7 +11,7 @@
#define RCT_REACT_NATIVE_VERSION @{ \
@"major": @(0), \
@"minor": @(0), \
@"minor": @(51), \
@"patch": @(0), \
@"prerelease": [NSNull null], \
@"prerelease": @"rc.1", \
}
+1 -1
View File
@@ -15,7 +15,7 @@
#import "RCTSafeAreaViewLocalData.h"
@implementation RCTSafeAreaView {
RCTBridge *_bridge;
__weak RCTBridge *_bridge;
UIEdgeInsets _currentSafeAreaInsets;
}
+1 -1
View File
@@ -1,4 +1,4 @@
VERSION_NAME=1000.0.0-master
VERSION_NAME=0.51.0-rc.1
GROUP=com.facebook.react
POM_NAME=ReactNative
@@ -18,7 +18,7 @@ import java.util.Map;
public class ReactNativeVersion {
public static final Map<String, Object> VERSION = MapBuilder.<String, Object>of(
"major", 0,
"minor", 0,
"minor", 51,
"patch", 0,
"prerelease", null);
"prerelease", "rc.1");
}
+2 -2
View File
@@ -1,6 +1,6 @@
{
"name": "react-native",
"version": "1000.0.0",
"version": "0.51.0-rc.1",
"description": "A framework for building native apps using React",
"license": "BSD-3-Clause",
"repository": {
@@ -207,4 +207,4 @@
"shelljs": "^0.7.8",
"sinon": "^2.2.0"
}
}
}