5 Commits

Author	SHA1	Message	Date
Samuel Susla	f303266d69	Correctly handle null values in dynamic props in prop forwarding ... Summary: Changelog: [internal] shergin found that folly's merge_patch implementation doesn't propagate `null` correctly (details in D26435620 (https://github.com/facebook/react-native/commit/1e9f63fe277c42d812ef007ced7eff1688602b62)). This is a requirement and needs to be adjusted in props forwarding on Android. As far as we know this isn't causing any bugs but it is an error that should be fixed. Reviewed By: shergin Differential Revision: D26545821 fbshipit-source-id: 9edd24aecfcde17f5d9c1197f65db0e0f3f9e364	2021-02-22 05:53:24 -08:00
Joshua Gross	b3930f935f	Convert most Fabric Cxx code to use react_native_assert instead of assert ... Summary: See react_native_assert.{h,cpp}. Because of the BUCK+Android issue where NDEBUG is always defined, we use react_native_assert instead of assert to enable xplat asserts in debug/dev mode. This migrates most of the codebase, but probably not 100%. The goal is to increase assertion coverage on Android, not to get to 100% (yet). Changelog: [Internal] Reviewed By: RSNara Differential Revision: D26562866 fbshipit-source-id: a7bf2055b973e1d3650ed8d68a6d02d556604af9	2021-02-19 20:52:52 -08:00
Samuel Susla	fc1f0df465	Introducing: Props forwarding whe cloning shadow node ... Summary: Changelog: [internal] If ShadowNode has not been mounted, forward rawProps from `sourceShadowNode` to newly cloned shadow node. This is Android specific change, on iOS the logic should remain unchanged. Reviewed By: JoshuaGross Differential Revision: D26049264 fbshipit-source-id: 7c201bc2d4e99eec024065714d2172c5c817153c	2021-01-28 11:21:21 -08:00
Valentin Shergin	900c3878e1	Fabric: Removing ShadowNode state revision ... Summary: We don't use it anymore. Changelog: [Internal] Fabric-specific internal change. Reviewed By: sammy-SC Differential Revision: D23605897 fbshipit-source-id: 3502726d2b249f75f6c3992b7685869cf7dd154f	2020-09-09 15:08:23 -07:00
David Vacca	1ae76bf0dd	Remove inner folders of react/renderer/core ... Summary: This diff removes the inner folder of react/renderer/core, moving all its files into react/renderer/core This is necessary to simplify the compilation of Fabric in OSS More details: https://fb.quip.com/amaRA631DX3K changelog: [internal] Internal Reviewed By: fkgozali, JoshuaGross Differential Revision: D22875854 fbshipit-source-id: e2d969c3ec67eab1bbdc9288e5a4285c740fa944	2020-08-01 13:31:03 -07:00