Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38505
Changelog: [Internal] - Add initial Pointer Capture API implementation
This diff introduces the first baseline implementation of pointer capturing through intercepting/modifying Pointer Events in flight through the `PointerEventsProcessor` class.
Firstly: This adds and exposes the imperative methods `setPointerCapture`, `releasePointerCapture`, and `hasPointerCapture` which is added to the host `ReadOnlyElement` ref API. These methods are used to manage/query the `pendingPointerCaptureTargetOverrides_` map as [defined in the spec](https://www.w3.org/TR/pointerevents/#setting-pointer-capture).
The code is fairly self-explainatory when it comes to retargeting the events in `PointerEventsProcessor::interceptPointerEvent` but when it comes to firing the `gotPointerCapture` and `lostPointerCapture` events those are handled in `PointerEventsProcessor::processPendingPointerCapture` and is a fairly direct implementation of [the spec's pseudocode](https://www.w3.org/TR/pointerevents/#process-pending-pointer-capture).
Finally at the end of `interceptPointerEvent` I've included the basics of implicit pointer capture *release* as per [the spec](https://www.w3.org/TR/pointerevents/#implicit-release-of-pointer-capture) (note that implicit pointer capture is not yet implemented).
Reviewed By: rozele
Differential Revision: D47533366
fbshipit-source-id: 1786f9703a88201bc9c7bde61af76eb4b07a20ee
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38928
## Changelog:
[Internal] -
This moves the call to bind the `nativePerformanceNow` function to the common place in C++ code (`JSIExecutor::initializeRuntime`), as opposed on relying on calling it from every platform-specific implementation.
I believe the reason why it was don this way, to begin with, was historical, since we did use to have a different implementation of this function on every platform. Now we have a common one in C++, anyway, so there is no reason whatsoever to have this binding platform-specific.
Reviewed By: rubennorte
Differential Revision: D48232883
fbshipit-source-id: 164dc464ab7f89e993d83a4562906e033aabb3b7
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38905
For the `build_hermesc_linux` job we don't need xlarge resources.
The current average usage for `build_hermesc_linux` is around 25%.
We can also downscale to medium in few days if this scales well.
**Insights Dashboard :**
`build_hermesc_linux`
{F1067213827}
Changelog:
[Internal] [Changed] - Downscale build_hermesc_linux job to Large
Reviewed By: cipolleschi
Differential Revision: D48200659
fbshipit-source-id: 2642d5d527e9e55cfe5c4498ea00c25915bbc883
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38795
## Context
RFC: Decoupling Flipper from React Native core: https://github.com/react-native-community/discussions-and-proposals/pull/641
## Changes
Inits new package `react-native/community-cli-plugin`. This migrates [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) into the React Native repo, to enable faster iteration by the React Native core team. Specifically:
- This package contains several `metro` dependencies, which when removed from CLI will no longer require us to ship new CLI releases to get Metro patches and features to users.
- This package contains the `start`, `bundle`, and `ram-bundle` commands (central to the React Native development experience), for which we have incoming debugging-related changes.
- This package now **only** exports commands to be attached via a RN CLI plugin. With this move, we're aiming to **internalise** the default implementations of these dev commands within React Native — other RN CLI plugins can continue to override these, but must do so wholesale. (See also the recent fix for this: https://github.com/react-native-community/cli/pull/1999.)
In V15:
- (Microsoft feedback) Re-export `unstable_buildBundleWithConfig`, marking as unstable. This gives us a time buffer to consider how we repackage this functionality in future.
The package source has been converted from TypeScript to Flow, with a number of new `flow-typed/` defs added to meet type coverage requirements.
## To dos
- For now, we aren't removing the existing [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) source — until later PRs consolidate this move by changing dependencies in the `react-native` package.
- **Exported API is reduced!**: I'm working with szymonrybczak to decouple references from RN CLI packages https://github.com/react-native-community/cli/pull/2021.
Changelog: [Internal]
Reviewed By: motiz88
Differential Revision: D46801501
fbshipit-source-id: 7f6b72941a69f487fb437768cdba125a9aa3418d
Summary:
`mFirstVisibleView` is a weak ref so it can also be null when dereferencing.
This was reported on the original PR here https://github.com/facebook/react-native/pull/35049#discussion_r1288195469
## Changelog:
[ANDROID] [FIXED] - Fix null crash when using maintainVisibleContentPosition on Android
Pull Request resolved: https://github.com/facebook/react-native/pull/38891
Test Plan: Not sure exactly in what cases this can happen, but the fix is trivial and makes sense.
Reviewed By: cortinico
Differential Revision: D48192154
Pulled By: rshest
fbshipit-source-id: 57a38a22a0e216a33603438355bde0013c014fbf
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38894
This diff introduces a script `run_with_retry` that we can apply to single commands in order to mitigate the flakiness.
This can be useful when networking is involved, to retry installing some dependencies, or for example with some e2e/integration tests.
The diff applies this rerun to the iOS tests so we mitigate failures in CI.
## Changelog:
[Internal] - Add script to retry CI steps and mitigate iOS flakyness.
Reviewed By: cortinico
Differential Revision: D48189365
fbshipit-source-id: a0e115754bcdb8f8353bb5f070163f8cf8f7c9cf
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38893
This Parameter was false and never set to true. Also, we don't know what that code does and it was not used for more than a year.
## Changelog:
[Internal] - Removing not executed code.
Reviewed By: cortinico, dmytrorykun
Differential Revision: D48189139
fbshipit-source-id: 6a4000f677958aaefadec40d531acb37c98e3ef8
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38848
In order to parallelize the Android CI, I've moved most of the building to a `build_android` step which executes before the `build_npm_package` step.
As currently, building Hermes for Android is on the critical path, this should reduce much of the execution time on CI.
Changelog:
[Internal] [Changed] - Introduce a build_android step
Reviewed By: mdvacca
Differential Revision: D48148418
fbshipit-source-id: bfe3175fcc11d96e264eb31d8d5555bd1f83c01d
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38776
in this diff I'm moving BridgelessReactPackage from com.facebook.react to com.facebook.react.bridgeless.
the goal is to hide this class from the API
changelog: [internal] internal
Reviewed By: cortinico, arushikesarwani94
Differential Revision: D48050453
fbshipit-source-id: 54ac042d491a7b8fe83e543c94e0d06bd9b88cda
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38882
This turns on local caching for Gradle builds.
From now on, some of the tasks of the build will be cached inside the `.gradle` folder.
This will benefit 'clean builds' and builds happening after branch/context switch.
CI will also benefit from this improvement as we're storing the cache folder on CircleCI.
After this we'll have to follow-up and enabling `Cacheable` on each of our task as
they're currently all disabled.
Changelog:
[Internal] [Changed] - Enable local caching for Gradle
Reviewed By: mdvacca
Differential Revision: D48187656
fbshipit-source-id: 25734ed692a69874721e86c50498b075af0fda19
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38798
Changelog:
[General][Internal] - Add example to compare perf with set state in unnecessary effect.
Reviewed By: rshest
Differential Revision: D47857125
fbshipit-source-id: f0e9f71cf2f549012394959a9087117f02e2d056
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38903
Currently Android is not rebuilding the CLI if its content changes. This is a bug.
It's resolution is a bit more complicated as we do have various `buildCodegenCLI` tasks, also in user projects.
I've removed the tasks from the user projects, as they're practically not needed (users always consume a prebuilt codegen).
And I've also updated the setup to have only one `buildCodegenCLI` in the ReactAndroid project.
This allows us to ensure the job executes only once and has correct input/outputs.
Changelog:
[Internal] [Changed] - Fix compilation avoidance bug with buildCodegenCLI
Reviewed By: mdvacca
Differential Revision: D48199157
fbshipit-source-id: ba3be6a0ca959ac4e1240e8feb99b8274e4e2b46
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38902
As now we distribute libraries on Maven Central,
users should be able to use those instead of having to download them from the
React Native CI automatically.
This is already available since React Native 0.71, so we can probably remove this extra step.
Changelog:
[Internal] [Changed] - Do not store Hermes debug symbols on CircleCI
Reviewed By: mdvacca
Differential Revision: D48197732
fbshipit-source-id: 037794ac7167b3b3cc217c76699c83cc1ba9ab60
Summary:
Fix Android build warning reporting usage of depreacted APIs: Robolectric.setupActivity() is deprecated in Android unit test
Following Google Android recommendations: https://developer.android.com/reference/androidx/test/core/app/ActivityScenario
changelog: [internal] internal
Reviewed By: cortinico
Differential Revision: D48168983
fbshipit-source-id: ac37235715578af6e28da2e219c6a942bfafca2a
Summary:
Upgrade ANDROIDX TEST VERSION to 1.4.0
This is necessary to be able to use androidx.test:core in the next diffs
changelog: [internal] internal
Reviewed By: cortinico, NickGerleman
Differential Revision: D48176680
fbshipit-source-id: 93e0ba68b2eb37ba783a9faa7d9b56425b225ae7
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38861
I'm just sorting the scripts in package.json to make it easier to consume
changelog: [internal] internal
Reviewed By: cortinico, NickGerleman
Differential Revision: D48161535
fbshipit-source-id: 473af009b05fe8bf264975245f508926f8f8dae3
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38863
I created a simple way to build RN Android using yarn:
changelog: [internal] internal
Reviewed By: cortinico, NickGerleman
Differential Revision: D48160016
fbshipit-source-id: 5157f0e717f48b32f2a6db0680c02975d9bd7a43
Summary:
This change adds a step to store the publishing logs as artifacts when the publishing fails, so that we can analyze what happened without relaunching the job
## Changelog:
[Internal] - Add step to upload publishing logs
Pull Request resolved: https://github.com/facebook/react-native/pull/38846
Test Plan: CircleCI stays green
Reviewed By: cortinico
Differential Revision: D48183313
Pulled By: cipolleschi
fbshipit-source-id: 72fa753c094224d4cb3fea952a75591688ea7822
Summary:
This PR converts the java logic inside of `JSPointerDispatcherTest.java` to Kotlin as requested in https://github.com/facebook/react-native/issues/38825
We also swap `JSPointerDispatcherTest.java` for `JSPointerDispatcherTest.kt`
## Changelog:
[Internal][Changed]: Convert JSPointerDispatcherTest to Kotlin
Pull Request resolved: https://github.com/facebook/react-native/pull/38878
Test Plan:
`./gradlew :packages:react-native:ReactAndroid:test` must pass and CI must be green
## Screenshot of Tests passing locally:
Reviewed By: rshest
Differential Revision: D48189629
Pulled By: cortinico
fbshipit-source-id: 92d869f690457986413bcae33a15225aa6e006be
Summary:
## Changelog:
[Internal] -
When trying to load JS bundle, there were conditions under which it could just silently fail, not giving much to start with when troubleshooting.
It was relying on Folly internals to handle the error, and depending on the context it could either throw an exception or just silently exit the process if exceptions are not enabled in Folly.
This diff makes this error handling more explicit, with a clear error message in the log.
Reviewed By: NickGerleman
Differential Revision: D48147690
fbshipit-source-id: 1bb08ad17a880989e829c281fe25ee0d4a385d59
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38889
As we don't really use the commitlies code in CircleCI, I'm cleaning up some of the code used to publish artifacts to the user.
Changelog:
[Internal] [Changed] - Cleanup the commitlies code
Reviewed By: cipolleschi
Differential Revision: D48189398
fbshipit-source-id: c4591ee290eba49224322d44a32052ff292ccbed
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38879
When creating a new app for iOS, you need to have Node installed properly and in the right paths in order for Xcode to pick it up.
Xcode, by default, looks into the following folders for executables:
- /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
- /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/appleinternal/bin:
- /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/local/bin:
- /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/libexec
- /Applications/Xcodefb.app/Contents/Developer/Platforms/iPhoneSimulator.platform/usr/bin
- /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/usr/appleinternal/bin
- /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/usr/local/bin
- /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/bin
- /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/local/bin
- /Applications/Xcode.app/Contents/Developer/usr/bin
- /Applications/Xcode.app/Contents/Developer/usr/local/bin
- /usr/local/bin
- /usr/bin
- /bin
- /usr/sbin
- /sbin
If `node` is not in one of them, our JS codegen scripts will fail to run. However, as soon as we run some scripts in Xcode, it is too late to properly look for node.
We already had a cocoapod step, running before the build phase, which was creating the `.xode.env` file, setting `NODE_BINARY` to `$(command -v node)`. Unfortunately, when executed by Xcode, that's too late too.
This change creates an `.xcode.env.local` file with the `$(command -v node)` command expanded, so I user can start working locally and quickly.
We had multiple reports and issues related to this configuration online. For example:
- https://www.reddit.com/r/reactnative/comments/15jpj0a/is_there_a_react_native_version_that_just_works/?utm_source=share&utm_medium=web2x&context=3
Note: we cannot automatically create simlinks to node in `/usr/local/bin` as it requires `sudo`.
## Changelog:
[Internal] - Generate `.xcode.env.local` to simplify the creation of an app.
Reviewed By: rshest
Differential Revision: D48111724
fbshipit-source-id: 49cc6375bd80458d69adbc343ead6c4408805eee
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38880
Users who interact with your app on Android 14 devices can now grant partial access to their visual media library (Photos/Videos) when an app requests any visual media permissions (READ_MEDIA_IMAGES or READ_MEDIA_VIDEO) introduced in Android 13 (API level 33).
This diff allow enable the partial access via "READ_MEDIA_VISUAL_USER_SELECTED" in Marketplace photo picker
For Android 14 this diff request partial media access plus the normal access, there will be two return cases:
- READ_MEDIA_VISUAL_USER_SELECTED is granted, READ_MEDIA_IMAGES and READ_MEDIA_VIDEO will be denied automatically, there is no need to check the later ones
- READ_MEDIA_VISUAL_USER_SELECTED is denied, then check READ_MEDIA_IMAGES and READ_MEDIA_VIDEO
Changelog:
[Android][Changed] - Enable partial media picking in Marketplace
Reviewed By: NickGerleman
Differential Revision: D48171193
fbshipit-source-id: 644f6c691f9c2c25f981ba2c255044f62b97299d
Summary:
One of the limitations of the existing flow for the release crew is that they need to manually remember to publish all the other packages in the monorepo ahead of a new patch release - this PR modifies the logic for the bump-oss-version script (and makes it available via yarn) so that it will not run if:
* there are git changes lying around
* if some of the packages need a new release
it required a bit of refactoring to extract some portions of the logic from the bump-all-package-versions script, but I think the end result is pretty decent.
## Changelog:
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[INTERNAL] [CHANGED] - improve bump oss script to allow less human errors
Pull Request resolved: https://github.com/facebook/react-native/pull/38666
Test Plan:
* checkout this branch
* comment L54 of bump-oss-version.js (to remove the check on the branch name)
* run `yarn bump-all-updated-packages`, verify that it works and that it detects that some packages have unreleased code
* run `yarn bump-oss-version -t asd -v asd` (the "fake" parameters are needed to pass the yargs check), verify that it will throw an error because it finds a package that has unreleased code
Reviewed By: mdvacca
Differential Revision: D48156963
Pulled By: cortinico
fbshipit-source-id: 2473ad5a84578c5236c905fd9aa9a88113fe8d22
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38857
`hitSlop` must be passed into the `usePressability` hook in order for it to take effect. It's a no-op if no hit slop is present
Changelog:
[Internal][Fixed] - Propagate hit slop prop to TextInput pressability config
Reviewed By: NickGerleman
Differential Revision: D48124538
fbshipit-source-id: a910fdcec55e67d37c84facca297428556ef777e
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38855
For the `test_js_prev_lts` job we don't need xlarge resources.
The current average usage for `test_js_prev_lts` is around 25%.
We can also downscale to medium in few days if this scales well.
**Insights Dashboard:**
`test_js_prev_lts`
{F1065747013}
Changelog:
[Internal] [Changed] - Downscale test_js_prev_lts job to Large
Reviewed By: cortinico, cipolleschi
Differential Revision: D48125886
fbshipit-source-id: 521fac38a1d699e576bc1ce5a3a29a47bc284e76
Summary:
[Codegen 119] This PR introduces `emitBuildEventSchema` to parser commons and abstracts the logic out of typescript and parser events as requested on https://github.com/facebook/react-native/issues/34872
## Changelog:
[Internal] [Changed] - Add `emitBuildEventSchema` to parser commons and update usages.
Pull Request resolved: https://github.com/facebook/react-native/pull/38810
Test Plan:
Run `yarn jest react-native-codegen` locally and ensure CI is green
## Screenshot of test passing locally:
<img width="1047" alt="Screenshot 2023-08-07 at 8 03 49 AM" src="https://github.com/facebook/react-native/assets/64726664/ab87f004-d9f8-4b5f-800b-0e724430301f">
Reviewed By: rshest
Differential Revision: D48155051
Pulled By: cipolleschi
fbshipit-source-id: a3db3f4783d60681b366a871b1d2ee32eb864bc0
Summary:
As we had version numbers scattered all over the places, I'm consolidating them to use a version catalog: https://docs.gradle.org/current/userguide/platforms.html
## Changelog:
[INTERNAL] - Use version catalog to consolidate versions for JVM dependencies
Pull Request resolved: https://github.com/facebook/react-native/pull/38836
Test Plan: CI
Reviewed By: cipolleschi
Differential Revision: D48150285
Pulled By: cortinico
fbshipit-source-id: 83a1867aace5395d9a10fadd6c6ab11c31fa14b5
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38827
For the `test_js` and `find_and_publish_bumped_packages` jobs we don't need xlarge resources.
The current average usage for `test_js` and `find_and_publish_bumped_packages` is around 25%.
We can also downscale to medium in few days if this scales well.
**Insights Dashboard:**
`test_js`
{F1065742668}
`find_and_publish_bumped_packages`
{F1065742888}
Changelog:
[Internal] [Changed] - Downscale test_js and find_and_publish_bumped_packages` jobs to Large
Reviewed By: cortinico
Differential Revision: D48125531
fbshipit-source-id: 004c2306fd224a5798a6b084fb75a79896695b15
Summary:
Migrate `CustomLineHeightSpanTest` to kotlin as part of ☂️https://github.com/facebook/react-native/issues/38825
## Changelog:
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[Internal] [Changed] - Migrate CustomLineHeightSpanTest to kotlin
Pull Request resolved: https://github.com/facebook/react-native/pull/38847
Test Plan:
```
./gradlew :packages:react-native:ReactAndroid:test
```
Reviewed By: rshest
Differential Revision: D48155397
Pulled By: cortinico
fbshipit-source-id: bbaa7d08a84c609bc64b48a08e1b91078ce6ef23
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38816
To save resources, we should build only arm64 for PRs and commits to mains.
Our Android ABIs are really similar and we should just build the most popular. For nightlies/releases
instead we'll have to build all the archs.
Changelog:
[Internal] [Changed] - Build only arm64 when building PRs. All archs for nightlies and releases.
Reviewed By: cipolleschi
Differential Revision: D48112361
fbshipit-source-id: 69e172a4ea69f844b344a9fc6ac4ee0471b40c36
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38815
For the template jobs, we don't need xlarge resources but we can probably use medium.
I've checked on the Insights dashboard and the average usage is at 25%
Changelog:
[Internal] [Changed] - Downscale Test Android Template jobs to Large
Reviewed By: cipolleschi
Differential Revision: D48112362
fbshipit-source-id: 3745a90d12b96818430264be43ae2672bb05d436
Vincent Riemer
Ruslan Shestopalyuk
Arushi Kesarwani
Alex Hunt
Janic Duplessis
Riccardo Cipolleschi
Nicola Corti
David Vacca
Xin Chen
bufgix
Lorenzo Sciandra
Riccardo Cipolleschi
Siddarth Kumar
Lulu Wu
Madhusudan Sapkota
Intl Scheduler
Ellis Tsung
Burak Güner
David
tarunrajput