Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37836
When using the native driver for animations that involve layout changes (ie. translateY and other transforms, but not styles such as opacity), because it bypasses Fabric, the new coordinates are not updated so the Pressability responder region/tap target is incorrect.
Prior diffs ensure that upon completion of natively driven animations, the final values are synced to the JS side AnimatedValue nodes. In this diff, on completion of a natively driven animation, AnimatedProps.update() is called, which in turn calls the value update callback on AnimatedProps, which [triggers a rerender (via setState)](https://www.internalfb.com/code/fbsource/[566daad5db45807260a8af1f85385ca86aebf894]/xplat/js/react-native-github/packages/react-native/Libraries/Animated/useAnimatedProps.js?lines=80) which has the effect of pushing the latest animated values to Fabric.
Alternative considered was using setNativeProps, but that approach was dropped as setNativeProps was only introduced to make migration easier and should not be used for new code, as per sammy-SC.
Changelog:
[General][Fixed] - When animating using native driver, trigger rerender on animation completion in order to update Pressability responder regions
Reviewed By: javache
Differential Revision: D46655246
fbshipit-source-id: b008c24f9d016be4b145ba799fffae5f55fab787
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37861
Changelog: [Internal] - Back out of "Add plumbing/boilerplate for an iOS implementation of the `gotpointercapture` and `lostpointercapture` events"
Original commit changeset: c9da5691d399
Original Phabricator Diff: D44977499
This diff appears to be causing issues as reported on T155721480 related to the file `RawPropsKeyMap.cpp` which, while I haven't figured out exactly why this is occurring, confirmed that this diff is causing the issue. In order to buy myself some more time as I diagnose this I'm backing the changes out in this diff.
Reviewed By: adanoff
Differential Revision: D46691035
fbshipit-source-id: 383b46732a3fad24a50e18ab948c96ce9bfe429e
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37849
The typing for `FabricUIManager` makes more sense as an interface (the same way we type native modules) than as an object, as the underlying implementation used to be a host object where properties were actually not enumerable, etc. This replaces that with a definition more aligned with how we actually use it.
This also allows us to extend the mock with testing specific methods more easily (like in D45278720).
Changelog: [internal]
Reviewed By: javache
Differential Revision: D46684044
fbshipit-source-id: 379cc3f95a7cbae733ed6a3a57e68b33efd21d34
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37847
Jest supports accessing the contexts used to call mock functions (the `this` value) but we're not typing that correctly in the definitions in React Native. This changes that.
Changelog: [internal]
Reviewed By: javache
Differential Revision: D46684043
fbshipit-source-id: ff121e0726748788591e7d061a39fde238c1ddbe
Summary:
This PR converts HeaderUtilTest.java to Kotlin as requested in https://github.com/facebook/react-native/issues/37708.
## Changelog:
[INTERNAL] [CHANGED] - Convert HeaderUtilTest to Kotlin
Pull Request resolved: https://github.com/facebook/react-native/pull/37829
Test Plan:
Run ./gradlew :packages:react-native:ReactAndroid:test.
All tests should pass.
Reviewed By: mdvacca
Differential Revision: D46647152
Pulled By: cortinico
fbshipit-source-id: a05108c4cae28526ac55f4f273673221e3ff4cf1
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37856
These strings are spoken to the user when using an ascessibility role or state not natively supported by Talkback.
We can enable these for translation by removing flags to disable localization, and adding descriptions to each string. These are derived from MDN for ARIA (used for iOS strings), along with Android and iOS documentation.
Note that this was explicitly disabled as part of D15087192 because of creating spam which was hitting the GitHub repo, but when translation was enabled for the dev menu, this ended up being a non-issue after initial translation. And we really do want these to be localized.
Changelog:
[Android][Fixed] - Localize Talkback strings
Reviewed By: cortinico
Differential Revision: D46692127
fbshipit-source-id: 6da4a181e03f46bad850e4385b94155695a142a8
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37839
The CocoaPods build assumes that a `cmake` command is present during `pod install`. It acts gracefully if it is not and propagates an empty string path, leading to a confusing error during the build, and requiring a `pod deintegrate` after CMake is installed because of when the binary is set.
This replaces the usage with `Pod::Executable::which!`, the built-in CocoaPods method of finding an executable from `PATH` which errors out the build if not found. This will cause a failure during `pod install`, when we are looking for the command, and specify that `cmake` is the missing executable.
This branch is only taken for source builds, so this will not show up in the cases where we do not need CocoaPods.
Changelog:
[iOS][Fixed] - Descriptive Cocoapods Error if CMake is not installed
Reviewed By: cipolleschi
Differential Revision: D46670007
fbshipit-source-id: d508743d51f9b99e1bce7d4d3cef6395d5abf46d
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37858
Changelog: [Internal]
in this diff, i add a test that runs `start` validates that the lifecycle `hostDidStart:` is called as a result.
notably, i created a custom shim for `RCTInstance` to completely stub out its behavior.
Reviewed By: cipolleschi
Differential Revision: D46508066
fbshipit-source-id: e815aee64d06b160f2cbdc52720a8e698d11c680
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37851
## Changelog
[Internal] -
The `testId` value in practice can be used for other things than e2e tests - e.g. there is already a use case for Accessibility, but also we may want to log it as an extra data point with e.g. performance metrics.
This exposes a helper function to extract a `testId` from a view.
Differential Revision: D46684365
fbshipit-source-id: 17602307c468a906ef4d0679e826dbcd1eb651b7
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37838
We see a linker failure in the OSS build because our header exports C-style functions (not ObjC), that Objective C will assume are C ABI, but we build them as C++ functions.
Internally these are all marked as `extern "C"`, so to not deviate I did the same here to expose these always as plain C functions.
Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D46671506
fbshipit-source-id: 5b3005074303763d55801c4d24ac9250b96d45ba
Summary:
[Codegen 128] This PR add a `getObjectProperties` function to the Parser interface, which returns the properties of an object represented by a type annotation as requested on https://github.com/facebook/react-native/issues/34872
## Changelog:
[INTERNAL] [ADDED] - Add getObjectProperties function to codegen Parser
Pull Request resolved: https://github.com/facebook/react-native/pull/37789
Test Plan: Run `yarn jest react-native-codegen` and ensure CI is green
Reviewed By: cipolleschi
Differential Revision: D46584748
Pulled By: rshest
fbshipit-source-id: 7f509b6f8754472a9b3048214345dc94265604ba
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37775
Most of this code was made irrelevant when we dropped support for API < 21 in D24548084.
Changelog: [Internal]
Reviewed By: NickGerleman
Differential Revision: D46557892
fbshipit-source-id: 6af85a24d476fe1010eb62126b4c5e9df14a0ea2
Summary:
React-Native-Windows had to override this file because we treat certain warning as errors. This fix adds in the "f suffix" to remove the unspecified float error.
## Changelog:
[GENERAL] [FIXED] - Specify float value in ParagraphLayoutManager
Pull Request resolved: https://github.com/facebook/react-native/pull/37660
Test Plan: Tested with RNW tests
Reviewed By: NickGerleman
Differential Revision: D46560099
Pulled By: javache
fbshipit-source-id: de593cbe60677533f5194ab8fd7e650607b5829e
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37697
Move BridgelessReactPackage to com.facebook.react package.
This is necessary because BridgelessReactPackage is a core package that needs to be part of RN (and should not be re-defined by all apps)
I will revisit naming in a later diff
bypass-github-export-checks
changelog: [internal] internal
Reviewed By: cortinico, philIip
Differential Revision: D46408934
fbshipit-source-id: ac172d22a6d70c9d33d2e119da93b25736d85383
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37602
Changelog: [Internal] - Add plumbing/boilerplate for an iOS implementation of the `gotpointercapture` and `lostpointercapture` events
This diff simply adds the boilerplate necessary to hook up the `gotpointercapture` and `lostpointercapture` events to the fabric iOS touch handler. This diff does not contain any actual implementation of their behavior as that will occur in future diffs.
Reviewed By: yungsters
Differential Revision: D44977499
fbshipit-source-id: c9da5691d399f612f1980c7692c4ca62877901a9
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37679
This reuses the localizations from the last diff on the stack, on top of the new logic added with D45797554.
Changelog:
[iOS][Fixed] - Localize Voiceover strings in Fabric
Reviewed By: philIip
Differential Revision: D46426571
fbshipit-source-id: 7e6adc9eff5e6387299e95b6ea5eba8e2607386a
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37680
Changelog:
[iOS][Fixed] - Localize Voiceover strings in Paper
## Stack
React Native on iOS adds strings to Voiceover interactions to supply more information to users . Internally, and out-of-the-box externally, these are today always announced in English instead of being localized.
This stack adds a limited new internal API, `RCTLocalizedString(string, description)` to allow auto-translated strings which are consumed by both Meta and OSS.
Reviewed By: cipolleschi
Differential Revision: D46415273
fbshipit-source-id: 4174e38cef4eee251fa2d59e10763cde8e8681ad
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37678
## Stack
React Native on iOS adds strings to Voiceover interactions to supply more information to users . Internally, and out-of-the-box externally, these are today always announced in English instead of being localized.
This stack adds a limited new internal API, `RCTLocalizedString(string, description)` to allow auto-translated strings which are consumed by both Meta and OSS.
Reviewed By: cipolleschi
Differential Revision: D46414630
fbshipit-source-id: 1137182dbbd89d959b3d143ce534229968bdb8f7
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37677
## Stack
React Native on iOS adds strings to Voiceover interactions to supply more information to users . Internally, and out-of-the-box externally, these are today always announced in English instead of being localized.
This stack adds a limited new internal API, `RCTLocalizedString(string, description)` to allow auto-translated strings which are consumed by both Meta and OSS.
Reviewed By: shwanton
Differential Revision: D46414631
fbshipit-source-id: 567a3500d39c1cb830e050edb1a644e3d8d502d3
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37676
## Stack
React Native on iOS adds strings to Voiceover interactions to supply more information to users . Internally, and out-of-the-box externally, these are today always announced in English instead of being localized.
This stack adds a limited new internal API, `RCTLocalizedString(string, description)` to allow auto-translated strings which are consumed by both Meta and OSS.
Reviewed By: javache
Differential Revision: D46399962
fbshipit-source-id: 2188a1faba9339cff00f897990b727febc178361
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37810
Changelog: [Internal]
in this change, i introduce a helper file for swizzling selectors that can be used for building custom shims and fakes. i tried putting this in the cxx target, but i struggled a lot with managing the dependencies and understanding the extra behavior that was happening from being in a `rn_xplat_cxx_library`. this file is also not obj-c++, so i feel like we should decouple if possible.
it does seem like this is a new practice i'm introducing, so let me know if there's something that i'm missing.
Reviewed By: cipolleschi
Differential Revision: D46507803
fbshipit-source-id: 9be63d992b9838e9a98ee0c1c6d684fc59c3fc80
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37811
Changelog: [Internal]
i am looking to add ios unit tests to venice and this is the first unit test suite that will test native ios code in the new architecture afaik, so i wanted to open this up to discussion.
currently, all `XCTest` in `react-native-github` are coupled with the `RNTester` target. my main qualm with this is i am concerned that it won't scale well. currently we have only ~30ish tests but ultimately if we want a proper testing suite, surely this count will be in the hundreds and that won't be able to reasonably live in a single test target.
however, the trade is that this test will not show up in RNTester. i have added a unit test to RNTester before in D31949237, however the experience was extremely painful as i had to manually update the `project.pbxproj` to include my file, and i had to manually determine what hex value was the next one (for whatever reason, this doesn't increment at the endian...).
i am wondering if we can treat the current unit testing experience in RNTester as pretty much maintenance mode and start thinking of a improved version starting with something more modular like this.
Reviewed By: cipolleschi
Differential Revision: D46467229
fbshipit-source-id: 09de9cf8bc5f8b9c86abcaf7750a6f63686d8d1a
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37812
Changelog: [Internal]
I would like to add iOS unit tests, but this testing directory has a subdirectory based on features and not platform, which makes the organization challenging, so i'm moving it to a more aptly named directory.
Reviewed By: javache
Differential Revision: D46467041
fbshipit-source-id: f2ba714dc79ecb509b86b4708320c68235354240
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37832
This parameter is currently unused and is causing Android builds to fail
as they compile with `-Wall`
This is a follow-up to https://github.com/facebook/react-native/pull/37454/ as that PR updated only the `fromJs` and not the `toJs` method as well.
Changelog:
[Internal] [Changed] - Remove CallInvoker parameter from toJs method in Codegen
Reviewed By: rshest
Differential Revision: D46647110
fbshipit-source-id: 1f3e22aca7a3df11ac02b5c4b89c9311b8b1798c
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37783
We're not checking the number of arguments received before accessing the `arguments` array in JSI methods in `UIManagerBinding`, which could cause access to garbage values. This fixes that by adding a check in all methods to ensure the number of arguments received is at least the arity of the function.
Changelog: [internal]
Reviewed By: rshest
Differential Revision: D46564580
fbshipit-source-id: 7012e0d6fb12c5024e4d6a4c0fb7a8c00263ccac
Luna Wei
Ethan Gill
Intl Scheduler
jaroslawmichalik
Genki Kondo
David Vacca
Vincent Riemer
Rubén Norte
Aymane Missouri
Nick Gerleman
Phillip Pan
Ruslan Shestopalyuk
Gabriel Donadel
Pieter De Baets
TatianaKapos
Bernhard Owen Josephus
Facebook Community BotandFacebook Community Bot
Nicola Corti