Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

JSI: Minor tweaks for building on MSVC (#23492)

Browse Source 
Summary:
This is a re-submit of #23367, which was accidentally over-written in this commit:

https://github.com/facebook/react-native/commit/0d7faf6f73b942126e1f45016cde8fd480fd0164

This pull request makes this change to `jsi.h`:

 * Tweak the call to constructor `Pointer(Runtime::PointerValue* ptr)` in the constructor for `PropNameID`. I am not sure why MSVC wasn't working with the original version, but it compiles after I tweak that.

[General] [Fixed] - Tweaked `jsi.h` to build on MSVC
Pull Request resolved: https://github.com/facebook/react-native/pull/23492

Differential Revision: D14151511

Pulled By: hramos

fbshipit-source-id: 52d726d7b978d321a0343566ee527f2ec25e93f8
This commit is contained in:
empyrical
2019-02-20 10:12:12 -08:00
committed by Facebook Github Bot
parent 38e91e6a9d
commit ff588b5087
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/jsi/jsi.h
+1 -1
View File
@@ -336,7 +336,7 @@ class PropNameID : public Pointer {
using Pointer::Pointer;
PropNameID(Runtime& runtime, const PropNameID& other)
: PropNameID(runtime.clonePropNameID(other.ptr_)) {}
: Pointer(runtime.clonePropNameID(other.ptr_)) {}
PropNameID(PropNameID&& other) = default;
PropNameID& operator=(PropNameID&& other) = default;