mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Remove JSC build logic from helloworld (#51895)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/51895 Cleaning up helloworld from all the JSC infrastructure. Changelog: [Internal] [Changed] - Reviewed By: mdvacca Differential Revision: D76265678 fbshipit-source-id: 81fd363bf484b4c22bd278199646c7b18c59c7ff
This commit is contained in:
committed by
Facebook GitHub Bot
parent
10aef584d9
commit
ff3cfff264
@@ -77,19 +77,6 @@ react {
|
||||
*/
|
||||
def enableProguardInReleaseBuilds = false
|
||||
|
||||
/**
|
||||
* The preferred build flavor of JavaScriptCore (JSC)
|
||||
*
|
||||
* For example, to use the international variant, you can use:
|
||||
* `def jscFlavor = "io.github.react-native-community:jsc-android-intl:2026004.+"`
|
||||
*
|
||||
* The international variant includes ICU i18n library and necessary data
|
||||
* allowing to use e.g. `Date.toLocaleString` and `String.localeCompare` that
|
||||
* give correct results when using with locales other than en-US. Note that
|
||||
* this variant is about 6MiB larger per architecture than default.
|
||||
*/
|
||||
def jscFlavor = "io.github.react-native-community:jsc-android:2026004.+"
|
||||
|
||||
android {
|
||||
ndkVersion rootProject.ext.ndkVersion
|
||||
buildToolsVersion rootProject.ext.buildToolsVersion
|
||||
@@ -128,10 +115,5 @@ android {
|
||||
dependencies {
|
||||
// The version of react-native is set by the React Native Gradle Plugin
|
||||
implementation("com.facebook.react:react-android")
|
||||
|
||||
if (hermesEnabled.toBoolean()) {
|
||||
implementation("com.facebook.react:hermes-android")
|
||||
} else {
|
||||
implementation jscFlavor
|
||||
}
|
||||
implementation("com.facebook.react:hermes-android")
|
||||
}
|
||||
|
||||
@@ -32,7 +32,7 @@ class MainApplication : Application(), ReactApplication {
|
||||
override fun getUseDeveloperSupport(): Boolean = BuildConfig.DEBUG
|
||||
|
||||
override val isNewArchEnabled: Boolean = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED
|
||||
override val isHermesEnabled: Boolean = BuildConfig.IS_HERMES_ENABLED
|
||||
override val isHermesEnabled: Boolean = true
|
||||
}
|
||||
|
||||
override val reactHost: ReactHost
|
||||
|
||||
Reference in New Issue
Block a user