mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
4/n Display a RedBox with the JS stack (instead of native stack) when an unhandled JS exceptions occurs
Summary: Changelog: [iOS][Changed] Display a RedBox with the JS stack (instead of native stack) when an unhandled JS exceptions occurs ----- # A0) Bridge mode, Unhandled Exception, FBiOS Unhandled exception goes to FBReactModule, but the JS Stack is not parsed correctly. https://www.internalfb.com/code/fbsource/[312d5cbdd7278247a84619786b12a44c4400fcc0]/fbobjc/Apps/Wilde/FBReactModule2/FBReactModuleAPI/FBReactModuleAPI/Exported/FBReactModule.mm?lines=1488%2C1493 See `****** FBReactModule handleFatalError` in the logs P539306390, and compare with correct behavior in (A1) in the Test Plan. https://pxl.cl/2h6h3 {F782257996} ----- # A) Before diff, rn-tester Open to rn-tester -> APIs -> Crash Examples -> JS Crash. Set `RCTParseUnhandledJSErrorStackNatively` to YES. https://www.internalfb.com/code/fbsource/[98880e52ee78be3614e5d9a2ce3292f6a7b5e413]/xplat/js/react-native-github/React/Base/RCTConstants.m?lines=73 {F783395297} Reviewed By: sammy-SC Differential Revision: D40387938 fbshipit-source-id: 2abea657476d3bf61ad5b1c643f129e44c6f3f35
This commit is contained in:
1 parent
466ba91657
commit
ff398e4e26
10 files changed
+94
-25
No files matched your search
@@ -254,8 +254,6 @@ Pod::Spec.new do |s|
|
||||
end
|
||||
|
||||
s.subspec "mapbuffer" do |ss|
|
||||
ss.dependency folly_dep_name, folly_version
|
||||
ss.compiler_flags = folly_compiler_flags
|
||||
ss.source_files = "react/renderer/mapbuffer/**/*.{m,mm,cpp,h}"
|
||||
ss.exclude_files = "react/renderer/mapbuffer/tests"
|
||||
ss.header_dir = "react/renderer/mapbuffer"
|
||||
|
||||
@@ -23,8 +23,6 @@ rn_xplat_cxx_library(
|
||||
"PUBLIC",
|
||||
],
|
||||
deps = [
|
||||
"//xplat/folly:dynamic",
|
||||
"//xplat/folly:json",
|
||||
"//xplat/jsi:jsi",
|
||||
react_native_xplat_target("react/renderer/mapbuffer:mapbuffer"),
|
||||
],
|
||||
|
||||
@@ -17,8 +17,10 @@ namespace react {
|
||||
|
||||
using facebook::react::JSErrorHandlerKey;
|
||||
|
||||
static MapBuffer
|
||||
parseErrorStack(const jsi::JSError &error, bool isFatal, bool isHermes) {
|
||||
MapBuffer JsErrorHandler::parseErrorStack(
|
||||
const jsi::JSError &error,
|
||||
bool isFatal,
|
||||
bool isHermes) {
|
||||
/**
|
||||
* This parses the different stack traces and puts them into one format
|
||||
* This borrows heavily from TraceKit (https://github.com/occ/TraceKit)
|
||||
@@ -99,7 +101,7 @@ JsErrorHandler::~JsErrorHandler() {}
|
||||
void JsErrorHandler::handleJsError(const jsi::JSError &error, bool isFatal) {
|
||||
// TODO: Current error parsing works and is stable. Can investigate using
|
||||
// REGEX_HERMES to get additional Hermes data, though it requires JS setup.
|
||||
MapBuffer errorMap = parseErrorStack(error, isFatal, false);
|
||||
MapBuffer errorMap = JsErrorHandler::parseErrorStack(error, isFatal, false);
|
||||
_jsErrorHandlingFunc(std::move(errorMap));
|
||||
}
|
||||
|
||||
|
||||
@@ -26,6 +26,9 @@ class JsErrorHandler {
|
||||
public:
|
||||
using JsErrorHandlingFunc = std::function<void(MapBuffer errorMap)>;
|
||||
|
||||
static MapBuffer
|
||||
parseErrorStack(const jsi::JSError &error, bool isFatal, bool isHermes);
|
||||
|
||||
JsErrorHandler(JsErrorHandlingFunc jsErrorHandlingFunc);
|
||||
~JsErrorHandler();
|
||||
|
||||
|
||||
@@ -0,0 +1,36 @@
|
||||
# Copyright (c) Meta Platforms, Inc. and affiliates.
|
||||
#
|
||||
# This source code is licensed under the MIT license found in the
|
||||
# LICENSE file in the root directory of this source tree.
|
||||
|
||||
require "json"
|
||||
|
||||
package = JSON.parse(File.read(File.join(__dir__, "..", "..", "package.json")))
|
||||
version = package['version']
|
||||
|
||||
source = { :git => 'https://github.com/facebook/react-native.git' }
|
||||
if version == '1000.0.0'
|
||||
# This is an unpublished version, use the latest commit hash of the react-native repo, which we’re presumably in.
|
||||
source[:commit] = `git rev-parse HEAD`.strip if system("git rev-parse --git-dir > /dev/null 2>&1")
|
||||
else
|
||||
source[:tag] = "v#{version}"
|
||||
end
|
||||
|
||||
Pod::Spec.new do |s|
|
||||
s.name = "React-jserrorhandler"
|
||||
s.version = version
|
||||
s.summary = "-" # TODO
|
||||
s.homepage = "https://reactnative.dev/"
|
||||
s.license = package["license"]
|
||||
s.author = "Facebook, Inc. and its affiliates"
|
||||
s.platforms = { :ios => "12.4", :tvos => "12.4" }
|
||||
s.public_header_files = [ "JsErrorHandler.h" ]
|
||||
s.source = source
|
||||
s.source_files = "*.{cpp,h}"
|
||||
s.pod_target_xcconfig = { "HEADER_SEARCH_PATHS" => "" }
|
||||
s.header_dir = "jserrorhandler"
|
||||
|
||||
s.dependency "React-jsi", version
|
||||
s.dependency "React-Fabric/mapbuffer", version
|
||||
|
||||
end
|
||||
Reference in new issue
Block a user