mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Paige Sun
ff398e4e26
Summary: Changelog: [iOS][Changed] Display a RedBox with the JS stack (instead of native stack) when an unhandled JS exceptions occurs ----- # A0) Bridge mode, Unhandled Exception, FBiOS Unhandled exception goes to FBReactModule, but the JS Stack is not parsed correctly. https://www.internalfb.com/code/fbsource/[312d5cbdd7278247a84619786b12a44c4400fcc0]/fbobjc/Apps/Wilde/FBReactModule2/FBReactModuleAPI/FBReactModuleAPI/Exported/FBReactModule.mm?lines=1488%2C1493 See `****** FBReactModule handleFatalError` in the logs P539306390, and compare with correct behavior in (A1) in the Test Plan. https://pxl.cl/2h6h3 {F782257996} ----- # A) Before diff, rn-tester Open to rn-tester -> APIs -> Crash Examples -> JS Crash. Set `RCTParseUnhandledJSErrorStackNatively` to YES. https://www.internalfb.com/code/fbsource/[98880e52ee78be3614e5d9a2ce3292f6a7b5e413]/xplat/js/react-native-github/React/Base/RCTConstants.m?lines=73 {F783395297} Reviewed By: sammy-SC Differential Revision: D40387938 fbshipit-source-id: 2abea657476d3bf61ad5b1c643f129e44c6f3f35
43 lines
963 B
C++
43 lines
963 B
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <jsi/jsi.h>
|
|
#include <react/renderer/mapbuffer/MapBuffer.h>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
enum JSErrorHandlerKey : uint16_t {
|
|
kFrameFileName = 0,
|
|
kFrameMethodName = 1,
|
|
kFrameLineNumber = 2,
|
|
kFrameColumnNumber = 3,
|
|
kAllStackFrames = 4,
|
|
kErrorMessage = 5,
|
|
kExceptionId = 6,
|
|
kIsFatal = 7
|
|
};
|
|
|
|
class JsErrorHandler {
|
|
public:
|
|
using JsErrorHandlingFunc = std::function<void(MapBuffer errorMap)>;
|
|
|
|
static MapBuffer
|
|
parseErrorStack(const jsi::JSError &error, bool isFatal, bool isHermes);
|
|
|
|
JsErrorHandler(JsErrorHandlingFunc jsErrorHandlingFunc);
|
|
~JsErrorHandler();
|
|
|
|
void handleJsError(const jsi::JSError &error, bool isFatal);
|
|
|
|
private:
|
|
JsErrorHandlingFunc _jsErrorHandlingFunc;
|
|
};
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|