Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Deprecate method UIManagerModule.viewIsDescendantOf

Browse Source 
Summary:
We are deprecating the method UIManagerModule.viewIsDescendantOf as this is not going to be part of Fabric.

For more context: https://github.com/facebook/react-native/commit/9ae7f0c7dac732c8c2f2253699f7bcf04943e98b#commitcomment-34177828

Reviewed By: fkgozali

Differential Revision: D16186404

fbshipit-source-id: 146600c2da20a7a39c50538741d5822838947f3c
This commit is contained in:
David Vacca
2019-07-10 20:52:57 -07:00
committed by Facebook Github Bot
parent 0fb3fb1d8e
commit fdd8debee0
2 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/uimanager/UIImplementation.java
+6 -1
View File
@@ -513,7 +513,12 @@ public class UIImplementation {
mOperationsQueue.enqueueFindTargetForTouch(reactTag, targetX, targetY, callback);
}
/** Check if the first shadow node is the descendant of the second shadow node */
/**
* Check if the first shadow node is the descendant of the second shadow node
*
* @deprecated This method will not be implemented in Fabric.
*/
@Deprecated
public void viewIsDescendantOf(
final int reactTag, final int ancestorReactTag, final Callback callback) {
ReactShadowNode node = mShadowNodeRegistry.getNode(reactTag);
ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java
+6 -1
View File
@@ -629,8 +629,13 @@ public class UIManagerModule extends ReactContextBaseJavaModule
callback);
}
/** Check if the first shadow node is the descendant of the second shadow node */
/**
* Check if the first shadow node is the descendant of the second shadow node
*
* @deprecated This method will not be part of Fabric.
*/
@ReactMethod
@Deprecated
public void viewIsDescendantOf(
final int reactTag, final int ancestorReactTag, final Callback callback) {
mUIImplementation.viewIsDescendantOf(reactTag, ancestorReactTag, callback);