From fdd8debee0ddc3cd934d6c3b7d545e00f5d69ed2 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Wed, 10 Jul 2019 20:52:57 -0700 Subject: [PATCH] Deprecate method UIManagerModule.viewIsDescendantOf Summary: We are deprecating the method UIManagerModule.viewIsDescendantOf as this is not going to be part of Fabric. For more context: https://github.com/facebook/react-native/commit/9ae7f0c7dac732c8c2f2253699f7bcf04943e98b#commitcomment-34177828 Reviewed By: fkgozali Differential Revision: D16186404 fbshipit-source-id: 146600c2da20a7a39c50538741d5822838947f3c --- .../com/facebook/react/uimanager/UIImplementation.java | 7 ++++++- .../java/com/facebook/react/uimanager/UIManagerModule.java | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIImplementation.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIImplementation.java index 11bb030ff38..b0aa380e1ab 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIImplementation.java +++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIImplementation.java @@ -513,7 +513,12 @@ public class UIImplementation { mOperationsQueue.enqueueFindTargetForTouch(reactTag, targetX, targetY, callback); } - /** Check if the first shadow node is the descendant of the second shadow node */ + /** + * Check if the first shadow node is the descendant of the second shadow node + * + * @deprecated This method will not be implemented in Fabric. + */ + @Deprecated public void viewIsDescendantOf( final int reactTag, final int ancestorReactTag, final Callback callback) { ReactShadowNode node = mShadowNodeRegistry.getNode(reactTag); diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java index f91d281c42b..3bb4aeb083d 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java +++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java @@ -629,8 +629,13 @@ public class UIManagerModule extends ReactContextBaseJavaModule callback); } - /** Check if the first shadow node is the descendant of the second shadow node */ + /** + * Check if the first shadow node is the descendant of the second shadow node + * + * @deprecated This method will not be part of Fabric. + */ @ReactMethod + @Deprecated public void viewIsDescendantOf( final int reactTag, final int ancestorReactTag, final Callback callback) { mUIImplementation.viewIsDescendantOf(reactTag, ancestorReactTag, callback);