Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix initialization of FeatureFlags in DefaultNewArchitectureEntryPoint (#46681)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/46681

Fix initialization of FeatureFlags in DefaultNewArchitectureEntryPoint

D60364016 introduced a bug, disabling Fabric and TurboModules when DefaultNewArchitectureEntryPoint is initialized with bridgless disabled

changelog: [internal] internal

Reviewed By: shwanton

Differential Revision: D63474698

fbshipit-source-id: 8b5aaeeda564d3463d13448b0adc7e964015000e
This commit is contained in:
David Vacca
2024-09-26 14:23:04 -07:00
committed by Facebook GitHub Bot
parent 9cd83fa9ab
commit fc9fcb5976
1 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultNewArchitectureEntryPoint.kt
+10 -12
View File
@@ -39,21 +39,19 @@ public object DefaultNewArchitectureEntryPoint {
error(errorMessage)
}
if (bridgelessEnabled) {
ReactNativeFeatureFlags.override(
object : ReactNativeNewArchitectureFeatureFlagsDefaults() {
override fun useFabricInterop(): Boolean = fabricEnabled
ReactNativeFeatureFlags.override(
object : ReactNativeNewArchitectureFeatureFlagsDefaults(bridgelessEnabled) {
override fun useFabricInterop(): Boolean = bridgelessEnabled || fabricEnabled
override fun enableFabricRenderer(): Boolean = fabricEnabled
override fun enableFabricRenderer(): Boolean = bridgelessEnabled || fabricEnabled
// We turn this feature flag to true for OSS to fix #44610 and #45126 and other
// similar bugs related to pressable.
override fun enableEventEmitterRetentionDuringGesturesOnAndroid(): Boolean =
fabricEnabled
// We turn this feature flag to true for OSS to fix #44610 and #45126 and other
// similar bugs related to pressable.
override fun enableEventEmitterRetentionDuringGesturesOnAndroid(): Boolean =
bridgelessEnabled || fabricEnabled
override fun useTurboModules(): Boolean = turboModulesEnabled
})
}
override fun useTurboModules(): Boolean = bridgelessEnabled || turboModulesEnabled
})
privateFabricEnabled = fabricEnabled
privateTurboModulesEnabled = turboModulesEnabled