Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Interop: Implement RCTBridgeProxy registerSegmentWithId (#38299)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38299

Bridgeless mode replaces RCTCxxBridge registerSegmentWithId with RCTHost registerSegmentWithId.

This diff implements RCTBridgeProxy registerSegmentWithId.

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D47349027

fbshipit-source-id: b87c395f65ebc8db23ca8e614341227d96435ece
This commit is contained in:
Ramanpreet Nara
2023-07-12 12:12:39 -07:00
committed by Facebook GitHub Bot
parent 55628acbdc
commit fb64a5ff75
3 changed files with 22 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/React/Base/RCTBridgeProxy.h
+2 -1
View File
@@ -19,7 +19,8 @@
moduleRegistry:(RCTModuleRegistry *)moduleRegistry
bundleManager:(RCTBundleManager *)bundleManager
callableJSModules:(RCTCallableJSModules *)callableJSModules
dispatchToJSThread:(void (^)(dispatch_block_t))dispatchToJSThread NS_DESIGNATED_INITIALIZER;
dispatchToJSThread:(void (^)(dispatch_block_t))dispatchToJSThread
registerSegmentWithId:(void (^)(NSNumber *, NSString *))registerSegmentWithId NS_DESIGNATED_INITIALIZER;
- (NSMethodSignature *)methodSignatureForSelector:(SEL)sel;
- (void)forwardInvocation:(NSInvocation *)invocation;
packages/react-native/React/Base/RCTBridgeProxy.mm
+4 -1
View File
@@ -27,6 +27,7 @@ using namespace facebook;
RCTBundleManager *_bundleManager;
RCTCallableJSModules *_callableJSModules;
void (^_dispatchToJSThread)(dispatch_block_t);
void (^_registerSegmentWithId)(NSNumber *, NSString *);
}
- (instancetype)initWithViewRegistry:(RCTViewRegistry *)viewRegistry
@@ -34,6 +35,7 @@ using namespace facebook;
bundleManager:(RCTBundleManager *)bundleManager
callableJSModules:(RCTCallableJSModules *)callableJSModules
dispatchToJSThread:(void (^)(dispatch_block_t))dispatchToJSThread
registerSegmentWithId:(void (^)(NSNumber *, NSString *))registerSegmentWithId
{
self = [super self];
if (self) {
@@ -42,6 +44,7 @@ using namespace facebook;
self->_bundleManager = bundleManager;
self->_callableJSModules = callableJSModules;
self->_dispatchToJSThread = dispatchToJSThread;
self->_registerSegmentWithId = registerSegmentWithId;
}
return self;
}
@@ -159,7 +162,7 @@ using namespace facebook;
- (void)registerSegmentWithId:(NSUInteger)segmentId path:(NSString *)path
{
[self logError:@"Please migrate to RCTHost registerSegmentWithId. Nooping" cmd:_cmd];
self->_registerSegmentWithId(@(segmentId), path);
}
- (id<RCTBridgeDelegate>)delegate
packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTInstance.mm
+16 -11
View File
@@ -225,17 +225,22 @@ void RCTInstanceSetRuntimeDiagnosticFlags(NSString *flags)
timerManager->setRuntimeExecutor(bufferedRuntimeExecutor);
RCTBridgeProxy *bridgeProxy = RCTTurboModuleInteropEnabled() && RCTTurboModuleInteropBridgeProxyEnabled()
? [[RCTBridgeProxy alloc]
initWithViewRegistry:_bridgeModuleDecorator.viewRegistry_DEPRECATED
moduleRegistry:_bridgeModuleDecorator.moduleRegistry
bundleManager:_bridgeModuleDecorator.bundleManager
callableJSModules:_bridgeModuleDecorator.callableJSModules
dispatchToJSThread:^(dispatch_block_t block) {
__strong __typeof(self) strongSelf = weakSelf;
if (strongSelf && strongSelf->_valid) {
strongSelf->_reactInstance->getBufferedRuntimeExecutor()([=](jsi::Runtime &runtime) { block(); });
}
}]
? [[RCTBridgeProxy alloc] initWithViewRegistry:_bridgeModuleDecorator.viewRegistry_DEPRECATED
moduleRegistry:_bridgeModuleDecorator.moduleRegistry
bundleManager:_bridgeModuleDecorator.bundleManager
callableJSModules:_bridgeModuleDecorator.callableJSModules
dispatchToJSThread:^(dispatch_block_t block) {
__strong __typeof(self) strongSelf = weakSelf;
if (strongSelf && strongSelf->_valid) {
strongSelf->_reactInstance->getBufferedRuntimeExecutor()([=](jsi::Runtime &runtime) { block(); });
}
}
registerSegmentWithId:^(NSNumber *segmentId, NSString *path) {
__strong __typeof(self) strongSelf = weakSelf;
if (strongSelf && strongSelf->_valid) {
[strongSelf registerSegmentWithId:segmentId path:path];
}
}]
: nil;
// Set up TurboModules