Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix ignored --projectRoot/watchFolders arguments (#21165)

Browse Source 
Summary:
Due to Kureev's cleanup in https://github.com/facebook/react-native/commit/c4a66a89a28152cd4b81e2b0f80ab3aac34d6872 some arguments are no longer properly passed to metro, but just the default values. This broke the `--projectRoot` and `--watchFolders` arguments used by storybook to change the bundle entrypoint.

This PR simply fixes the regression by assigning these values from argv instead of reading config defaults.

Related: the undocumented `REACT_NATIVE_APP_ROOT` env var is broken, not sure for how long, but I can fix it as a part of this PR or make a new one.
Pull Request resolved: https://github.com/facebook/react-native/pull/21165

Differential Revision: D9929642

Pulled By: hramos

fbshipit-source-id: 00485a0429bd4301de03e5cb455e928878c4ba8f
This commit is contained in:
Joel Arvidsson
2018-09-21 15:37:58 +01:00
committed by Lorenzo Sciandra
parent 202715c95d
commit fb109e9120
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
local-cli/server/runServer.js
+2
View File
@@ -58,6 +58,8 @@ async function runServer(args: Args, config: ConfigT) {
config.server.port = args.port;
config.reporter = reporter;
config.resetCache = args.resetCache;
config.projectRoot = args.projectRoot;
config.watchFolders = args.watchFolders.slice(0);
config.server.enhanceMiddleware = middleware =>
middlewareManager.getConnectInstance().use(middleware);