Fix helloworld e2e after core-cli-utils stopped publishing (#57308)

Summary:
Pull Request resolved: https://github.com/react/react-native/pull/57308

`private/helloworld` depends on `react-native/core-cli-utils` (it imports `android`, `app`, and `apple` from it to build the app), but that package is no longer published to npm nor to the local Verdaccio proxy that the e2e build installs against. Since `private/helloworld` is excluded from the workspace, it installs standalone, so its `"*"` dependency on `react-native/core-cli-utils` could not resolve and `npm install` failed with `E404`.

Resolve `"*"`-pinned in-repo `react-native/*` dependencies to a local `file:` path in `_prepareHelloWorld()`, so helloworld consumes `core-cli-utils` directly from its in-repo reference implementation regardless of whether it is published. This mirrors how the `react-native` package itself is already wired up for the e2e build.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D109374920

fbshipit-source-id: b6668785387511fa54580ee75e81f13168782797
This commit is contained in:
Peter Abbondanzo authored and meta-codesync[bot] committed 2026-06-23 05:52:17 -07:00
1 parent 53369ed321
commit fa8fad84d6
1 file changed
+27 -18
+27 -18
View File
@@ -136,7 +136,11 @@ async function initNewProjectFromSource(
if (useHelloWorld) {
console.log('Preparing private/helloworld/ to be built');
_prepareHelloWorld(version, pathToLocalReactNative);
const localPackages = await getPackages({
includeReactNative: false,
includePrivate: true,
});
_prepareHelloWorld(version, pathToLocalReactNative, localPackages);
directory = path.join(PRIVATE_DIR, 'helloworld');
} else {
const pathToTemplate = _prepareTemplate(
@@ -209,6 +213,7 @@ async function installProjectUsingProxy(cwd /*: string */) {
function _prepareHelloWorld(
version /*: string */,
pathToLocalReactNative /*: ?string*/,
packages /*: ProjectInfo */,
) {
const helloworldDir = path.join(PRIVATE_DIR, 'helloworld');
const helloworldPackageJson = path.join(helloworldDir, 'package.json');
@@ -216,24 +221,28 @@ function _prepareHelloWorld(
fs.readFileSync(helloworldPackageJson, 'utf8'),
);
// and update the dependencies and devDependencies of packages scoped as @react-native
// to the version passed as parameter
for (const key of Object.keys(packageJson.dependencies)) {
if (
key.startsWith('@react-native/') &&
packageJson.dependencies[key] !== '*'
) {
packageJson.dependencies[key] = version;
// Point each in-repo @react-native/* dependency at the version published to
// the local proxy. Deps declared as `*` are unpublished reference packages
// (e.g. @react-native/core-cli-utils, which lives in private/) and are absent
// from the proxy, so resolve those to their local source via a `file:` path.
const updateDependencies = (deps /*: Record<string, string> */) => {
for (const key of Object.keys(deps)) {
if (!key.startsWith('@react-native/')) {
continue;
}
if (deps[key] === '*') {
const localPackage = packages[key];
if (localPackage != null) {
deps[key] = `file:${path.relative(helloworldDir, localPackage.path)}`;
}
} else {
deps[key] = version;
}
}
}
for (const key of Object.keys(packageJson.devDependencies)) {
if (
key.startsWith('@react-native/') &&
packageJson.devDependencies[key] !== '*'
) {
packageJson.devDependencies[key] = version;
}
}
};
updateDependencies(packageJson.dependencies);
updateDependencies(packageJson.devDependencies);
if (pathToLocalReactNative != null) {
packageJson.dependencies['react-native'] = `file:${pathToLocalReactNative}`;
}