Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cosmetic adjustments to ShadowNode::getAncestors

Browse Source 
Summary:
Changelog: [internal]

Just cosmetic changes to code, shouldn't affect behaviour at all.

Reviewed By: shergin

Differential Revision: D19177494

fbshipit-source-id: b2e4d3d2cf0d30f40f2e2d950dd7a10dc7a5b5ea
This commit is contained in:
Samuel Susla
2019-12-20 01:01:55 -08:00
committed by Facebook Github Bot
parent a195447539
commit f871bbada2
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/fabric/core/shadownode/ShadowNode.cpp
+5 -7
View File
@@ -229,27 +229,25 @@ void ShadowNode::setMounted(bool mounted) const {
AncestorList ShadowNode::getAncestors(
ShadowNode const &ancestorShadowNode) const {
auto ancestors = AncestorList{};
auto families = better::small_vector<ShadowNodeFamily const *, 64>{};
auto ancestorFamily = ancestorShadowNode.family_.get();
auto descendantFamily = family_.get();
auto family = descendantFamily;
auto family = family_.get();
while (family && family != ancestorFamily) {
families.push_back(family);
family = family->parent_.lock().get();
}
if (family != ancestorFamily) {
ancestors.clear();
return ancestors;
return {};
}
auto ancestors = AncestorList{};
auto parentNode = &ancestorShadowNode;
for (auto it = families.rbegin(); it != families.rend(); it++) {
auto childFamily = *it;
auto found = bool{false};
auto childIndex = int{0};
auto found = false;
auto childIndex = 0;
for (const auto &childNode : *parentNode->children_) {
if (childNode->family_.get() == childFamily) {
ancestors.push_back({*parentNode, childIndex});