mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Back out "remove RCTSurfaceSizeMeasureMode from public contract of RCTSurfaceHostingProxyRootView"
Summary: Original commit changeset: c3240ad4c1e6 Original Phabricator Diff: D48140102 Changelog: [Internal] i suck bypass-github-export-checks Reviewed By: makovkastar Differential Revision: D48449490 fbshipit-source-id: e398726dda8b8f08ab55326c1f210b3b01b09dc5
This commit is contained in:
committed by
Facebook GitHub Bot
parent
8548eb5d2a
commit
f2b102485f
@@ -87,8 +87,10 @@ static NSString *const kRNConcurrentRoot = @"concurrentRoot";
|
||||
RCTFabricSurface *surface = [_reactHost createSurfaceWithModuleName:self.moduleName
|
||||
initialProperties:launchOptions];
|
||||
|
||||
RCTSurfaceHostingProxyRootView *surfaceHostingProxyRootView =
|
||||
[[RCTSurfaceHostingProxyRootView alloc] initWithSurface:surface moduleRegistry:[_reactHost getModuleRegistry]];
|
||||
RCTSurfaceHostingProxyRootView *surfaceHostingProxyRootView = [[RCTSurfaceHostingProxyRootView alloc]
|
||||
initWithSurface:surface
|
||||
sizeMeasureMode:RCTSurfaceSizeMeasureModeWidthExact | RCTSurfaceSizeMeasureModeHeightExact
|
||||
moduleRegistry:[_reactHost getModuleRegistry]];
|
||||
|
||||
rootView = (RCTRootView *)surfaceHostingProxyRootView;
|
||||
#endif
|
||||
|
||||
+3
-1
@@ -45,7 +45,9 @@ NS_ASSUME_NONNULL_BEGIN
|
||||
/**
|
||||
* Bridgeless mode initializer
|
||||
*/
|
||||
- (instancetype)initWithSurface:(id<RCTSurfaceProtocol>)surface moduleRegistry:(RCTModuleRegistry *)moduleRegistry;
|
||||
- (instancetype)initWithSurface:(id<RCTSurfaceProtocol>)surface
|
||||
sizeMeasureMode:(RCTSurfaceSizeMeasureMode)sizeMeasureMode
|
||||
moduleRegistry:(RCTModuleRegistry *)moduleRegistry;
|
||||
|
||||
- (instancetype)initWithSurface:(id<RCTSurfaceProtocol>)surface;
|
||||
|
||||
|
||||
+44
-2
@@ -53,9 +53,51 @@ static RCTRootViewSizeFlexibility convertToRootViewSizeFlexibility(RCTSurfaceSiz
|
||||
RCTModuleRegistry *_moduleRegistry;
|
||||
}
|
||||
|
||||
- (instancetype)initWithSurface:(id<RCTSurfaceProtocol>)surface moduleRegistry:(RCTModuleRegistry *)moduleRegistry
|
||||
- (instancetype)initWithBridge:(RCTBridge *)bridge
|
||||
moduleName:(NSString *)moduleName
|
||||
initialProperties:(NSDictionary *)initialProperties
|
||||
{
|
||||
if (self = [self initWithSurface:surface]) {
|
||||
RCTAssertMainQueue();
|
||||
RCTAssert(bridge, @"A bridge instance is required to create an RCTSurfaceHostingProxyRootView");
|
||||
RCTAssert(moduleName, @"A moduleName is required to create an RCTSurfaceHostingProxyRootView");
|
||||
|
||||
RCT_PROFILE_BEGIN_EVENT(RCTProfileTagAlways, @"-[RCTSurfaceHostingProxyRootView init]", nil);
|
||||
|
||||
_bridge = bridge;
|
||||
_minimumSize = CGSizeZero;
|
||||
|
||||
if (!bridge.isLoading) {
|
||||
[bridge.performanceLogger markStartForTag:RCTPLTTI];
|
||||
}
|
||||
|
||||
// `RCTRootViewSizeFlexibilityNone` is the RCTRootView's default.
|
||||
RCTSurfaceSizeMeasureMode sizeMeasureMode = convertToSurfaceSizeMeasureMode(RCTRootViewSizeFlexibilityNone);
|
||||
|
||||
self = [super initWithBridge:bridge
|
||||
moduleName:moduleName
|
||||
initialProperties:initialProperties
|
||||
sizeMeasureMode:sizeMeasureMode];
|
||||
|
||||
RCT_PROFILE_END_EVENT(RCTProfileTagAlways, @"");
|
||||
|
||||
return self;
|
||||
}
|
||||
|
||||
- (instancetype)initWithBundleURL:(NSURL *)bundleURL
|
||||
moduleName:(NSString *)moduleName
|
||||
initialProperties:(NSDictionary *)initialProperties
|
||||
launchOptions:(NSDictionary *)launchOptions
|
||||
{
|
||||
RCTBridge *bridge = [[RCTBridge alloc] initWithBundleURL:bundleURL moduleProvider:nil launchOptions:launchOptions];
|
||||
|
||||
return [self initWithBridge:bridge moduleName:moduleName initialProperties:initialProperties];
|
||||
}
|
||||
|
||||
- (instancetype)initWithSurface:(id<RCTSurfaceProtocol>)surface
|
||||
sizeMeasureMode:(RCTSurfaceSizeMeasureMode)sizeMeasureMode
|
||||
moduleRegistry:(RCTModuleRegistry *)moduleRegistry
|
||||
{
|
||||
if (self = [super initWithSurface:surface sizeMeasureMode:sizeMeasureMode]) {
|
||||
_moduleRegistry = moduleRegistry;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user