Use module umbrella headers in react/renderer/animated headers (#58729)

Summary:
Pull Request resolved: https://github.com/react/react-native/pull/58729

Replace direct includes of umbrella-guarded headers in the public and internal headers of `react/renderer/animated` with the module umbrellas: `<React/Debug.h>`, `<React/RendererCore.h>`, `<React/Graphics.h>`, `<React/Bridging.h>` and `<React/NativeModuleCore.h>`.

`react/bridging` and `react/nativemodule/core` are added as explicit dependencies in Buck and CMake, and the `animated` CocoaPods subspec now depends on the `React-Fabric/coreUmbrella` and `ReactCommon/turbomodule/coreUmbrella` subspecs so the umbrella paths resolve.

Changelog: [Internal]

Reviewed By: christophpurrer

Differential Revision: D122315385

fbshipit-source-id: fb9e316d3b42af31390ab8f3fcf00fa37922845d
This commit is contained in:
Jakub Piasecki authored and meta-codesync[bot] committed 2026-10-05 00:19:23 -07:00
1 parent 024b474ce9
commit f25e1881d6
13 files changed
+19 -18

No files matched your search

@@ -60,6 +60,8 @@ Pod::Spec.new do |s|
s.subspec "animated" do |ss|
ss.dependency "React-Fabric/animationbackend"
ss.dependency "React-Fabric/coreUmbrella"
ss.dependency "ReactCommon/turbomodule/coreUmbrella"
ss.source_files = podspec_sources("react/renderer/animated/**/*.{m,mm,cpp,h}", "react/renderer/animated/**/*.{h}")
ss.exclude_files = "react/renderer/animated/tests"
ss.header_dir = "react/renderer/animated"
@@ -14,11 +14,11 @@
#else
#include <FBReactNativeSpec/FBReactNativeSpecJSI.h>
#endif
#include <ReactCommon/TurboModuleWithJSIBindings.h>
#include <React/NativeModuleCore.h>
#include <React/RendererCore.h>
#include <folly/dynamic.h>
#include <react/renderer/animated/NativeAnimatedNodesManager.h>
#include <react/renderer/animated/NativeAnimatedNodesManagerProvider.h>
#include <react/renderer/core/ReactPrimitives.h>
#include <memory>
#include <string>
#include <variant>
@@ -28,6 +28,8 @@ target_link_libraries(react_renderer_animated
react_renderer_uimanager
react_renderer_scheduler
react_renderer_animationbackend
react_bridging
react_nativemodule_core
glog
folly_runtime
)
@@ -12,8 +12,7 @@
#include <mutex>
#include <shared_mutex>
#include <react/renderer/core/EventPayload.h>
#include <react/renderer/core/ReactPrimitives.h>
#include <React/RendererCore.h>
namespace facebook::react {
@@ -9,8 +9,8 @@
#include <react/cxxstableapi/FrameworksGuard.h>
#include <React/RendererCore.h>
#include <folly/dynamic.h>
#include <react/renderer/core/ReactPrimitives.h>
#include <functional>
#include <mutex>
@@ -14,15 +14,14 @@
#else
#include <FBReactNativeSpec/FBReactNativeSpecJSI.h>
#endif
#include <React/Bridging.h>
#include <React/Debug.h>
#include <React/RendererCore.h>
#include <folly/dynamic.h>
#include <react/bridging/Function.h>
#include <react/debug/flags.h>
#include <react/renderer/animated/EventEmitterListener.h>
#include <react/renderer/animated/event_drivers/EventAnimationDriver.h>
#include <react/renderer/animationbackend/AnimatedPropsBuilder.h>
#include <react/renderer/animationbackend/AnimationBackend.h>
#include <react/renderer/core/ReactPrimitives.h>
#include <react/renderer/core/ShadowNode.h>
#include <react/renderer/uimanager/UIManagerAnimationBackend.h>
#include <chrono>
#include <memory>
@@ -13,7 +13,7 @@
#pragma once
#include <react/debug/flags.h>
#include <React/Debug.h>
#include <react/renderer/animated/NativeAnimatedNodesManager.h>
namespace facebook::react {
@@ -13,8 +13,7 @@
#pragma once
#include <react/renderer/core/EventPayload.h>
#include <react/renderer/core/ReactPrimitives.h>
#include <React/RendererCore.h>
#include <optional>
#include <string>
#include <vector>
@@ -9,7 +9,7 @@
#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/renderer/core/ReactPrimitives.h>
#include <React/RendererCore.h>
namespace facebook::react::animated {
// Indicates that the animated node identifier is not defined.
@@ -13,9 +13,9 @@
#pragma once
#include <React/Debug.h>
#include <React/RendererCore.h>
#include <folly/dynamic.h>
#include <react/debug/flags.h>
#include <react/renderer/core/ReactPrimitives.h>
namespace facebook::react {
@@ -15,7 +15,7 @@
#include "AnimatedNode.h"
#include <react/renderer/graphics/Color.h>
#include <React/Graphics.h>
namespace facebook::react {
class ColorAnimatedNode final : public AnimatedNode {
@@ -15,8 +15,8 @@
#include "ValueAnimatedNode.h"
#include <React/Graphics.h>
#include <react/renderer/animated/internal/primitives.h>
#include <react/renderer/graphics/Color.h>
namespace facebook::react {
@@ -15,8 +15,8 @@
#include "AnimatedNode.h"
#include <React/RendererCore.h>
#include <react/renderer/animated/internal/primitives.h>
#include <react/renderer/core/ShadowNode.h>
#include <mutex>
namespace facebook::react {