mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
chore(LinkingExample): Update external URLs description (#33023)
Summary: Update LinkingExample "Open external URLs" description to mitigate confusion about opening custom schemes in the simulator when testing, as suggested by Luna here https://github.com/facebook/react-native/issues/32962#issuecomment-1026018822 ## Changelog [Internal] [Changed] - Update LinkingExample "Open external URLs" description Pull Request resolved: https://github.com/facebook/react-native/pull/33023 Test Plan: 1. Build RNTester iOS app 2. Head to the APIs example, Linking -> "Open external URLs" https://user-images.githubusercontent.com/11707729/152087644-7e95692c-5180-465b-9fc8-2a637a091deb.mov Reviewed By: cortinico Differential Revision: D33941963 Pulled By: dmitryrykun fbshipit-source-id: 5f58d7f71aee61518b0b8fd92d7b78ac8bff4d4b
This commit is contained in:
committed by
Facebook GitHub Bot
parent
eb08af57a9
commit
f185d42619
@@ -33,7 +33,13 @@ class OpenURLButton extends React.Component<Props> {
|
||||
if (supported) {
|
||||
Linking.openURL(this.props.url);
|
||||
} else {
|
||||
console.log("Don't know how to open URI: " + this.props.url);
|
||||
console.log(
|
||||
`Don't know how to open URI: ${
|
||||
this.props.url
|
||||
}, ensure you have an app installed that handles the "${
|
||||
this.props.url.split(':')?.[0]
|
||||
}" scheme`,
|
||||
);
|
||||
}
|
||||
});
|
||||
};
|
||||
@@ -134,6 +140,8 @@ exports.description = 'Shows how to use Linking to open URLs.';
|
||||
exports.examples = [
|
||||
{
|
||||
title: 'Open external URLs',
|
||||
description:
|
||||
'Custom schemes may require specific apps to be installed on the device. Note: Phone app is not supported in the simulator.',
|
||||
render: function (): React.Element<typeof IntentAndroidExample> {
|
||||
return <IntentAndroidExample />;
|
||||
},
|
||||
|
||||
Reference in New Issue
Block a user