mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Compile hermes-engine with -DHERMES_ENABLE_DEBUGGER=False on Release (#38212)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/38212 This mirrors the same logic that the Hermes team has on facebook/hermes. Practically, we want to pass the CMake config flag `HERMES_ENABLE_DEBUGGER=False` only for Release so that their CMake build is configured correctly. Their build always enables the Debugger and allows us to selectively turn it off only for release builds. More context: https://github.com/facebook/hermes/commit/eabf5fcd25 Changelog: [Internal] [Changed] - Compile hermes-engine with -DHERMES_ENABLE_DEBUGGER=False on Release Reviewed By: cipolleschi Differential Revision: D47252735 fbshipit-source-id: 9b5cd801dea3b540a3f80b0d0975e05984f1d9b9
This commit is contained in:
committed by
Lorenzo Sciandra
parent
fe2964a84c
commit
ee8d5e0259
@@ -190,6 +190,8 @@ android {
|
||||
externalNativeBuild {
|
||||
cmake {
|
||||
arguments "-DCMAKE_BUILD_TYPE=MinSizeRel"
|
||||
// For release builds, we don't want to enable the Hermes Debugger.
|
||||
arguments "-DHERMES_ENABLE_DEBUGGER=False"
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user