Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix cmake build for devtoolsruntimesettings (#52156)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/52156

Changelog: [Internal]

Fix devtoolsruntimesettings lib as it needs to be OBJECT library as it has source code included.

Reviewed By: christophpurrer

Differential Revision: D77035122

fbshipit-source-id: 27ad7fe637512afc79f3dcc6b0846dcfd4f22504
This commit is contained in:
Andrew Datsenko
2025-06-22 23:48:38 -07:00
committed by Facebook GitHub Bot
parent 04da4800da
commit ed9969b3d0
4 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactCommon/devtoolsruntimesettings/CMakeLists.txt
+5 -5
View File
@@ -8,10 +8,10 @@ set(CMAKE_VERBOSE_MAKEFILE on)
include(${REACT_COMMON_DIR}/cmake-utils/react-native-flags.cmake)
add_library(react_devtoolsruntimesettingscxx INTERFACE)
file(GLOB devtoolsruntimesettings_SRCS *.cpp)
add_library(devtoolsruntimesettings OBJECT ${devtoolsruntimesettings_SRCS})
target_include_directories(react_devtoolsruntimesettingscxx INTERFACE .)
target_include_directories(devtoolsruntimesettings PUBLIC .)
target_link_libraries(react_devtoolsruntimesettingscxx jsi)
target_compile_reactnative_options(react_devtoolsruntimesettingscxx PRIVATE)
target_compile_options(react_devtoolsruntimesettingscxx PRIVATE -Wpedantic)
target_link_libraries(devtoolsruntimesettings jsi react_codegen_rncore)
target_compile_reactnative_options(devtoolsruntimesettings PRIVATE)
packages/react-native/ReactCommon/react/nativemodule/devtoolsruntimesettings/CMakeLists.txt
+1 -1
View File
@@ -14,7 +14,7 @@ add_library(react_nativemodule_devtoolsruntimesettings OBJECT ${react_nativemodu
target_include_directories(react_nativemodule_devtoolsruntimesettings PUBLIC ${REACT_COMMON_DIR})
target_link_libraries(react_nativemodule_devtoolsruntimesettings
react_devtoolsruntimesettingscxx
devtoolsruntimesettings
)
target_compile_reactnative_options(react_nativemodule_devtoolsruntimesettings PRIVATE)
target_compile_options(react_nativemodule_devtoolsruntimesettings PRIVATE -Wpedantic)
packages/react-native/ReactCommon/react/nativemodule/devtoolsruntimesettings/DevToolsRuntimeSettingsModule.cpp
+2
View File
@@ -6,7 +6,9 @@
*/
#include "DevToolsRuntimeSettingsModule.h"
#if RN_DISABLE_OSS_PLUGIN_HEADER
#include "Plugins.h"
#endif
std::shared_ptr<facebook::react::TurboModule>
ReactDevToolsRuntimeSettingsModuleProvider(
packages/react-native/ReactCommon/react/nativemodule/devtoolsruntimesettings/DevToolsRuntimeSettingsModule.h
+1 -1
View File
@@ -7,7 +7,7 @@
#pragma once
#include "devtoolsruntimesettingscxx/DevToolsRuntimeSettings.h"
#include <devtoolsruntimesettings/DevToolsRuntimeSettings.h>
namespace facebook::react {