Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Mark string props as nullable in scrollview managers (#48520)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/48520

Both `ReactScrollViewHelper.parseSnapToAlignment` and `ReactScrollViewHelper.parseOverScrollMode` accept a nullable string. This is a precursor to migrating these files to Kotlin (since they're already marked as nullsafe). The prop itself is a nullable string so this should be reflected in the native types as well

Changelog: [Internal]

Reviewed By: tdn120

Differential Revision: D67911553

fbshipit-source-id: aabe55c2dc65a933b170d76b89f62f25493ab0ee
This commit is contained in:
Peter Abbondanzo
2025-01-07 15:13:34 -08:00
committed by Facebook GitHub Bot
parent 8b0af4542e
commit ec72af403c
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactHorizontalScrollViewManager.java
+3 -3
View File
@@ -109,7 +109,7 @@ public class ReactHorizontalScrollViewManager extends ViewGroupManager<ReactHori
}
@ReactProp(name = "snapToAlignment")
public void setSnapToAlignment(ReactHorizontalScrollView view, String alignment) {
public void setSnapToAlignment(ReactHorizontalScrollView view, @Nullable String alignment) {
view.setSnapToAlignment(ReactScrollViewHelper.parseSnapToAlignment(alignment));
}
@@ -166,7 +166,7 @@ public class ReactHorizontalScrollViewManager extends ViewGroupManager<ReactHori
* @param scrollPerfTag
*/
@ReactProp(name = "scrollPerfTag")
public void setScrollPerfTag(ReactHorizontalScrollView view, String scrollPerfTag) {
public void setScrollPerfTag(ReactHorizontalScrollView view, @Nullable String scrollPerfTag) {
view.setScrollPerfTag(scrollPerfTag);
}
@@ -177,7 +177,7 @@ public class ReactHorizontalScrollViewManager extends ViewGroupManager<ReactHori
/** Controls overScroll behaviour */
@ReactProp(name = "overScrollMode")
public void setOverScrollMode(ReactHorizontalScrollView view, String value) {
public void setOverScrollMode(ReactHorizontalScrollView view, @Nullable String value) {
view.setOverScrollMode(ReactScrollViewHelper.parseOverScrollMode(value));
}
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewManager.java
+2 -2
View File
@@ -123,7 +123,7 @@ public class ReactScrollViewManager extends ViewGroupManager<ReactScrollView>
}
@ReactProp(name = "snapToAlignment")
public void setSnapToAlignment(ReactScrollView view, String alignment) {
public void setSnapToAlignment(ReactScrollView view, @Nullable String alignment) {
view.setSnapToAlignment(ReactScrollViewHelper.parseSnapToAlignment(alignment));
}
@@ -186,7 +186,7 @@ public class ReactScrollViewManager extends ViewGroupManager<ReactScrollView>
/** Controls overScroll behaviour */
@ReactProp(name = "overScrollMode")
public void setOverScrollMode(ReactScrollView view, String value) {
public void setOverScrollMode(ReactScrollView view, @Nullable String value) {
view.setOverScrollMode(ReactScrollViewHelper.parseOverScrollMode(value));
}