Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(iOS): small test fix for RCTViewTests (#47314)

Browse Source 
Summary:
Depracated usage of scrollInsets + an unused param.

## Changelog:

[INTERNAL] [FIXED] - Switch to verticalScrollIndicatorInsets and mark unused value as __unused in test file

Pull Request resolved: https://github.com/facebook/react-native/pull/47314

Test Plan:
Running the specific test itself, it passes:
<img width="1092" alt="Screenshot 2024-10-30 at 18 02 08" src="https://github.com/user-attachments/assets/e3ed27c6-9f00-4777-a72c-92f0da93a79f">

Reviewed By: NickGerleman

Differential Revision: D65231365

Pulled By: philIip

fbshipit-source-id: eed795ad65bd837fb9f38175081d961245ff3932
This commit is contained in:
Parsa Nasirimehr
2024-10-31 16:24:41 -07:00
committed by Facebook GitHub Bot
parent fd273f83e0
commit ec4ead59e1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/rn-tester/RNTesterUnitTests/RCTViewTests.m
+2 -2
View File
@@ -17,7 +17,7 @@
RCT_MOCK_REF(RCTView, RCTContentInsets);
UIEdgeInsets gContentInsets;
static UIEdgeInsets RCTContentInsetsMock(UIView *view)
static UIEdgeInsets RCTContentInsetsMock(__unused UIView *view)
{
return gContentInsets;
}
@@ -40,7 +40,7 @@ static UIEdgeInsets RCTContentInsetsMock(UIView *view)
[RCTView autoAdjustInsetsForView:parentView withScrollView:scrollView updateOffset:NO];
XCTAssertTrue(UIEdgeInsetsEqualToEdgeInsets(scrollView.contentInset, UIEdgeInsetsMake(2, 3, 4, 5)));
XCTAssertTrue(UIEdgeInsetsEqualToEdgeInsets(scrollView.scrollIndicatorInsets, UIEdgeInsetsMake(2, 3, 4, 5)));
XCTAssertTrue(UIEdgeInsetsEqualToEdgeInsets(scrollView.verticalScrollIndicatorInsets, UIEdgeInsetsMake(2, 3, 4, 5)));
RCT_MOCK_RESET(RCTView, RCTContentInsets);
}