mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Fix create-draft-release syntax error (#54567)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/54567 This change fix a syntax error in the create-draft-release workflow. We were basically passing the Hermes and HermesV1 versions without wrapping them in `'`. JS was interpreting them as numbers and making a mess of the syntax. Wrapping them in `'` should fix the job. The commit was already picked in the release branch. ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D87244325 fbshipit-source-id: b115c233779b36a1b6b0462eb0a8ef60ceafce7c
This commit is contained in:
1 parent
936141f399
commit
eb062d4d73
1 file changed
+1
-1
@@ -37,7 +37,7 @@ jobs:
|
||||
const {createDraftRelease} = require('./.github/workflow-scripts/createDraftRelease.js');
|
||||
const version = '${{ github.ref_name }}';
|
||||
const {isLatest} = require('./.github/workflow-scripts/publishTemplate.js');
|
||||
return (await createDraftRelease(version, isLatest(), '${{secrets.REACT_NATIVE_BOT_GITHUB_TOKEN}}', ${{ inputs.hermesVersion }}, ${{ inputs.hermesV1Version }})).id;
|
||||
return (await createDraftRelease(version, isLatest(), '${{secrets.REACT_NATIVE_BOT_GITHUB_TOKEN}}', '${{ inputs.hermesVersion }}', '${{ inputs.hermesV1Version }}')).id;
|
||||
result-encoding: string
|
||||
- name: Upload release assets for DotSlash
|
||||
uses: actions/github-script@v6
|
||||
|
||||
Reference in new issue
Block a user