From eb062d4d73632679b76c3770824405f1833edb09 Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Tue, 18 Nov 2025 02:51:54 -0800 Subject: [PATCH] Fix create-draft-release syntax error (#54567) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/54567 This change fix a syntax error in the create-draft-release workflow. We were basically passing the Hermes and HermesV1 versions without wrapping them in `'`. JS was interpreting them as numbers and making a mess of the syntax. Wrapping them in `'` should fix the job. The commit was already picked in the release branch. ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D87244325 fbshipit-source-id: b115c233779b36a1b6b0462eb0a8ef60ceafce7c --- .github/workflows/create-draft-release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/create-draft-release.yml b/.github/workflows/create-draft-release.yml index f8ba43e76a9..942ac662bdc 100644 --- a/.github/workflows/create-draft-release.yml +++ b/.github/workflows/create-draft-release.yml @@ -37,7 +37,7 @@ jobs: const {createDraftRelease} = require('./.github/workflow-scripts/createDraftRelease.js'); const version = '${{ github.ref_name }}'; const {isLatest} = require('./.github/workflow-scripts/publishTemplate.js'); - return (await createDraftRelease(version, isLatest(), '${{secrets.REACT_NATIVE_BOT_GITHUB_TOKEN}}', ${{ inputs.hermesVersion }}, ${{ inputs.hermesV1Version }})).id; + return (await createDraftRelease(version, isLatest(), '${{secrets.REACT_NATIVE_BOT_GITHUB_TOKEN}}', '${{ inputs.hermesVersion }}', '${{ inputs.hermesV1Version }}')).id; result-encoding: string - name: Upload release assets for DotSlash uses: actions/github-script@v6