Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

DevMenu: Change "Toggle Inspector" to Show/Hide Element Inspector

Browse Source 
Summary:
Rationale:
- This makes the element inspector button consistent with the Fast Refresh, Perf Monitor and other buttons in the DevMenu
- This makes the button more informative

Changelog: [Android][Changed] Rename the "Toggle Inspector" DevMenu item to "Hide/Show Element Inspector"

Reviewed By: JoshuaGross

Differential Revision: D29146871

fbshipit-source-id: 8e8c19217ea2ff2f1d176521aa22200058e7e643
This commit is contained in:
Ramanpreet Nara
2021-06-15 18:21:13 -07:00
committed by Facebook GitHub Bot
parent 18165367b0
commit e91fb05db7
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java
+3 -2
View File
@@ -474,8 +474,9 @@ public abstract class DevSupportManagerBase implements DevSupportManager {
});
options.put(
// NOTE: `isElementInspectorEnabled` is not guaranteed to be accurate.
mApplicationContext.getString(R.string.catalyst_inspector),
mDevSettings.isElementInspectorEnabled()
? mApplicationContext.getString(R.string.catalyst_inspector_stop)
: mApplicationContext.getString(R.string.catalyst_inspector),
new DevOptionHandler() {
@Override
public void onOptionSelected() {
ReactAndroid/src/main/res/devsupport/values/strings.xml
+2 -1
View File
@@ -16,7 +16,8 @@
<string name="catalyst_hot_reloading_stop" project="catalyst" translatable="false">Disable Fast Refresh</string>
<string name="catalyst_hot_reloading_auto_disable" project="catalyst" translatable="false">Disabling Fast Refresh because it requires a development bundle.</string>
<string name="catalyst_hot_reloading_auto_enable" project="catalyst" translatable="false">Switching to development bundle in order to enable Fast Refresh.</string>
<string name="catalyst_inspector" project="catalyst" translatable="false">Toggle Inspector</string>
<string name="catalyst_inspector" project="catalyst" translatable="false">Show Element Inspector</string>
<string name="catalyst_inspector_stop" project="catalyst" translatable="false">Hide Element Inspector</string>
<string name="catalyst_perf_monitor" project="catalyst" translatable="false">Show Perf Monitor</string>
<string name="catalyst_perf_monitor_stop" project="catalyst" translatable="false">Hide Perf Monitor</string>
<string name="catalyst_settings" project="catalyst" translatable="false">Settings</string>