Review feedback. Restore View on GitHub headers for each example in the Components autodocs.

This commit is contained in:
Héctor Ramos
2016-08-04 14:09:37 -07:00
parent 30b75e2ca4
commit e8f67e67f4
5 changed files with 16 additions and 33 deletions
+2 -5
View File
@@ -12,17 +12,14 @@
var React = require('React');
function getGitHubPath(path) {
return [
'https://github.com/facebook/react-native/blob/master',
path
].join('/');
return 'https://github.com/facebook/react-native/blob/master/' + path;
}
var Footer = React.createClass({
render: function() {
return (
<p className="edit-page-block">
You can <a target="_blank" href={getGitHubPath(this.props.path)} >edit this page on GitHub</a> and send us a pull request!
You can <a target="_blank" href={getGitHubPath(this.props.path)}>edit the content above on GitHub</a> and send us a pull request!
</p>
);
}
+4 -9
View File
@@ -12,13 +12,8 @@
var H = require('Header');
var React = require('React');
function getVersionedGithubPath(path, version) {
version = version || 'next';
return [
'https://github.com/facebook/react-native/blob',
version === 'next' ? 'master' : version + '-stable',
path
].join('/');
function getGitHubPath(path) {
return 'https://github.com/facebook/react-native/blob/' + path;
}
var HeaderWithGithub = React.createClass({
@@ -40,8 +35,8 @@ var HeaderWithGithub = React.createClass({
<td style={{textAlign: 'right'}}>
<a
target="_blank"
href={getVersionedGithubPath(this.props.path, this.context.version)}>
View on GitHub
href={getGitHubPath(this.props.path)}>
Edit on GitHub
</a>
</td>
</tr>
+8 -16
View File
@@ -13,6 +13,7 @@
var DocsSidebar = require('DocsSidebar');
var Header = require('Header');
var HeaderWithGithub = require('HeaderWithGithub');
var Footer = require('Footer');
var Marked = require('Marked');
var Prism = require('Prism');
@@ -830,14 +831,11 @@ var Autodocs = React.createClass({
}
return (
<div>
<Header
toSlug='Description'
>
Description
</Header>
<Header level={1}>Description</Header>
<Marked>
{docs.fullDescription}
</Marked>
<Footer path={'docs/' + docs.componentName + '.md'} />
</div>
);
},
@@ -849,13 +847,12 @@ var Autodocs = React.createClass({
return (
<div>
<Header
<HeaderWithGithub
title={example.title || 'Examples'}
level={example.title ? 4 : 3}
path={example.path}
metadata={metadata}
>
{example.title || 'Examples'}
</Header>
/>
<div className="example-container">
<Prism>
{example.content.replace(/^[\s\S]*?\*\//, '').trim()}
@@ -892,19 +889,14 @@ var Autodocs = React.createClass({
<DocsSidebar metadata={metadata} />
<div className="inner-content">
<a id="content" />
<Header
level={1}
>
{metadata.title}
</Header>
{content}
<Header level={1}>{metadata.title}</Header> {content}
<Footer path={metadata.path} />
{this.renderFullDescription(docs)}
{this.renderExamples(docs, metadata)}
<div className="docs-prevnext">
{metadata.previous && <a className="docs-prev" href={'docs/' + metadata.previous + '.html#content'}>&larr; Prev</a>}
{metadata.next && <a className="docs-next" href={'docs/' + metadata.next + '.html#content'}>Next &rarr;</a>}
</div>
<Footer path={metadata.path} />
</div>
</section>
</Site>
+1 -3
View File
@@ -39,9 +39,7 @@ var DocsLayout = React.createClass({
<DocsSidebar metadata={metadata} />
<div className="inner-content">
<a id="content" />
<Header level={1} >
{metadata.title}
</Header>
<Header level={1}>{metadata.title}</Header>
<Marked>{content}</Marked>
<div className="docs-prevnext">
{metadata.previous && <a className="docs-prev" href={'docs/' + metadata.previous + '.html#content'}>&larr; Prev</a>}
@@ -1632,6 +1632,7 @@ input#algolia-doc-search:focus {
.edit-page-block {
padding: 5px;
margin-bottom: 40px;
font-size: 12px;
color: #887766;
text-align: center;