Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow native module loads during react instance init

Browse Source 
Summary:
## Context
Right now, the ReactInstance construtor eagerly initializes native modules.

## Problem
When these modules initialize, they may load other modules. But, all those loads will fail, because the react instance is in the process of being constructed.

## Changes
Eagerly initialize modules after the react instance is created. That way, these native module requires work.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D58537536

fbshipit-source-id: d0e424df708ec35b014f5cecda11e8756e8f4346
This commit is contained in:
Ramanpreet Nara
2024-06-14 09:17:32 -07:00
committed by Facebook GitHub Bot
parent 74d030de70
commit e78742a9d8
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.java
+3
View File
@@ -1073,6 +1073,9 @@ public class ReactHostImpl implements ReactHost {
getOrCreateReactHostInspectorTarget());
mReactInstance = instance;
// eagerly initailize turbo modules
instance.initializeEagerTurboModules();
MemoryPressureListener memoryPressureListener =
createMemoryPressureListener(instance);
mMemoryPressureListener = memoryPressureListener;
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactInstance.java
+7 -5
View File
@@ -198,11 +198,6 @@ final class ReactInstance {
getJSCallInvokerHolder(),
getNativeMethodCallInvokerHolder());
// Eagerly initialize TurboModules
for (String moduleName : mTurboModuleManager.getEagerInitModuleNames()) {
mTurboModuleManager.getModule(moduleName);
}
Systrace.endSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE);
// Set up Fabric
@@ -300,6 +295,13 @@ final class ReactInstance {
Systrace.endSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE);
}
void initializeEagerTurboModules() {
// Eagerly initialize TurboModules
for (String moduleName : mTurboModuleManager.getEagerInitModuleNames()) {
mTurboModuleManager.getModule(moduleName);
}
}
private static synchronized void loadLibraryIfNeeded() {
if (!sIsLibraryLoaded) {
SoLoader.loadLibrary("rninstance");