mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Fix null pointer crash in Scheduler::animationTick by adding null check for uiManager_ (#56128) (#57327)
Summary: Pull Request resolved: https://github.com/react/react-native/pull/57327 Pull Request resolved: https://github.com/react/react-native/pull/56128 Changelog: [Android] [Fixed] - Fix crash in Scheduler::animationTick when uiManager_ is null. Test Plan: CI Fixes a null pointer dereference crash in `Scheduler::animationTick()` that occurs during shutdown race conditions. ### Root Cause Analysis **The Symptom**: `uiManager_` is null when `Scheduler::animationTick()` is called, causing a crash at offset 0x50 from null when accessing members of `UIManager`. **The Root Cause**: During shutdown, when `uninstallFabricUIManager()` is called, the Choreographer's animation frame callback (`doFrame`) can still arrive. While `FabricUIManagerBinding::driveCxxAnimations()` checks for null scheduler (added in D92986523), the internal `Scheduler::animationTick()` method didn't check if `uiManager_` is valid before dereferencing it: ```cpp void Scheduler::animationTick() const { uiManager_->animationTick(); // No null check - crashes if uiManager_ is null } ``` **The Fix**: Added a null check for `uiManager_` before accessing it, following the same defensive pattern used in `driveCxxAnimations()` and other methods in the codebase: ```cpp void Scheduler::animationTick() const { if (!uiManager_) { return; } uiManager_->animationTick(); } ``` **Why This Fix Works**: It prevents the null pointer dereference by checking `uiManager_` validity before use. During shutdown, if the scheduler is accessed after `uiManager_` becomes invalid, the method will safely return instead of crashing. ### Related Diffs - D92986523: Similar fix for null scheduler check in `driveCxxAnimations()` Logview link: [b3d4c4d8f7e6dd50b09fb7df9a1ad66a](https://www.internalfb.com/logview/system_vros_crashes/b3d4c4d8f7e6dd50b09fb7df9a1ad66a) X-link: https://github.com/facebook/react-native/pull/56128 CI Reviewed By: cortinico Differential Revision: D93363797 Pulled By: shubhamksavita fbshipit-source-id: 8c1deaab113c9d907eb28e5bd9e44d61b4280db8
This commit is contained in:
1 parent
59f26aa8fb
commit
e73592ba51
1 file changed
+3
@@ -295,6 +295,9 @@ SchedulerDelegate* Scheduler::getDelegate() const {
|
||||
#pragma mark - UIManagerAnimationDelegate
|
||||
|
||||
void Scheduler::animationTick() const {
|
||||
if (!uiManager_) {
|
||||
return;
|
||||
}
|
||||
uiManager_->animationTick();
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user