Do not throw error in PropsAnimatedNode (#51563)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/51563

changelog: [internal]

Throwing errors in C++ is expensive and slow. Let's replace it with logging.

This is to reduce binary size of C++ Animated.

Reviewed By: mdvacca

Differential Revision: D75140875

fbshipit-source-id: 32909572141d8e1b51b60f317716f783aa760265

packages/react-native/ReactCxxPlatform/react/renderer/animated/nodes/PropsAnimatedNode.cpp

@@ -11,6 +11,7 @@
 
 #include "PropsAnimatedNode.h"
 
+#include <react/debug/react_native_assert.h>
 #include <react/renderer/animated/NativeAnimatedAllowlist.h>
 #include <react/renderer/animated/NativeAnimatedNodesManager.h>
 #include <react/renderer/animated/nodes/ColorAnimatedNode.h>
@@ -57,23 +58,16 @@ PropsAnimatedNode::PropsAnimatedNode(
 }
 
 void PropsAnimatedNode::connectToView(Tag viewTag) {
-  if (connectedViewTag_) {
-    throw std::invalid_argument(
-        "Animated node " + std::to_string(tag_) +
-        " has already been attached to a view already exists.");
-    return;
-  }
+  react_native_assert(
+      connectedViewTag_ == animated::undefinedAnimatedNodeIdentifier &&
+      "Animated node has already been attached to a view already exists.");
   connectedViewTag_ = viewTag;
 }
 
 void PropsAnimatedNode::disconnectFromView(Tag viewTag) {
-  if (connectedViewTag_ == animated::undefinedAnimatedNodeIdentifier) {
-    return;
-  } else if (connectedViewTag_ != viewTag) {
-    throw std::invalid_argument(
-        "Attempting to disconnect view that has not been connected with the given animated node.");
-    return;
-  }
+  react_native_assert(
+      connectedViewTag_ == viewTag &&
+      "Attempting to disconnect view that has not been connected with the given animated node.");
   connectedViewTag_ = animated::undefinedAnimatedNodeIdentifier;
 }