mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Cleanup useRawPropsJsiValue flag (#55032)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/55032 This has been fully rolled out now, the feature flag can be removed. Changelog: [Internal] Reviewed By: zeyap Differential Revision: D90106434 fbshipit-source-id: 9bdc53f7d34828c662d7304397bfc8f1c7bb1f81
This commit is contained in:
1 parent
26da0fa509
commit
e1d2de82a8
25 files changed
+35
-159
No files matched your search
@@ -15,6 +15,7 @@
|
||||
#import <React/RCTUtils.h>
|
||||
#import <ReactCommon/RCTHost.h>
|
||||
#import <objc/runtime.h>
|
||||
#import <react/featureflags/ReactNativeFeatureFlags.h>
|
||||
#import <react/featureflags/ReactNativeFeatureFlagsOverridesOSSCanary.h>
|
||||
#import <react/featureflags/ReactNativeFeatureFlagsOverridesOSSExperimental.h>
|
||||
#import <react/featureflags/ReactNativeFeatureFlagsOverridesOSSStable.h>
|
||||
|
||||
+1
-7
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<9406085adbc0685b473c868a27085cf8>>
|
||||
* @generated SignedSource<<6f0aac1f6451f4dcd6290116c925f7c4>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -504,12 +504,6 @@ public object ReactNativeFeatureFlags {
|
||||
@JvmStatic
|
||||
public fun useNativeViewConfigsInBridgelessMode(): Boolean = accessor.useNativeViewConfigsInBridgelessMode()
|
||||
|
||||
/**
|
||||
* Instead of using folly::dynamic as internal representation in RawProps and RawValue, use jsi::Value
|
||||
*/
|
||||
@JvmStatic
|
||||
public fun useRawPropsJsiValue(): Boolean = accessor.useRawPropsJsiValue()
|
||||
|
||||
/**
|
||||
* Use the state stored on the source shadow node when cloning it instead of reading in the most recent state on the shadow node family.
|
||||
*/
|
||||
|
||||
+1
-11
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<accc9aa83d8ea2f5faa1eaae9a696d67>>
|
||||
* @generated SignedSource<<fc92dd1e11c01c57283834219b629898>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -99,7 +99,6 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
|
||||
private var useAlwaysAvailableJSErrorHandlingCache: Boolean? = null
|
||||
private var useFabricInteropCache: Boolean? = null
|
||||
private var useNativeViewConfigsInBridgelessModeCache: Boolean? = null
|
||||
private var useRawPropsJsiValueCache: Boolean? = null
|
||||
private var useShadowNodeStateOnCloneCache: Boolean? = null
|
||||
private var useSharedAnimatedBackendCache: Boolean? = null
|
||||
private var useTraitHiddenOnAndroidCache: Boolean? = null
|
||||
@@ -820,15 +819,6 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun useRawPropsJsiValue(): Boolean {
|
||||
var cached = useRawPropsJsiValueCache
|
||||
if (cached == null) {
|
||||
cached = ReactNativeFeatureFlagsCxxInterop.useRawPropsJsiValue()
|
||||
useRawPropsJsiValueCache = cached
|
||||
}
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun useShadowNodeStateOnClone(): Boolean {
|
||||
var cached = useShadowNodeStateOnCloneCache
|
||||
if (cached == null) {
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<e3e8ad599dfc9c77d6a79d6c094e8a2b>>
|
||||
* @generated SignedSource<<285349293c92ae2588664ae854fa250a>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -186,8 +186,6 @@ public object ReactNativeFeatureFlagsCxxInterop {
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun useNativeViewConfigsInBridgelessMode(): Boolean
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun useRawPropsJsiValue(): Boolean
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun useShadowNodeStateOnClone(): Boolean
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun useSharedAnimatedBackend(): Boolean
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<6bdc23594dd175a0bf4409c0e2f10552>>
|
||||
* @generated SignedSource<<24678f43c0deb08304bc86bbef617eb8>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -181,8 +181,6 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
|
||||
|
||||
override fun useNativeViewConfigsInBridgelessMode(): Boolean = false
|
||||
|
||||
override fun useRawPropsJsiValue(): Boolean = true
|
||||
|
||||
override fun useShadowNodeStateOnClone(): Boolean = true
|
||||
|
||||
override fun useSharedAnimatedBackend(): Boolean = false
|
||||
|
||||
+1
-12
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<3b0c2dec02a603afec82993302ecb6ff>>
|
||||
* @generated SignedSource<<b0bafa4cc3d34fd622da17aac4bad2de>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -103,7 +103,6 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
|
||||
private var useAlwaysAvailableJSErrorHandlingCache: Boolean? = null
|
||||
private var useFabricInteropCache: Boolean? = null
|
||||
private var useNativeViewConfigsInBridgelessModeCache: Boolean? = null
|
||||
private var useRawPropsJsiValueCache: Boolean? = null
|
||||
private var useShadowNodeStateOnCloneCache: Boolean? = null
|
||||
private var useSharedAnimatedBackendCache: Boolean? = null
|
||||
private var useTraitHiddenOnAndroidCache: Boolean? = null
|
||||
@@ -903,16 +902,6 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun useRawPropsJsiValue(): Boolean {
|
||||
var cached = useRawPropsJsiValueCache
|
||||
if (cached == null) {
|
||||
cached = currentProvider.useRawPropsJsiValue()
|
||||
accessedFeatureFlags.add("useRawPropsJsiValue")
|
||||
useRawPropsJsiValueCache = cached
|
||||
}
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun useShadowNodeStateOnClone(): Boolean {
|
||||
var cached = useShadowNodeStateOnCloneCache
|
||||
if (cached == null) {
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<995c1c3035757935dc7a4c4d6778e43e>>
|
||||
* @generated SignedSource<<26c5b5fc23fdce860c39d37c6edfeb4d>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -181,8 +181,6 @@ public interface ReactNativeFeatureFlagsProvider {
|
||||
|
||||
@DoNotStrip public fun useNativeViewConfigsInBridgelessMode(): Boolean
|
||||
|
||||
@DoNotStrip public fun useRawPropsJsiValue(): Boolean
|
||||
|
||||
@DoNotStrip public fun useShadowNodeStateOnClone(): Boolean
|
||||
|
||||
@DoNotStrip public fun useSharedAnimatedBackend(): Boolean
|
||||
|
||||
+1
-15
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<1ea556a16d18a54b7087742b986a93a7>>
|
||||
* @generated SignedSource<<832afeff38c393fde762b0e33fcd802e>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -513,12 +513,6 @@ class ReactNativeFeatureFlagsJavaProvider
|
||||
return method(javaProvider_);
|
||||
}
|
||||
|
||||
bool useRawPropsJsiValue() override {
|
||||
static const auto method =
|
||||
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("useRawPropsJsiValue");
|
||||
return method(javaProvider_);
|
||||
}
|
||||
|
||||
bool useShadowNodeStateOnClone() override {
|
||||
static const auto method =
|
||||
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("useShadowNodeStateOnClone");
|
||||
@@ -966,11 +960,6 @@ bool JReactNativeFeatureFlagsCxxInterop::useNativeViewConfigsInBridgelessMode(
|
||||
return ReactNativeFeatureFlags::useNativeViewConfigsInBridgelessMode();
|
||||
}
|
||||
|
||||
bool JReactNativeFeatureFlagsCxxInterop::useRawPropsJsiValue(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
|
||||
return ReactNativeFeatureFlags::useRawPropsJsiValue();
|
||||
}
|
||||
|
||||
bool JReactNativeFeatureFlagsCxxInterop::useShadowNodeStateOnClone(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
|
||||
return ReactNativeFeatureFlags::useShadowNodeStateOnClone();
|
||||
@@ -1279,9 +1268,6 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
|
||||
makeNativeMethod(
|
||||
"useNativeViewConfigsInBridgelessMode",
|
||||
JReactNativeFeatureFlagsCxxInterop::useNativeViewConfigsInBridgelessMode),
|
||||
makeNativeMethod(
|
||||
"useRawPropsJsiValue",
|
||||
JReactNativeFeatureFlagsCxxInterop::useRawPropsJsiValue),
|
||||
makeNativeMethod(
|
||||
"useShadowNodeStateOnClone",
|
||||
JReactNativeFeatureFlagsCxxInterop::useShadowNodeStateOnClone),
|
||||
|
||||
+1
-4
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<67b23d4209c5fa6b721921953d76a829>>
|
||||
* @generated SignedSource<<78530405942f4d922c6442e0c274e26f>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -267,9 +267,6 @@ class JReactNativeFeatureFlagsCxxInterop
|
||||
static bool useNativeViewConfigsInBridgelessMode(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
|
||||
|
||||
static bool useRawPropsJsiValue(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
|
||||
|
||||
static bool useShadowNodeStateOnClone(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
|
||||
|
||||
|
||||
+2
@@ -14,6 +14,8 @@
|
||||
#else
|
||||
#import <QuartzCore/CADisplayLink.h>
|
||||
#endif
|
||||
|
||||
#import <react/featureflags/ReactNativeFeatureFlags.h>
|
||||
#import <react/renderer/animated/AnimatedModule.h>
|
||||
#import <react/renderer/animated/NativeAnimatedNodesManagerProvider.h>
|
||||
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<3d71ee2b906dcc1313428185cbe853f8>>
|
||||
* @generated SignedSource<<5ad716b4ded11ac4131aa52b378615d9>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -342,10 +342,6 @@ bool ReactNativeFeatureFlags::useNativeViewConfigsInBridgelessMode() {
|
||||
return getAccessor().useNativeViewConfigsInBridgelessMode();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlags::useRawPropsJsiValue() {
|
||||
return getAccessor().useRawPropsJsiValue();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlags::useShadowNodeStateOnClone() {
|
||||
return getAccessor().useShadowNodeStateOnClone();
|
||||
}
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<d7838e490a83e54bee2770b80951877a>>
|
||||
* @generated SignedSource<<6bc7cf8676a7ff3db3e3fc0669875996>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -434,11 +434,6 @@ class ReactNativeFeatureFlags {
|
||||
*/
|
||||
RN_EXPORT static bool useNativeViewConfigsInBridgelessMode();
|
||||
|
||||
/**
|
||||
* Instead of using folly::dynamic as internal representation in RawProps and RawValue, use jsi::Value
|
||||
*/
|
||||
RN_EXPORT static bool useRawPropsJsiValue();
|
||||
|
||||
/**
|
||||
* Use the state stored on the source shadow node when cloning it instead of reading in the most recent state on the shadow node family.
|
||||
*/
|
||||
|
||||
+9
-27
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<8bda4a084596c5512b8ebf5eaa44268e>>
|
||||
* @generated SignedSource<<6b06f174bde31429a04437c34fb38453>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -1451,24 +1451,6 @@ bool ReactNativeFeatureFlagsAccessor::useNativeViewConfigsInBridgelessMode() {
|
||||
return flagValue.value();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlagsAccessor::useRawPropsJsiValue() {
|
||||
auto flagValue = useRawPropsJsiValue_.load();
|
||||
|
||||
if (!flagValue.has_value()) {
|
||||
// This block is not exclusive but it is not necessary.
|
||||
// If multiple threads try to initialize the feature flag, we would only
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(79, "useRawPropsJsiValue");
|
||||
|
||||
flagValue = currentProvider_->useRawPropsJsiValue();
|
||||
useRawPropsJsiValue_ = flagValue;
|
||||
}
|
||||
|
||||
return flagValue.value();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlagsAccessor::useShadowNodeStateOnClone() {
|
||||
auto flagValue = useShadowNodeStateOnClone_.load();
|
||||
|
||||
@@ -1478,7 +1460,7 @@ bool ReactNativeFeatureFlagsAccessor::useShadowNodeStateOnClone() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(80, "useShadowNodeStateOnClone");
|
||||
markFlagAsAccessed(79, "useShadowNodeStateOnClone");
|
||||
|
||||
flagValue = currentProvider_->useShadowNodeStateOnClone();
|
||||
useShadowNodeStateOnClone_ = flagValue;
|
||||
@@ -1496,7 +1478,7 @@ bool ReactNativeFeatureFlagsAccessor::useSharedAnimatedBackend() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(81, "useSharedAnimatedBackend");
|
||||
markFlagAsAccessed(80, "useSharedAnimatedBackend");
|
||||
|
||||
flagValue = currentProvider_->useSharedAnimatedBackend();
|
||||
useSharedAnimatedBackend_ = flagValue;
|
||||
@@ -1514,7 +1496,7 @@ bool ReactNativeFeatureFlagsAccessor::useTraitHiddenOnAndroid() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(82, "useTraitHiddenOnAndroid");
|
||||
markFlagAsAccessed(81, "useTraitHiddenOnAndroid");
|
||||
|
||||
flagValue = currentProvider_->useTraitHiddenOnAndroid();
|
||||
useTraitHiddenOnAndroid_ = flagValue;
|
||||
@@ -1532,7 +1514,7 @@ bool ReactNativeFeatureFlagsAccessor::useTurboModuleInterop() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(83, "useTurboModuleInterop");
|
||||
markFlagAsAccessed(82, "useTurboModuleInterop");
|
||||
|
||||
flagValue = currentProvider_->useTurboModuleInterop();
|
||||
useTurboModuleInterop_ = flagValue;
|
||||
@@ -1550,7 +1532,7 @@ bool ReactNativeFeatureFlagsAccessor::useTurboModules() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(84, "useTurboModules");
|
||||
markFlagAsAccessed(83, "useTurboModules");
|
||||
|
||||
flagValue = currentProvider_->useTurboModules();
|
||||
useTurboModules_ = flagValue;
|
||||
@@ -1568,7 +1550,7 @@ double ReactNativeFeatureFlagsAccessor::viewCullingOutsetRatio() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(85, "viewCullingOutsetRatio");
|
||||
markFlagAsAccessed(84, "viewCullingOutsetRatio");
|
||||
|
||||
flagValue = currentProvider_->viewCullingOutsetRatio();
|
||||
viewCullingOutsetRatio_ = flagValue;
|
||||
@@ -1586,7 +1568,7 @@ double ReactNativeFeatureFlagsAccessor::virtualViewHysteresisRatio() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(86, "virtualViewHysteresisRatio");
|
||||
markFlagAsAccessed(85, "virtualViewHysteresisRatio");
|
||||
|
||||
flagValue = currentProvider_->virtualViewHysteresisRatio();
|
||||
virtualViewHysteresisRatio_ = flagValue;
|
||||
@@ -1604,7 +1586,7 @@ double ReactNativeFeatureFlagsAccessor::virtualViewPrerenderRatio() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(87, "virtualViewPrerenderRatio");
|
||||
markFlagAsAccessed(86, "virtualViewPrerenderRatio");
|
||||
|
||||
flagValue = currentProvider_->virtualViewPrerenderRatio();
|
||||
virtualViewPrerenderRatio_ = flagValue;
|
||||
|
||||
+2
-4
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<fd5d2f3789bc66906ec6b31a1f5c23f6>>
|
||||
* @generated SignedSource<<beb6c31ead63642735b7d7a8fdb74371>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -111,7 +111,6 @@ class ReactNativeFeatureFlagsAccessor {
|
||||
bool useAlwaysAvailableJSErrorHandling();
|
||||
bool useFabricInterop();
|
||||
bool useNativeViewConfigsInBridgelessMode();
|
||||
bool useRawPropsJsiValue();
|
||||
bool useShadowNodeStateOnClone();
|
||||
bool useSharedAnimatedBackend();
|
||||
bool useTraitHiddenOnAndroid();
|
||||
@@ -131,7 +130,7 @@ class ReactNativeFeatureFlagsAccessor {
|
||||
std::unique_ptr<ReactNativeFeatureFlagsProvider> currentProvider_;
|
||||
bool wasOverridden_;
|
||||
|
||||
std::array<std::atomic<const char*>, 88> accessedFeatureFlags_;
|
||||
std::array<std::atomic<const char*>, 87> accessedFeatureFlags_;
|
||||
|
||||
std::atomic<std::optional<bool>> commonTestFlag_;
|
||||
std::atomic<std::optional<bool>> cdpInteractionMetricsEnabled_;
|
||||
@@ -212,7 +211,6 @@ class ReactNativeFeatureFlagsAccessor {
|
||||
std::atomic<std::optional<bool>> useAlwaysAvailableJSErrorHandling_;
|
||||
std::atomic<std::optional<bool>> useFabricInterop_;
|
||||
std::atomic<std::optional<bool>> useNativeViewConfigsInBridgelessMode_;
|
||||
std::atomic<std::optional<bool>> useRawPropsJsiValue_;
|
||||
std::atomic<std::optional<bool>> useShadowNodeStateOnClone_;
|
||||
std::atomic<std::optional<bool>> useSharedAnimatedBackend_;
|
||||
std::atomic<std::optional<bool>> useTraitHiddenOnAndroid_;
|
||||
|
||||
+1
-5
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<b8b6163068152d88615813c0d80ed28b>>
|
||||
* @generated SignedSource<<5fb5b0f15594c9f65de484c77c7e4215>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -343,10 +343,6 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
|
||||
return false;
|
||||
}
|
||||
|
||||
bool useRawPropsJsiValue() override {
|
||||
return true;
|
||||
}
|
||||
|
||||
bool useShadowNodeStateOnClone() override {
|
||||
return true;
|
||||
}
|
||||
|
||||
+1
-10
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<a4f191da59898458d1f02248cfa509d6>>
|
||||
* @generated SignedSource<<2f22164639286343590c3ec3ec5ab176>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -756,15 +756,6 @@ class ReactNativeFeatureFlagsDynamicProvider : public ReactNativeFeatureFlagsDef
|
||||
return ReactNativeFeatureFlagsDefaults::useNativeViewConfigsInBridgelessMode();
|
||||
}
|
||||
|
||||
bool useRawPropsJsiValue() override {
|
||||
auto value = values_["useRawPropsJsiValue"];
|
||||
if (!value.isNull()) {
|
||||
return value.getBool();
|
||||
}
|
||||
|
||||
return ReactNativeFeatureFlagsDefaults::useRawPropsJsiValue();
|
||||
}
|
||||
|
||||
bool useShadowNodeStateOnClone() override {
|
||||
auto value = values_["useShadowNodeStateOnClone"];
|
||||
if (!value.isNull()) {
|
||||
|
||||
+1
-2
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<8e68f8be2e5f35422ae866390c76f670>>
|
||||
* @generated SignedSource<<a5ec3f85c247a79317dc7d4dadf792c6>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -104,7 +104,6 @@ class ReactNativeFeatureFlagsProvider {
|
||||
virtual bool useAlwaysAvailableJSErrorHandling() = 0;
|
||||
virtual bool useFabricInterop() = 0;
|
||||
virtual bool useNativeViewConfigsInBridgelessMode() = 0;
|
||||
virtual bool useRawPropsJsiValue() = 0;
|
||||
virtual bool useShadowNodeStateOnClone() = 0;
|
||||
virtual bool useSharedAnimatedBackend() = 0;
|
||||
virtual bool useTraitHiddenOnAndroid() = 0;
|
||||
|
||||
+1
-6
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<3923fa1256c4cc2656201f9d83338606>>
|
||||
* @generated SignedSource<<e0c78a566d4bd62ffae2c0c249e4f062>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -439,11 +439,6 @@ bool NativeReactNativeFeatureFlags::useNativeViewConfigsInBridgelessMode(
|
||||
return ReactNativeFeatureFlags::useNativeViewConfigsInBridgelessMode();
|
||||
}
|
||||
|
||||
bool NativeReactNativeFeatureFlags::useRawPropsJsiValue(
|
||||
jsi::Runtime& /*runtime*/) {
|
||||
return ReactNativeFeatureFlags::useRawPropsJsiValue();
|
||||
}
|
||||
|
||||
bool NativeReactNativeFeatureFlags::useShadowNodeStateOnClone(
|
||||
jsi::Runtime& /*runtime*/) {
|
||||
return ReactNativeFeatureFlags::useShadowNodeStateOnClone();
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<560b5619790e0d17e76bc3d600ca10d1>>
|
||||
* @generated SignedSource<<b6de6e36e3387fcc8538936cbd546c16>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -194,8 +194,6 @@ class NativeReactNativeFeatureFlags
|
||||
|
||||
bool useNativeViewConfigsInBridgelessMode(jsi::Runtime& runtime);
|
||||
|
||||
bool useRawPropsJsiValue(jsi::Runtime& runtime);
|
||||
|
||||
bool useShadowNodeStateOnClone(jsi::Runtime& runtime);
|
||||
|
||||
bool useSharedAnimatedBackend(jsi::Runtime& runtime);
|
||||
|
||||
@@ -136,13 +136,7 @@ void RawPropsParser::preparse(const RawProps& rawProps) const noexcept {
|
||||
rawProps.keyIndexToValueIndex_[keyIndex] = valueIndex;
|
||||
|
||||
auto value = object.getProperty(runtime, nameValue);
|
||||
RawValue rawValue;
|
||||
if (useRawPropsJsiValue_) {
|
||||
rawValue = RawValue(runtime, std::move(value));
|
||||
} else {
|
||||
rawValue = RawValue(jsi::dynamicFromValue(runtime, value));
|
||||
}
|
||||
rawProps.values_.push_back(std::move(rawValue));
|
||||
rawProps.values_.emplace_back(runtime, std::move(value));
|
||||
valueIndex++;
|
||||
}
|
||||
|
||||
|
||||
@@ -7,7 +7,6 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/featureflags/ReactNativeFeatureFlags.h>
|
||||
#include <react/renderer/core/Props.h>
|
||||
#include <react/renderer/core/PropsParserContext.h>
|
||||
#include <react/renderer/core/RawProps.h>
|
||||
@@ -27,11 +26,9 @@ class RawPropsParser final {
|
||||
/*
|
||||
* Default constructor.
|
||||
* To be used by `ConcreteComponentDescriptor` only.
|
||||
* If `useRawPropsJsiValue` is `true`, the parser will use `jsi::Value`
|
||||
* directly for RawValues instead of converting them to `folly::dynamic`.
|
||||
*/
|
||||
RawPropsParser(bool useRawPropsJsiValue = ReactNativeFeatureFlags::useRawPropsJsiValue())
|
||||
: useRawPropsJsiValue_(useRawPropsJsiValue) {};
|
||||
RawPropsParser() = default;
|
||||
[[deprecated]] explicit RawPropsParser(bool /* ignored */) : RawPropsParser() {}
|
||||
|
||||
/*
|
||||
* To be used by `ConcreteComponentDescriptor` only.
|
||||
@@ -59,7 +56,6 @@ class RawPropsParser final {
|
||||
template <class ShadowNodeT>
|
||||
friend class ConcreteComponentDescriptor;
|
||||
friend class RawProps;
|
||||
bool useRawPropsJsiValue_{false};
|
||||
|
||||
/*
|
||||
* To be used by `RawProps` only.
|
||||
|
||||
@@ -405,8 +405,7 @@ class RawValue {
|
||||
static JsiValuePair castValue(const folly::dynamic & /*dynamic*/, JsiValuePair * /*type*/)
|
||||
{
|
||||
react_native_assert(false);
|
||||
throw std::runtime_error(
|
||||
"Cannot cast dynamic to a jsi::Value type. Please use the 'useRawPropsJsiValue' feature flag to enable jsi::Value support for RawValues.");
|
||||
throw std::runtime_error("Cannot cast dynamic to a jsi::Value type");
|
||||
}
|
||||
|
||||
static JsiValuePair castValue(jsi::Runtime *runtime, const jsi::Value &value, JsiValuePair * /*type*/)
|
||||
|
||||
@@ -889,16 +889,6 @@ const definitions: FeatureFlagDefinitions = {
|
||||
},
|
||||
ossReleaseStage: 'canary',
|
||||
},
|
||||
useRawPropsJsiValue: {
|
||||
defaultValue: true,
|
||||
metadata: {
|
||||
description:
|
||||
'Instead of using folly::dynamic as internal representation in RawProps and RawValue, use jsi::Value',
|
||||
expectedReleaseValue: true,
|
||||
purpose: 'release',
|
||||
},
|
||||
ossReleaseStage: 'none',
|
||||
},
|
||||
useShadowNodeStateOnClone: {
|
||||
defaultValue: true,
|
||||
metadata: {
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<db4650fb28b7c07c73eb75775a7e7811>>
|
||||
* @generated SignedSource<<02b24e5c75fb8d34646670771ac3b2ed>>
|
||||
* @flow strict
|
||||
* @noformat
|
||||
*/
|
||||
@@ -130,7 +130,6 @@ export type ReactNativeFeatureFlags = $ReadOnly<{
|
||||
useAlwaysAvailableJSErrorHandling: Getter<boolean>,
|
||||
useFabricInterop: Getter<boolean>,
|
||||
useNativeViewConfigsInBridgelessMode: Getter<boolean>,
|
||||
useRawPropsJsiValue: Getter<boolean>,
|
||||
useShadowNodeStateOnClone: Getter<boolean>,
|
||||
useSharedAnimatedBackend: Getter<boolean>,
|
||||
useTraitHiddenOnAndroid: Getter<boolean>,
|
||||
@@ -541,10 +540,6 @@ export const useFabricInterop: Getter<boolean> = createNativeFlagGetter('useFabr
|
||||
* When enabled, the native view configs are used in bridgeless mode.
|
||||
*/
|
||||
export const useNativeViewConfigsInBridgelessMode: Getter<boolean> = createNativeFlagGetter('useNativeViewConfigsInBridgelessMode', false);
|
||||
/**
|
||||
* Instead of using folly::dynamic as internal representation in RawProps and RawValue, use jsi::Value
|
||||
*/
|
||||
export const useRawPropsJsiValue: Getter<boolean> = createNativeFlagGetter('useRawPropsJsiValue', true);
|
||||
/**
|
||||
* Use the state stored on the source shadow node when cloning it instead of reading in the most recent state on the shadow node family.
|
||||
*/
|
||||
|
||||
+1
-2
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<14b4f8916fccd1d255b4a260556d11da>>
|
||||
* @generated SignedSource<<ada16f65a15e2335f493816782abf945>>
|
||||
* @flow strict
|
||||
* @noformat
|
||||
*/
|
||||
@@ -104,7 +104,6 @@ export interface Spec extends TurboModule {
|
||||
+useAlwaysAvailableJSErrorHandling?: () => boolean;
|
||||
+useFabricInterop?: () => boolean;
|
||||
+useNativeViewConfigsInBridgelessMode?: () => boolean;
|
||||
+useRawPropsJsiValue?: () => boolean;
|
||||
+useShadowNodeStateOnClone?: () => boolean;
|
||||
+useSharedAnimatedBackend?: () => boolean;
|
||||
+useTraitHiddenOnAndroid?: () => boolean;
|
||||
|
||||
Reference in new issue
Block a user