Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable 'allWarningsAsErrors' for CI android build (#38969)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38969

As we migrate java to kotlin I noticed that we've introduced few warnings here and there.
In this diff I'm enabling allWarningsAsErrors in the CI

The reasoning is that we are just starting with Kotlin and I believe we should enable 'allWarningsAsErrors' for CI android builds to make sure the codebase grow healthy, this will also help us to cleanup apis. e.g. create APIs for
deprecated java APIs.

changelog: [internal] internal

Reviewed By: NickGerleman

Differential Revision: D48239603

fbshipit-source-id: dd7a5df98cea82bf9bab6b26c4b1baa9f743ccbf
This commit is contained in:
David Vacca
2023-08-11 14:31:05 -07:00
committed by Facebook GitHub Bot
parent 824c1c6d07
commit e17c4a2ac9
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.circleci/config.yml
+1 -1
View File
@@ -1022,7 +1022,7 @@ jobs:
steps:
- run:
name: Build & Test React Native using Gradle
command: ./gradlew build
command: ./gradlew build -PenableWarningsAsErrors=true
- report_bundle_size:
platform: android