Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update _scrollAnimatedValue offset of ScrollViews. (#19481)

Browse Source 
Summary:
`_scrollAnimatedValue` offset of ScrollView is set once in `UNSAFE_componentWillMount` but it is never updated.
It causes unexpected render result.

![rn-scrollview-fix1](https://user-images.githubusercontent.com/143255/40640292-61843eca-6350-11e8-9412-f5383ea65ea0.gif)

So I suggest to update `_scrollAnimatedValue` offset when ScrollView contentInset is updated.
Pull Request resolved: https://github.com/facebook/react-native/pull/19481

Differential Revision: D14223304

Pulled By: cpojer

fbshipit-source-id: 4191cfcf6414adf3a0abd156517d5f9778565671
This commit is contained in:
Masayuki Iwai
2019-05-06 20:19:16 +02:00
committed by Mike Grabowski
parent 57dc37ec5b
commit e0d1b3ab84
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Libraries/Components/ScrollView/ScrollView.js
+12
View File
@@ -662,6 +662,18 @@ class ScrollView extends React.Component<Props, State> {
this._headerLayoutYs = new Map();
}
UNSAFE_componentWillReceiveProps(nextProps: Props) {
const currentContentInsetTop = this.props.contentInset
? this.props.contentInset.top
: 0;
const nextContentInsetTop = nextProps.contentInset
? nextProps.contentInset.top
: 0;
if (currentContentInsetTop !== nextContentInsetTop) {
this._scrollAnimatedValue.setOffset(nextContentInsetTop || 0);
}
}
componentDidMount() {
this._updateAnimatedNodeAttachment();
}