Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup RCTDisableTurboModuleManagerDelegateLocking (#38522)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38522

Changelog: [Internal]

as title

Reviewed By: mdvacca

Differential Revision: D47619958

fbshipit-source-id: f37efe205b4bf607dc5d159f87104edbf794c6eb
This commit is contained in:
Phillip Pan
2023-07-31 06:06:06 -07:00
committed by Facebook GitHub Bot
parent aab52859a4
commit de7c0655f0
3 changed files with 4 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/React/Base/RCTBridge.h
-4
View File
@@ -53,10 +53,6 @@ RCT_EXTERN void RCTEnableTurboModule(BOOL enabled);
RCT_EXTERN BOOL RCTTurboModuleEagerInitEnabled(void);
RCT_EXTERN void RCTEnableTurboModuleEagerInit(BOOL enabled);
// Turn off TurboModule delegate locking
RCT_EXTERN BOOL RCTTurboModuleManagerDelegateLockingDisabled(void);
RCT_EXTERN void RCTDisableTurboModuleManagerDelegateLocking(BOOL enabled);
// Turn on TurboModule interop
RCT_EXTERN BOOL RCTTurboModuleInteropEnabled(void);
RCT_EXTERN void RCTEnableTurboModuleInterop(BOOL enabled);
packages/react-native/React/Base/RCTBridge.mm
-12
View File
@@ -108,18 +108,6 @@ void RCTEnableTurboModuleEagerInit(BOOL enabled)
turboModuleEagerInitEnabled = enabled;
}
// Turn off TurboModule delegate locking
static BOOL turboModuleManagerDelegateLockingDisabled = YES;
BOOL RCTTurboModuleManagerDelegateLockingDisabled(void)
{
return turboModuleManagerDelegateLockingDisabled;
}
void RCTDisableTurboModuleManagerDelegateLocking(BOOL disabled)
{
turboModuleManagerDelegateLockingDisabled = disabled;
}
static BOOL turboModuleInteropEnabled = NO;
BOOL RCTTurboModuleInteropEnabled(void)
{
packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.mm
+4 -7
View File
@@ -786,10 +786,8 @@ static Class getFallbackClassFromName(const char *name)
return _legacyEagerlyRegisteredModuleClasses[moduleNameStr];
}
Class moduleClass;
if (RCTTurboModuleManagerDelegateLockingDisabled()) {
moduleClass = [_delegate getModuleClassFromName:moduleName];
} else {
Class moduleClass = nil;
{
std::lock_guard<std::mutex> delegateGuard(_turboModuleManagerDelegateMutex);
moduleClass = [_delegate getModuleClassFromName:moduleName];
}
@@ -828,12 +826,11 @@ static Class getFallbackClassFromName(const char *name)
}
id<RCTBridgeModule> module = nil;
if (RCTTurboModuleManagerDelegateLockingDisabled()) {
module = (id<RCTBridgeModule>)[_delegate getModuleInstanceFromClass:moduleClass];
} else {
{
std::lock_guard<std::mutex> delegateGuard(_turboModuleManagerDelegateMutex);
module = (id<RCTBridgeModule>)[_delegate getModuleInstanceFromClass:moduleClass];
}
if (!module) {
module = [moduleClass new];
}