mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Clean up stale QE rn_arch_android:use_optimized_event_batching_android (#54417)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/54417 Remove feature rn_arch_android:use_optimized_event_batching_android flag. Changelog: [internal] Reviewed By: javache Differential Revision: D86131089 fbshipit-source-id: 8ac81bc97a97071fc9fbf1f32ebda081d76db575
This commit is contained in:
1 parent
1033dbd1da
commit
de5141a3df
21 files changed
+32
-182
No files matched your search
+1
-7
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<66a87f8b82a1b3497eb9181a4ac6bab7>>
|
||||
* @generated SignedSource<<9646ebeba75ec903be5ade7e2333f0c8>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -468,12 +468,6 @@ public object ReactNativeFeatureFlags {
|
||||
@JvmStatic
|
||||
public fun useNativeViewConfigsInBridgelessMode(): Boolean = accessor.useNativeViewConfigsInBridgelessMode()
|
||||
|
||||
/**
|
||||
* Uses an optimized mechanism for event batching on Android that does not need to wait for a Choreographer frame callback.
|
||||
*/
|
||||
@JvmStatic
|
||||
public fun useOptimizedEventBatchingOnAndroid(): Boolean = accessor.useOptimizedEventBatchingOnAndroid()
|
||||
|
||||
/**
|
||||
* Instead of using folly::dynamic as internal representation in RawProps and RawValue, use jsi::Value
|
||||
*/
|
||||
|
||||
+1
-11
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<5112bb2a180751673d4197088af9fdd1>>
|
||||
* @generated SignedSource<<9d6ccbe6d02608901fc18ad88baab176>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -93,7 +93,6 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
|
||||
private var useNativeEqualsInNativeReadableArrayAndroidCache: Boolean? = null
|
||||
private var useNativeTransformHelperAndroidCache: Boolean? = null
|
||||
private var useNativeViewConfigsInBridgelessModeCache: Boolean? = null
|
||||
private var useOptimizedEventBatchingOnAndroidCache: Boolean? = null
|
||||
private var useRawPropsJsiValueCache: Boolean? = null
|
||||
private var useShadowNodeStateOnCloneCache: Boolean? = null
|
||||
private var useSharedAnimatedBackendCache: Boolean? = null
|
||||
@@ -761,15 +760,6 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun useOptimizedEventBatchingOnAndroid(): Boolean {
|
||||
var cached = useOptimizedEventBatchingOnAndroidCache
|
||||
if (cached == null) {
|
||||
cached = ReactNativeFeatureFlagsCxxInterop.useOptimizedEventBatchingOnAndroid()
|
||||
useOptimizedEventBatchingOnAndroidCache = cached
|
||||
}
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun useRawPropsJsiValue(): Boolean {
|
||||
var cached = useRawPropsJsiValueCache
|
||||
if (cached == null) {
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<d98233be82b913d6327c29a897d09eb7>>
|
||||
* @generated SignedSource<<fbc551ca005a7d8abcd2cf2e5d29a3a6>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -174,8 +174,6 @@ public object ReactNativeFeatureFlagsCxxInterop {
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun useNativeViewConfigsInBridgelessMode(): Boolean
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun useOptimizedEventBatchingOnAndroid(): Boolean
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun useRawPropsJsiValue(): Boolean
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun useShadowNodeStateOnClone(): Boolean
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<32ad8dfa8f1c1d662ff0ea7b424eb070>>
|
||||
* @generated SignedSource<<7b8a5ad9a3353ea32a39bd139e9174f7>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -169,8 +169,6 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
|
||||
|
||||
override fun useNativeViewConfigsInBridgelessMode(): Boolean = false
|
||||
|
||||
override fun useOptimizedEventBatchingOnAndroid(): Boolean = false
|
||||
|
||||
override fun useRawPropsJsiValue(): Boolean = true
|
||||
|
||||
override fun useShadowNodeStateOnClone(): Boolean = false
|
||||
|
||||
+1
-12
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<b10ff10cb0d389a563da50c75a49c746>>
|
||||
* @generated SignedSource<<9bb9a7cf89c92f5a397b2328fa983dc6>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -97,7 +97,6 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
|
||||
private var useNativeEqualsInNativeReadableArrayAndroidCache: Boolean? = null
|
||||
private var useNativeTransformHelperAndroidCache: Boolean? = null
|
||||
private var useNativeViewConfigsInBridgelessModeCache: Boolean? = null
|
||||
private var useOptimizedEventBatchingOnAndroidCache: Boolean? = null
|
||||
private var useRawPropsJsiValueCache: Boolean? = null
|
||||
private var useShadowNodeStateOnCloneCache: Boolean? = null
|
||||
private var useSharedAnimatedBackendCache: Boolean? = null
|
||||
@@ -838,16 +837,6 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun useOptimizedEventBatchingOnAndroid(): Boolean {
|
||||
var cached = useOptimizedEventBatchingOnAndroidCache
|
||||
if (cached == null) {
|
||||
cached = currentProvider.useOptimizedEventBatchingOnAndroid()
|
||||
accessedFeatureFlags.add("useOptimizedEventBatchingOnAndroid")
|
||||
useOptimizedEventBatchingOnAndroidCache = cached
|
||||
}
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun useRawPropsJsiValue(): Boolean {
|
||||
var cached = useRawPropsJsiValueCache
|
||||
if (cached == null) {
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<c4917c92012d904810ef7d832adf124c>>
|
||||
* @generated SignedSource<<eeb5d70e45eecdef0d9307cbe8ff17c2>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -169,8 +169,6 @@ public interface ReactNativeFeatureFlagsProvider {
|
||||
|
||||
@DoNotStrip public fun useNativeViewConfigsInBridgelessMode(): Boolean
|
||||
|
||||
@DoNotStrip public fun useOptimizedEventBatchingOnAndroid(): Boolean
|
||||
|
||||
@DoNotStrip public fun useRawPropsJsiValue(): Boolean
|
||||
|
||||
@DoNotStrip public fun useShadowNodeStateOnClone(): Boolean
|
||||
|
||||
+3
-36
@@ -7,14 +7,12 @@
|
||||
|
||||
package com.facebook.react.uimanager.events
|
||||
|
||||
import android.os.Handler
|
||||
import android.view.Choreographer
|
||||
import com.facebook.react.bridge.LifecycleEventListener
|
||||
import com.facebook.react.bridge.ReactApplicationContext
|
||||
import com.facebook.react.bridge.ReactSoftExceptionLogger
|
||||
import com.facebook.react.bridge.UiThreadUtil
|
||||
import com.facebook.react.common.annotations.UnstableReactNativeAPI
|
||||
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags
|
||||
import com.facebook.react.modules.core.ReactChoreographer
|
||||
import com.facebook.react.uimanager.UIManagerHelper
|
||||
import com.facebook.react.uimanager.common.UIManagerType
|
||||
@@ -41,19 +39,6 @@ internal class FabricEventDispatcher(
|
||||
private val postEventDispatchListeners = CopyOnWriteArrayList<BatchEventDispatchedListener>()
|
||||
private val currentFrameCallback = ScheduleDispatchFrameCallback()
|
||||
|
||||
private var isDispatchScheduled = false
|
||||
private val dispatchEventsRunnable = Runnable {
|
||||
isDispatchScheduled = false
|
||||
Systrace.beginSection(Systrace.TRACE_TAG_REACT, "BatchEventDispatchedListeners")
|
||||
try {
|
||||
for (listener in postEventDispatchListeners) {
|
||||
listener.onBatchEventDispatched()
|
||||
}
|
||||
} finally {
|
||||
Systrace.endSection(Systrace.TRACE_TAG_REACT)
|
||||
}
|
||||
}
|
||||
|
||||
init {
|
||||
reactContext.addLifecycleEventListener(this)
|
||||
eventEmitter.registerFabricEventEmitter(fabricEventEmitter)
|
||||
@@ -109,14 +94,7 @@ internal class FabricEventDispatcher(
|
||||
}
|
||||
|
||||
private fun scheduleDispatchOfBatchedEvents() {
|
||||
if (ReactNativeFeatureFlags.useOptimizedEventBatchingOnAndroid()) {
|
||||
if (!isDispatchScheduled) {
|
||||
isDispatchScheduled = true
|
||||
uiThreadHandler.postAtFrontOfQueue(dispatchEventsRunnable)
|
||||
}
|
||||
} else {
|
||||
currentFrameCallback.maybeScheduleDispatchOfBatchedEvents()
|
||||
}
|
||||
currentFrameCallback.maybeScheduleDispatchOfBatchedEvents()
|
||||
}
|
||||
|
||||
/** Add a listener to this EventDispatcher. */
|
||||
@@ -139,9 +117,7 @@ internal class FabricEventDispatcher(
|
||||
|
||||
override fun onHostResume() {
|
||||
scheduleDispatchOfBatchedEvents()
|
||||
if (!ReactNativeFeatureFlags.useOptimizedEventBatchingOnAndroid()) {
|
||||
currentFrameCallback.resume()
|
||||
}
|
||||
currentFrameCallback.resume()
|
||||
}
|
||||
|
||||
override fun onHostPause() {
|
||||
@@ -165,12 +141,7 @@ internal class FabricEventDispatcher(
|
||||
|
||||
private fun cancelDispatchOfBatchedEvents() {
|
||||
UiThreadUtil.assertOnUiThread()
|
||||
if (ReactNativeFeatureFlags.useOptimizedEventBatchingOnAndroid()) {
|
||||
isDispatchScheduled = false
|
||||
uiThreadHandler.removeCallbacks(dispatchEventsRunnable)
|
||||
} else {
|
||||
currentFrameCallback.stop()
|
||||
}
|
||||
currentFrameCallback.stop()
|
||||
}
|
||||
|
||||
private inner class ScheduleDispatchFrameCallback : Choreographer.FrameCallback {
|
||||
@@ -229,8 +200,4 @@ internal class FabricEventDispatcher(
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private companion object {
|
||||
private val uiThreadHandler: Handler = UiThreadUtil.getUiThreadHandler()
|
||||
}
|
||||
}
|
||||
+1
-15
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<ddcb4ebb0a1e5e80364d081650286b96>>
|
||||
* @generated SignedSource<<0527dbb4a838be34b80d76b11d18cea0>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -477,12 +477,6 @@ class ReactNativeFeatureFlagsJavaProvider
|
||||
return method(javaProvider_);
|
||||
}
|
||||
|
||||
bool useOptimizedEventBatchingOnAndroid() override {
|
||||
static const auto method =
|
||||
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("useOptimizedEventBatchingOnAndroid");
|
||||
return method(javaProvider_);
|
||||
}
|
||||
|
||||
bool useRawPropsJsiValue() override {
|
||||
static const auto method =
|
||||
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("useRawPropsJsiValue");
|
||||
@@ -906,11 +900,6 @@ bool JReactNativeFeatureFlagsCxxInterop::useNativeViewConfigsInBridgelessMode(
|
||||
return ReactNativeFeatureFlags::useNativeViewConfigsInBridgelessMode();
|
||||
}
|
||||
|
||||
bool JReactNativeFeatureFlagsCxxInterop::useOptimizedEventBatchingOnAndroid(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
|
||||
return ReactNativeFeatureFlags::useOptimizedEventBatchingOnAndroid();
|
||||
}
|
||||
|
||||
bool JReactNativeFeatureFlagsCxxInterop::useRawPropsJsiValue(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
|
||||
return ReactNativeFeatureFlags::useRawPropsJsiValue();
|
||||
@@ -1206,9 +1195,6 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
|
||||
makeNativeMethod(
|
||||
"useNativeViewConfigsInBridgelessMode",
|
||||
JReactNativeFeatureFlagsCxxInterop::useNativeViewConfigsInBridgelessMode),
|
||||
makeNativeMethod(
|
||||
"useOptimizedEventBatchingOnAndroid",
|
||||
JReactNativeFeatureFlagsCxxInterop::useOptimizedEventBatchingOnAndroid),
|
||||
makeNativeMethod(
|
||||
"useRawPropsJsiValue",
|
||||
JReactNativeFeatureFlagsCxxInterop::useRawPropsJsiValue),
|
||||
|
||||
+1
-4
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<1e735f99b2d275f5065fb7959e45adc5>>
|
||||
* @generated SignedSource<<a1deb0145d8c51d608903e1704e96b8d>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -249,9 +249,6 @@ class JReactNativeFeatureFlagsCxxInterop
|
||||
static bool useNativeViewConfigsInBridgelessMode(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
|
||||
|
||||
static bool useOptimizedEventBatchingOnAndroid(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
|
||||
|
||||
static bool useRawPropsJsiValue(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
|
||||
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<5a7c80b50fda63afb95e8c6f4651eebc>>
|
||||
* @generated SignedSource<<a2224b72c2e27abf6a158aa1b4fe9ed0>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -318,10 +318,6 @@ bool ReactNativeFeatureFlags::useNativeViewConfigsInBridgelessMode() {
|
||||
return getAccessor().useNativeViewConfigsInBridgelessMode();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlags::useOptimizedEventBatchingOnAndroid() {
|
||||
return getAccessor().useOptimizedEventBatchingOnAndroid();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlags::useRawPropsJsiValue() {
|
||||
return getAccessor().useRawPropsJsiValue();
|
||||
}
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<8122e5c1e177a8f3deb2462a86f7cf64>>
|
||||
* @generated SignedSource<<467f48f2231ceb6772a9a9da9e3badb9>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -404,11 +404,6 @@ class ReactNativeFeatureFlags {
|
||||
*/
|
||||
RN_EXPORT static bool useNativeViewConfigsInBridgelessMode();
|
||||
|
||||
/**
|
||||
* Uses an optimized mechanism for event batching on Android that does not need to wait for a Choreographer frame callback.
|
||||
*/
|
||||
RN_EXPORT static bool useOptimizedEventBatchingOnAndroid();
|
||||
|
||||
/**
|
||||
* Instead of using folly::dynamic as internal representation in RawProps and RawValue, use jsi::Value
|
||||
*/
|
||||
|
||||
+10
-28
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<b67bda97ce431fabe17bb4c598d2c1f3>>
|
||||
* @generated SignedSource<<8f6640b5dc86a3f50b14ba9d222de89c>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -1343,24 +1343,6 @@ bool ReactNativeFeatureFlagsAccessor::useNativeViewConfigsInBridgelessMode() {
|
||||
return flagValue.value();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlagsAccessor::useOptimizedEventBatchingOnAndroid() {
|
||||
auto flagValue = useOptimizedEventBatchingOnAndroid_.load();
|
||||
|
||||
if (!flagValue.has_value()) {
|
||||
// This block is not exclusive but it is not necessary.
|
||||
// If multiple threads try to initialize the feature flag, we would only
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(73, "useOptimizedEventBatchingOnAndroid");
|
||||
|
||||
flagValue = currentProvider_->useOptimizedEventBatchingOnAndroid();
|
||||
useOptimizedEventBatchingOnAndroid_ = flagValue;
|
||||
}
|
||||
|
||||
return flagValue.value();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlagsAccessor::useRawPropsJsiValue() {
|
||||
auto flagValue = useRawPropsJsiValue_.load();
|
||||
|
||||
@@ -1370,7 +1352,7 @@ bool ReactNativeFeatureFlagsAccessor::useRawPropsJsiValue() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(74, "useRawPropsJsiValue");
|
||||
markFlagAsAccessed(73, "useRawPropsJsiValue");
|
||||
|
||||
flagValue = currentProvider_->useRawPropsJsiValue();
|
||||
useRawPropsJsiValue_ = flagValue;
|
||||
@@ -1388,7 +1370,7 @@ bool ReactNativeFeatureFlagsAccessor::useShadowNodeStateOnClone() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(75, "useShadowNodeStateOnClone");
|
||||
markFlagAsAccessed(74, "useShadowNodeStateOnClone");
|
||||
|
||||
flagValue = currentProvider_->useShadowNodeStateOnClone();
|
||||
useShadowNodeStateOnClone_ = flagValue;
|
||||
@@ -1406,7 +1388,7 @@ bool ReactNativeFeatureFlagsAccessor::useSharedAnimatedBackend() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(76, "useSharedAnimatedBackend");
|
||||
markFlagAsAccessed(75, "useSharedAnimatedBackend");
|
||||
|
||||
flagValue = currentProvider_->useSharedAnimatedBackend();
|
||||
useSharedAnimatedBackend_ = flagValue;
|
||||
@@ -1424,7 +1406,7 @@ bool ReactNativeFeatureFlagsAccessor::useTraitHiddenOnAndroid() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(77, "useTraitHiddenOnAndroid");
|
||||
markFlagAsAccessed(76, "useTraitHiddenOnAndroid");
|
||||
|
||||
flagValue = currentProvider_->useTraitHiddenOnAndroid();
|
||||
useTraitHiddenOnAndroid_ = flagValue;
|
||||
@@ -1442,7 +1424,7 @@ bool ReactNativeFeatureFlagsAccessor::useTurboModuleInterop() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(78, "useTurboModuleInterop");
|
||||
markFlagAsAccessed(77, "useTurboModuleInterop");
|
||||
|
||||
flagValue = currentProvider_->useTurboModuleInterop();
|
||||
useTurboModuleInterop_ = flagValue;
|
||||
@@ -1460,7 +1442,7 @@ bool ReactNativeFeatureFlagsAccessor::useTurboModules() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(79, "useTurboModules");
|
||||
markFlagAsAccessed(78, "useTurboModules");
|
||||
|
||||
flagValue = currentProvider_->useTurboModules();
|
||||
useTurboModules_ = flagValue;
|
||||
@@ -1478,7 +1460,7 @@ double ReactNativeFeatureFlagsAccessor::viewCullingOutsetRatio() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(80, "viewCullingOutsetRatio");
|
||||
markFlagAsAccessed(79, "viewCullingOutsetRatio");
|
||||
|
||||
flagValue = currentProvider_->viewCullingOutsetRatio();
|
||||
viewCullingOutsetRatio_ = flagValue;
|
||||
@@ -1496,7 +1478,7 @@ double ReactNativeFeatureFlagsAccessor::virtualViewHysteresisRatio() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(81, "virtualViewHysteresisRatio");
|
||||
markFlagAsAccessed(80, "virtualViewHysteresisRatio");
|
||||
|
||||
flagValue = currentProvider_->virtualViewHysteresisRatio();
|
||||
virtualViewHysteresisRatio_ = flagValue;
|
||||
@@ -1514,7 +1496,7 @@ double ReactNativeFeatureFlagsAccessor::virtualViewPrerenderRatio() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(82, "virtualViewPrerenderRatio");
|
||||
markFlagAsAccessed(81, "virtualViewPrerenderRatio");
|
||||
|
||||
flagValue = currentProvider_->virtualViewPrerenderRatio();
|
||||
virtualViewPrerenderRatio_ = flagValue;
|
||||
|
||||
+2
-4
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<d96c22d66def7b301f08c53a27b8a801>>
|
||||
* @generated SignedSource<<b72070ee07df0d084009668488efb889>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -105,7 +105,6 @@ class ReactNativeFeatureFlagsAccessor {
|
||||
bool useNativeEqualsInNativeReadableArrayAndroid();
|
||||
bool useNativeTransformHelperAndroid();
|
||||
bool useNativeViewConfigsInBridgelessMode();
|
||||
bool useOptimizedEventBatchingOnAndroid();
|
||||
bool useRawPropsJsiValue();
|
||||
bool useShadowNodeStateOnClone();
|
||||
bool useSharedAnimatedBackend();
|
||||
@@ -126,7 +125,7 @@ class ReactNativeFeatureFlagsAccessor {
|
||||
std::unique_ptr<ReactNativeFeatureFlagsProvider> currentProvider_;
|
||||
bool wasOverridden_;
|
||||
|
||||
std::array<std::atomic<const char*>, 83> accessedFeatureFlags_;
|
||||
std::array<std::atomic<const char*>, 82> accessedFeatureFlags_;
|
||||
|
||||
std::atomic<std::optional<bool>> commonTestFlag_;
|
||||
std::atomic<std::optional<bool>> cdpInteractionMetricsEnabled_;
|
||||
@@ -201,7 +200,6 @@ class ReactNativeFeatureFlagsAccessor {
|
||||
std::atomic<std::optional<bool>> useNativeEqualsInNativeReadableArrayAndroid_;
|
||||
std::atomic<std::optional<bool>> useNativeTransformHelperAndroid_;
|
||||
std::atomic<std::optional<bool>> useNativeViewConfigsInBridgelessMode_;
|
||||
std::atomic<std::optional<bool>> useOptimizedEventBatchingOnAndroid_;
|
||||
std::atomic<std::optional<bool>> useRawPropsJsiValue_;
|
||||
std::atomic<std::optional<bool>> useShadowNodeStateOnClone_;
|
||||
std::atomic<std::optional<bool>> useSharedAnimatedBackend_;
|
||||
|
||||
+1
-5
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<4e4623461411b957286ef050ec0c4f6f>>
|
||||
* @generated SignedSource<<85c260dcb8eb9209a53207c3c54183f0>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -319,10 +319,6 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
|
||||
return false;
|
||||
}
|
||||
|
||||
bool useOptimizedEventBatchingOnAndroid() override {
|
||||
return false;
|
||||
}
|
||||
|
||||
bool useRawPropsJsiValue() override {
|
||||
return true;
|
||||
}
|
||||
|
||||
+1
-10
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<e801911a762dd0af61cdde5c34cd1e7e>>
|
||||
* @generated SignedSource<<0224a638fbec556a62c58f5d84c4c662>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -702,15 +702,6 @@ class ReactNativeFeatureFlagsDynamicProvider : public ReactNativeFeatureFlagsDef
|
||||
return ReactNativeFeatureFlagsDefaults::useNativeViewConfigsInBridgelessMode();
|
||||
}
|
||||
|
||||
bool useOptimizedEventBatchingOnAndroid() override {
|
||||
auto value = values_["useOptimizedEventBatchingOnAndroid"];
|
||||
if (!value.isNull()) {
|
||||
return value.getBool();
|
||||
}
|
||||
|
||||
return ReactNativeFeatureFlagsDefaults::useOptimizedEventBatchingOnAndroid();
|
||||
}
|
||||
|
||||
bool useRawPropsJsiValue() override {
|
||||
auto value = values_["useRawPropsJsiValue"];
|
||||
if (!value.isNull()) {
|
||||
|
||||
+1
-2
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<5dbb5d1dd34c8bdd887de68a074449b6>>
|
||||
* @generated SignedSource<<a50e4901fa5524066608b64929744dd8>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -98,7 +98,6 @@ class ReactNativeFeatureFlagsProvider {
|
||||
virtual bool useNativeEqualsInNativeReadableArrayAndroid() = 0;
|
||||
virtual bool useNativeTransformHelperAndroid() = 0;
|
||||
virtual bool useNativeViewConfigsInBridgelessMode() = 0;
|
||||
virtual bool useOptimizedEventBatchingOnAndroid() = 0;
|
||||
virtual bool useRawPropsJsiValue() = 0;
|
||||
virtual bool useShadowNodeStateOnClone() = 0;
|
||||
virtual bool useSharedAnimatedBackend() = 0;
|
||||
|
||||
+1
-6
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<5963824c70d97cf048050db905350692>>
|
||||
* @generated SignedSource<<bd66756451b25d73717a5907e6789a77>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -409,11 +409,6 @@ bool NativeReactNativeFeatureFlags::useNativeViewConfigsInBridgelessMode(
|
||||
return ReactNativeFeatureFlags::useNativeViewConfigsInBridgelessMode();
|
||||
}
|
||||
|
||||
bool NativeReactNativeFeatureFlags::useOptimizedEventBatchingOnAndroid(
|
||||
jsi::Runtime& /*runtime*/) {
|
||||
return ReactNativeFeatureFlags::useOptimizedEventBatchingOnAndroid();
|
||||
}
|
||||
|
||||
bool NativeReactNativeFeatureFlags::useRawPropsJsiValue(
|
||||
jsi::Runtime& /*runtime*/) {
|
||||
return ReactNativeFeatureFlags::useRawPropsJsiValue();
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<84b5ef5e3ada0d6f2b10abfffa6d9d0f>>
|
||||
* @generated SignedSource<<0d898a94decb43e191a343676c8afb91>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -182,8 +182,6 @@ class NativeReactNativeFeatureFlags
|
||||
|
||||
bool useNativeViewConfigsInBridgelessMode(jsi::Runtime& runtime);
|
||||
|
||||
bool useOptimizedEventBatchingOnAndroid(jsi::Runtime& runtime);
|
||||
|
||||
bool useRawPropsJsiValue(jsi::Runtime& runtime);
|
||||
|
||||
bool useShadowNodeStateOnClone(jsi::Runtime& runtime);
|
||||
|
||||
@@ -825,17 +825,6 @@ const definitions: FeatureFlagDefinitions = {
|
||||
},
|
||||
ossReleaseStage: 'canary',
|
||||
},
|
||||
useOptimizedEventBatchingOnAndroid: {
|
||||
defaultValue: false,
|
||||
metadata: {
|
||||
dateAdded: '2024-08-29',
|
||||
description:
|
||||
'Uses an optimized mechanism for event batching on Android that does not need to wait for a Choreographer frame callback.',
|
||||
expectedReleaseValue: true,
|
||||
purpose: 'experimentation',
|
||||
},
|
||||
ossReleaseStage: 'none',
|
||||
},
|
||||
useRawPropsJsiValue: {
|
||||
defaultValue: true,
|
||||
metadata: {
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<954a37442d8c691f35c868b9998a5aa3>>
|
||||
* @generated SignedSource<<a52734633ac33a6f8dfc521bdc6e2692>>
|
||||
* @flow strict
|
||||
* @noformat
|
||||
*/
|
||||
@@ -123,7 +123,6 @@ export type ReactNativeFeatureFlags = $ReadOnly<{
|
||||
useNativeEqualsInNativeReadableArrayAndroid: Getter<boolean>,
|
||||
useNativeTransformHelperAndroid: Getter<boolean>,
|
||||
useNativeViewConfigsInBridgelessMode: Getter<boolean>,
|
||||
useOptimizedEventBatchingOnAndroid: Getter<boolean>,
|
||||
useRawPropsJsiValue: Getter<boolean>,
|
||||
useShadowNodeStateOnClone: Getter<boolean>,
|
||||
useSharedAnimatedBackend: Getter<boolean>,
|
||||
@@ -506,10 +505,6 @@ export const useNativeTransformHelperAndroid: Getter<boolean> = createNativeFlag
|
||||
* When enabled, the native view configs are used in bridgeless mode.
|
||||
*/
|
||||
export const useNativeViewConfigsInBridgelessMode: Getter<boolean> = createNativeFlagGetter('useNativeViewConfigsInBridgelessMode', false);
|
||||
/**
|
||||
* Uses an optimized mechanism for event batching on Android that does not need to wait for a Choreographer frame callback.
|
||||
*/
|
||||
export const useOptimizedEventBatchingOnAndroid: Getter<boolean> = createNativeFlagGetter('useOptimizedEventBatchingOnAndroid', false);
|
||||
/**
|
||||
* Instead of using folly::dynamic as internal representation in RawProps and RawValue, use jsi::Value
|
||||
*/
|
||||
|
||||
+1
-2
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<05001c6fab50172dc659d30b5e82af20>>
|
||||
* @generated SignedSource<<53fc9aca82f76eb0519b03187993359a>>
|
||||
* @flow strict
|
||||
* @noformat
|
||||
*/
|
||||
@@ -98,7 +98,6 @@ export interface Spec extends TurboModule {
|
||||
+useNativeEqualsInNativeReadableArrayAndroid?: () => boolean;
|
||||
+useNativeTransformHelperAndroid?: () => boolean;
|
||||
+useNativeViewConfigsInBridgelessMode?: () => boolean;
|
||||
+useOptimizedEventBatchingOnAndroid?: () => boolean;
|
||||
+useRawPropsJsiValue?: () => boolean;
|
||||
+useShadowNodeStateOnClone?: () => boolean;
|
||||
+useSharedAnimatedBackend?: () => boolean;
|
||||
|
||||
Reference in new issue
Block a user