Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix incorrect measurement of TextInput (#42655)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/42655

This bug is caused by a caching issue: when the user enters a new character into the textInput: ReactTextInput 1) caches the Spannable entered by the user and 2) it updates internal Fabric state, which triggers the measurement of the TextInput component using the cached Spannable.

The problem is that the Spannable entered by the user has the wrong "styles" for the text input. Since measurement is using the cached Spannable, then the measurement of the TextInput ends up being is incorrect.

In this diff I'm fixing the bug by updating the styles (lineHeight) of the cached spannable that is cached when the user updates the TextInput.
The styles weren't updated correctly because mTextAttributes didn't have the proper style props set

Changelog:
    [Android][Fixed] - Fix incorrect measurement of TextInput when new architecture is enabled

Reviewed By: javache, sammy-SC

Differential Revision: D52924982

fbshipit-source-id: ced9f2c348bdb9bf706028b1063858cebd5a071a
This commit is contained in:
David Vacca
2024-01-25 11:07:12 -08:00
committed by Facebook GitHub Bot
parent 97d6d724e1
commit dc2ce9e66e
3 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/api/ReactAndroid.api
+2
View File
@@ -7381,6 +7381,7 @@ public class com/facebook/react/views/textinput/ReactEditText : androidx/appcomp
public fun setFontWeight (Ljava/lang/String;)V
public fun setInputType (I)V
public fun setLetterSpacingPt (F)V
public fun setLineHeight (I)V
public fun setMaxFontSizeMultiplier (F)V
public fun setOnKeyPress (Z)V
public fun setPlaceholder (Ljava/lang/String;)V
@@ -7468,6 +7469,7 @@ public class com/facebook/react/views/textinput/ReactTextInputManager : com/face
public fun setInlineImagePadding (Lcom/facebook/react/views/textinput/ReactEditText;I)V
public fun setKeyboardType (Lcom/facebook/react/views/textinput/ReactEditText;Ljava/lang/String;)V
public fun setLetterSpacing (Lcom/facebook/react/views/textinput/ReactEditText;F)V
public fun setLineHeight (Lcom/facebook/react/views/textinput/ReactEditText;I)V
public fun setMaxFontSizeMultiplier (Lcom/facebook/react/views/textinput/ReactEditText;F)V
public fun setMaxLength (Lcom/facebook/react/views/textinput/ReactEditText;Ljava/lang/Integer;)V
public fun setMultiline (Lcom/facebook/react/views/textinput/ReactEditText;Z)V
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java
+6
View File
@@ -270,6 +270,12 @@ public class ReactEditText extends AppCompatEditText {
return super.onKeyUp(keyCode, event);
}
@Override
public void setLineHeight(int lineHeight) {
mTextAttributes.setLineHeight(lineHeight);
super.setLineHeight(lineHeight);
}
@Override
protected void onScrollChanged(int horiz, int vert, int oldHoriz, int oldVert) {
super.onScrollChanged(horiz, vert, oldHoriz, oldVert);
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java
+5
View File
@@ -382,6 +382,11 @@ public class ReactTextInputManager extends BaseViewManager<ReactEditText, Layout
}
}
@ReactProp(name = ViewProps.LINE_HEIGHT, defaultFloat = ViewDefaults.LINE_HEIGHT)
public void setLineHeight(ReactEditText view, int lineHeight) {
view.setLineHeight(lineHeight);
}
@ReactProp(name = ViewProps.FONT_SIZE, defaultFloat = ViewDefaults.FONT_SIZE_SP)
public void setFontSize(ReactEditText view, float fontSize) {
view.setFontSize(fontSize);