Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Switch iOS focus/blur calls to use new commands

Browse Source 
Summary:
Make iOS use Commands instead of UIManager.{focus,blur}. This makes these apis compatible with Fabric and paper at the same time.

Changelog:
[Internal] Switch iOS focus/blur calls to use new commands

Reviewed By: mdvacca

Differential Revision: D19458995

fbshipit-source-id: 8c4aacd41941f54a887aeec1a17d9ce0b6878ab1
This commit is contained in:
Eli White
2020-02-19 15:29:00 -08:00
committed by Facebook Github Bot
parent 147055466a
commit da9364fa3e
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Libraries/Components/TextInput/TextInputState.js
+13 -5
View File
@@ -16,9 +16,9 @@
const React = require('react');
const Platform = require('../../Utilities/Platform');
const UIManager = require('../../ReactNative/UIManager');
const {findNodeHandle} = require('../../Renderer/shims/ReactNative');
import {Commands as AndroidTextInputCommands} from '../../Components/TextInput/AndroidTextInputNativeComponent';
import {Commands as iOSTextInputCommands} from '../../Components/TextInput/RCTSingelineTextInputNativeComponent';
import type {HostComponent} from '../../Renderer/shims/ReactNativeTypes';
type ComponentRef = React.ElementRef<HostComponent<mixed>>;
@@ -89,10 +89,14 @@ function focusTextInput(textField: ?ComponentRef) {
}
if (currentlyFocusedInputRef !== textField && textField != null) {
const textFieldID = findNodeHandle(textField);
focusInput(textField);
if (Platform.OS === 'ios') {
UIManager.focus(textFieldID);
// This isn't necessarily a single line text input
// But commands don't actually care as long as the thing being passed in
// actually has a command with that name. So this should work with single
// and multiline text inputs. Ideally we'll merge them into one component
// in the future.
iOSTextInputCommands.focus(textField);
} else if (Platform.OS === 'android') {
AndroidTextInputCommands.focus(textField);
}
@@ -116,10 +120,14 @@ function blurTextInput(textField: ?ComponentRef) {
}
if (currentlyFocusedInputRef === textField && textField != null) {
const textFieldID = findNodeHandle(textField);
blurInput(textField);
if (Platform.OS === 'ios') {
UIManager.blur(textFieldID);
// This isn't necessarily a single line text input
// But commands don't actually care as long as the thing being passed in
// actually has a command with that name. So this should work with single
// and multiline text inputs. Ideally we'll merge them into one component
// in the future.
iOSTextInputCommands.blur(textField);
} else if (Platform.OS === 'android') {
AndroidTextInputCommands.blur(textField);
}