mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Use target_compile_reactnative_options for the remaining third-party libs (#49743)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/49743 Those 3rd party CMake libraries were not using our compiler flags correctly. This fixes it. Changelog: [Internal] [Changed] - Reviewed By: javache Differential Revision: D70386743 fbshipit-source-id: e35688f7eb3fa9bcdda1180023006d267782ceaf
This commit is contained in:
committed by
Facebook GitHub Bot
parent
87466a2025
commit
d8b714488b
+1
@@ -19,4 +19,5 @@ add_library(boost STATIC ${boostasm_SRC})
|
||||
set_target_properties(boost PROPERTIES LINKER_LANGUAGE CXX)
|
||||
|
||||
target_include_directories(boost PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/boost_1_83_0)
|
||||
target_compile_options(boost PRIVATE -fexceptions -frtti)
|
||||
|
||||
|
||||
Vendored
+4
-1
@@ -6,7 +6,7 @@
|
||||
cmake_minimum_required(VERSION 3.13)
|
||||
set(CMAKE_VERBOSE_MAKEFILE on)
|
||||
|
||||
add_compile_options(-Wno-unused-variable -Wno-unused-local-typedefs)
|
||||
include(${REACT_ANDROID_DIR}/cmake-utils/react-native-flags.cmake)
|
||||
|
||||
add_library(double-conversion
|
||||
STATIC
|
||||
@@ -21,3 +21,6 @@ add_library(double-conversion
|
||||
|
||||
target_include_directories(double-conversion PUBLIC .)
|
||||
|
||||
target_compile_reactnative_options(double-conversion PRIVATE)
|
||||
target_compile_options(double-conversion PRIVATE -Wno-unused-variable -Wno-unused-local-typedefs)
|
||||
|
||||
|
||||
+14
-9
@@ -6,15 +6,7 @@
|
||||
cmake_minimum_required(VERSION 3.13)
|
||||
set(CMAKE_VERBOSE_MAKEFILE on)
|
||||
|
||||
add_compile_options(
|
||||
-Wwrite-strings
|
||||
-Woverloaded-virtual
|
||||
-Wno-sign-compare
|
||||
-DNDEBUG
|
||||
-g
|
||||
-O2
|
||||
-DHAVE_PREAD=1
|
||||
)
|
||||
include(${REACT_ANDROID_DIR}/cmake-utils/react-native-flags.cmake)
|
||||
|
||||
add_library(glog
|
||||
STATIC
|
||||
@@ -33,3 +25,16 @@ target_include_directories(glog PRIVATE .)
|
||||
# For consumer, we set the `exported` dir as the
|
||||
# include folder.
|
||||
target_include_directories(glog PUBLIC exported)
|
||||
|
||||
target_compile_reactnative_options(glog PRIVATE)
|
||||
|
||||
target_compile_options(glog PRIVATE
|
||||
-Wwrite-strings
|
||||
-Woverloaded-virtual
|
||||
-Wno-sign-compare
|
||||
-DNDEBUG
|
||||
-g
|
||||
-O2
|
||||
-DHAVE_PREAD=1
|
||||
)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user