mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
fix: TouchableNativeFeedback ripple starts on previous touch location (#31777)
Summary: TouchableNativeFeedback's ripple starts from previous location on subsequent presses. This is similar to https://github.com/facebook/react-native/pull/31669 Fixes https://github.com/facebook/react-native/issues/28944 Issue https://user-images.githubusercontent.com/23293248/123521731-1f375f00-d6d6-11eb-8e4c-fc5ffb322e67.mov Fix https://user-images.githubusercontent.com/23293248/123521735-2bbbb780-d6d6-11eb-88b2-be75342cf22a.mov ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Android] [Fixed] - TouchableNativeFeedback ripple starts on previous touch location. Pull Request resolved: https://github.com/facebook/react-native/pull/31777 Test Plan: Tested TouchableNativeFeedback examples in rn-tester app. Registering coordinates before pressed command fixes the issue. Reviewed By: lunaleaps Differential Revision: D29496515 Pulled By: kacieb fbshipit-source-id: 77ac626181a61eee2cd30c4d48e52d10d800f2d8
This commit is contained in:
committed by
Facebook GitHub Bot
parent
ebe939b18a
commit
d85d72d0d9
@@ -183,8 +183,8 @@ class TouchableNativeFeedback extends React.Component<Props, State> {
|
||||
onPress: this.props.onPress,
|
||||
onPressIn: event => {
|
||||
if (Platform.OS === 'android') {
|
||||
this._dispatchPressedStateChange(true);
|
||||
this._dispatchHotspotUpdate(event);
|
||||
this._dispatchPressedStateChange(true);
|
||||
}
|
||||
if (this.props.onPressIn != null) {
|
||||
this.props.onPressIn(event);
|
||||
|
||||
Reference in New Issue
Block a user