mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Cover react/networking:networking with Stable API guards (#58008)
Summary: Pull Request resolved: https://github.com/react/react-native/pull/58008 Classifies `react/networking:networking` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to both of the module's exported headers (`NetworkReporter.h`, `NetworkTypes.h`), and wires the guard dependency into BUCK, CMake, and the podspec. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D116591313 fbshipit-source-id: 4d789b42df63b61db3951712d59cdb1f4b03f90c
This commit is contained in:
1 parent
ea06a3191f
commit
d83d10674d
4 files changed
+6
No files matched your search
@@ -19,6 +19,7 @@ target_link_libraries(react_networking
|
||||
folly_runtime
|
||||
jsinspector_network
|
||||
jsinspector_tracing
|
||||
react_cxxstableapi
|
||||
react_performance_timeline
|
||||
react_timing)
|
||||
|
||||
|
||||
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/PrivateGuard.h>
|
||||
|
||||
#include "NetworkTypes.h"
|
||||
|
||||
#include <react/timing/primitives.h>
|
||||
|
||||
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/PrivateGuard.h>
|
||||
|
||||
#include <map>
|
||||
#include <optional>
|
||||
#include <string>
|
||||
|
||||
@@ -45,6 +45,7 @@ Pod::Spec.new do |s|
|
||||
add_dependency(s, "React-jsinspectortracing", :framework_name => 'jsinspector_moderntracing')
|
||||
s.dependency "React-performancetimeline"
|
||||
s.dependency "React-timing"
|
||||
s.dependency "React-cxxstableapi"
|
||||
|
||||
add_rn_third_party_dependencies(s)
|
||||
add_rncore_dependency(s)
|
||||
|
||||
Reference in new issue
Block a user