Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #24053 prevent division by zero error in VirtualizedList debug overlay (#24058)

Browse Source 
Summary:
This PR fixes the case where the content a VirtualizedList loads with a contentLength of 0,  causing a crash in the `renderDebugOverlay` function. The result of that crash is a red screen when turning on debug on FlatList and other VirtualizedList components as described in #24053.

[LIST] [FIX] - Fix VirtualizedList debug mode crash
Pull Request resolved: https://github.com/facebook/react-native/pull/24058

Differential Revision: D14538317

Pulled By: cpojer

fbshipit-source-id: 7b17bf51c388561c517bab1f775a31200abdc5a9
This commit is contained in:
Bartol Karuza
2019-03-29 15:14:45 +00:00
committed by Lorenzo Sciandra
parent 871290f33a
commit d7e7b3ef50
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Libraries/Lists/VirtualizedList.js
+2 -1
View File
@@ -1181,7 +1181,8 @@ class VirtualizedList extends React.PureComponent<Props, State> {
_renderDebugOverlay() {
const normalize =
this._scrollMetrics.visibleLength / this._scrollMetrics.contentLength;
this._scrollMetrics.visibleLength /
(this._scrollMetrics.contentLength || 1);
const framesInLayout = [];
const itemCount = this.props.getItemCount(this.props.data);
for (let ii = 0; ii < itemCount; ii++) {