Consoliate Android SDK version inside the Version Catalog (#38949)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38949

I've done another pass and moved all the compileSdk/minSdk/targetSdk and buildToolVersion in a single place so that we can easily bump one for all the projects.

Changelog:
[Internal] [Changed] - Consoliate Android SDK version inside the Version Catalog

Reviewed By: cipolleschi

Differential Revision: D48263891

fbshipit-source-id: bb9565cded37bae986865f37f4891575396128d0
This commit is contained in:
Nicola Corti
2023-08-11 08:34:37 -07:00
committed by Facebook GitHub Bot
parent 6aed446886
commit d655d44532
5 changed files with 20 additions and 14 deletions
@@ -468,8 +468,8 @@ repositories {
}
android {
compileSdk 33
buildToolsVersion = "33.0.1"
compileSdk libs.versions.compileSdk.get().toInteger()
buildToolsVersion = libs.versions.buildTools.get()
namespace "com.facebook.react"
// Used to override the NDK path/version on internal CI or by allowing
@@ -494,8 +494,8 @@ android {
}
defaultConfig {
minSdk = 21
targetSdk = 33
minSdk = libs.versions.minSdk.get().toInteger()
targetSdk = libs.versions.targetSdk.get().toInteger()
versionCode(1)
versionName("1.0")
@@ -29,11 +29,11 @@ repositories {
}
android {
compileSdk = 33
buildToolsVersion = "33.0.1"
compileSdk = libs.versions.compileSdk.get().toInt()
buildToolsVersion = libs.versions.buildTools.get()
namespace = "com.facebook.react.flipper"
defaultConfig { minSdk = 21 }
defaultConfig { minSdk = libs.versions.minSdk.get().toInt() }
compileOptions {
sourceCompatibility = JavaVersion.VERSION_11
@@ -161,8 +161,8 @@ repositories {
}
android {
compileSdk 33
buildToolsVersion = "33.0.1"
compileSdk libs.versions.compileSdk.get().toInteger()
buildToolsVersion = libs.versions.buildTools.get()
namespace "com.facebook.hermes"
// Used to override the NDK path/version on internal CI or by allowing
@@ -175,7 +175,7 @@ android {
}
defaultConfig {
minSdk = 21
minSdk = libs.versions.minSdk.get().toInteger()
externalNativeBuild {
cmake {
@@ -1,4 +1,10 @@
[versions]
# Android versions
minSdk = "21"
targetSdk = "33"
compileSdk = "33"
buildTools = "33.0.1"
# Dependencies versions
agp = "8.1.0"
androidx-annotation = "1.6.0"
androidx-appcompat = "1.6.1"
+4 -4
View File
@@ -90,8 +90,8 @@ repositories {
}
android {
compileSdk 33
buildToolsVersion = "33.0.1"
compileSdk libs.versions.compileSdk.get().toInteger()
buildToolsVersion = libs.versions.buildTools.get()
namespace "com.facebook.react.uiapp"
// Used to override the NDK path/version on internal CI or by allowing
@@ -117,8 +117,8 @@ android {
defaultConfig {
applicationId "com.facebook.react.uiapp"
minSdk = 21
targetSdk = 33
minSdk = libs.versions.minSdk.get().toInteger()
targetSdk = libs.versions.targetSdk.get().toInteger()
versionCode 1
versionName "1.0"
testBuildType System.getProperty('testBuildType', 'debug') // This will later be used to control the test apk build type