mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Remove deprecated removeSubscription from the type of NativeEventEmitter (#39115)
Summary: Removed deprecated function removeSubscription from the type of NativeEventEmitter, so that it lines up with its implementation. This is a fix for https://github.com/facebook/react-native/issues/39111 . ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General] [Fixed] - Fix a type issue of NativeEventEmitter Pull Request resolved: https://github.com/facebook/react-native/pull/39115 Test Plan: Not applicable Reviewed By: NickGerleman Differential Revision: D48573676 Pulled By: lunaleaps fbshipit-source-id: e70c951e230e0d236e0bf0a1ba02b450bdc98ac5
This commit is contained in:
committed by
Facebook GitHub Bot
parent
4f7cdd5727
commit
d4d323cbc2
@@ -60,10 +60,4 @@ declare class NativeEventEmitter extends EventEmitter {
|
||||
* @param eventType name of the event whose registered listeners to remove
|
||||
*/
|
||||
removeAllListeners(eventType: string): void;
|
||||
|
||||
/**
|
||||
* Removes a subscription created by the addListener, the EventSubscription#remove()
|
||||
* function actually calls through to this.
|
||||
*/
|
||||
removeSubscription(subscription: EmitterSubscription): void;
|
||||
}
|
||||
|
||||
@@ -1068,7 +1068,6 @@ const sub2 = androidEventEmitter.addListener(
|
||||
androidEventEmitter.listenerCount('event'); // $ExpectType number
|
||||
sub2.remove();
|
||||
androidEventEmitter.removeAllListeners('event');
|
||||
androidEventEmitter.removeSubscription(sub1);
|
||||
|
||||
// NativeEventEmitter - IOS
|
||||
const nativeModule: NativeModule = {
|
||||
@@ -1081,7 +1080,6 @@ const sub4 = iosEventEmitter.addListener('event', (event: object) => event, {});
|
||||
iosEventEmitter.listenerCount('event');
|
||||
sub4.remove();
|
||||
iosEventEmitter.removeAllListeners('event');
|
||||
iosEventEmitter.removeSubscription(sub3);
|
||||
|
||||
class CustomEventEmitter extends NativeEventEmitter {}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user