mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Cover react/renderer/imagemanager with Stable API guards (#58307)
Summary: Pull Request resolved: https://github.com/react/react-native/pull/58307 Classifies `react/renderer/imagemanager:imagemanager` as a "for frameworks" target under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get a warning if they include its headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. `React-Fabric` already depended on `React-cxxstableapi` from an earlier migration in the same pod, so the module's subspec needs no change. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D118621752 fbshipit-source-id: ecf701cc3377904088a7bd56bf39b2b924850ca2
This commit is contained in:
1 parent
38fd9d57df
commit
d44efb09c1
18 files changed
+40
-2
No files matched your search
@@ -36,6 +36,7 @@ react_native_android_selector(reactnativejni reactnativejni "")
|
||||
target_link_libraries(react_renderer_imagemanager
|
||||
folly_runtime
|
||||
${mapbufferjni}
|
||||
react_cxxstableapi
|
||||
react_debug
|
||||
react_renderer_core
|
||||
react_renderer_debug
|
||||
|
||||
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#include <memory>
|
||||
|
||||
#include <react/renderer/core/ReactPrimitives.h>
|
||||
|
||||
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#include <react/renderer/imagemanager/ImageResponse.h>
|
||||
#include <react/renderer/imagemanager/ImageResponseObserver.h>
|
||||
#include <react/renderer/imagemanager/ImageResponseObserverCoordinator.h>
|
||||
|
||||
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#include <memory>
|
||||
|
||||
namespace facebook::react {
|
||||
|
||||
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#include <react/renderer/imagemanager/ImageResponse.h>
|
||||
|
||||
namespace facebook::react {
|
||||
|
||||
+2
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#include <react/renderer/imagemanager/ImageResponse.h>
|
||||
#include <react/renderer/imagemanager/ImageResponseObserver.h>
|
||||
#include <react/utils/SharedFunction.h>
|
||||
|
||||
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#include <react/renderer/core/ReactPrimitives.h>
|
||||
#include <react/utils/Telemetry.h>
|
||||
|
||||
|
||||
+2
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#include <react/renderer/imagemanager/ImageRequest.h>
|
||||
#include <react/renderer/imagemanager/ImageRequestParams.h>
|
||||
#include <react/utils/ContextContainer.h>
|
||||
|
||||
+2
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#include <utility>
|
||||
|
||||
#include <react/renderer/graphics/Color.h>
|
||||
|
||||
+2
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#include <react/featureflags/ReactNativeFeatureFlags.h>
|
||||
#include <react/renderer/core/graphicsConversions.h>
|
||||
#include <react/renderer/imagemanager/ImageRequestParams.h>
|
||||
|
||||
+2
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#include <react/renderer/graphics/Float.h>
|
||||
|
||||
namespace facebook::react {
|
||||
|
||||
+7
-2
@@ -21,7 +21,11 @@ Pod::Spec.new do |s|
|
||||
header_search_paths = [
|
||||
"\"$(PODS_TARGET_SRCROOT)/../../../\"",
|
||||
"\"$(PODS_TARGET_SRCROOT)\"",
|
||||
].join(" ")
|
||||
]
|
||||
|
||||
if ENV['USE_FRAMEWORKS']
|
||||
header_search_paths << "\"$(PODS_TARGET_SRCROOT)/../../../../..\"" # ReactCommon, for <react/cxxstableapi/...>
|
||||
end
|
||||
|
||||
s.name = "React-ImageManager"
|
||||
s.version = version
|
||||
@@ -38,12 +42,13 @@ Pod::Spec.new do |s|
|
||||
|
||||
s.pod_target_xcconfig = {
|
||||
"USE_HEADERMAP" => "NO",
|
||||
"HEADER_SEARCH_PATHS" => header_search_paths,
|
||||
"HEADER_SEARCH_PATHS" => header_search_paths.join(" "),
|
||||
"CLANG_CXX_LANGUAGE_STANDARD" => rct_cxx_language_standard(),
|
||||
"DEFINES_MODULE" => "YES",
|
||||
}
|
||||
|
||||
s.dependency "React-Core/Default"
|
||||
s.dependency "React-cxxstableapi"
|
||||
|
||||
add_dependency(s, "React-Fabric")
|
||||
add_dependency(s, "React-graphics", :additional_framework_paths => ["react/renderer/graphics/platform/ios"])
|
||||
|
||||
+2
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#include <react/renderer/graphics/Float.h>
|
||||
|
||||
namespace facebook::react {
|
||||
|
||||
+2
@@ -5,6 +5,8 @@
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*/
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#import <UIKit/UIKit.h>
|
||||
|
||||
#import "RCTImageManagerProtocol.h"
|
||||
|
||||
+2
@@ -5,6 +5,8 @@
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*/
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#import <Foundation/Foundation.h>
|
||||
#import <react/renderer/core/ReactPrimitives.h>
|
||||
#import <react/renderer/imagemanager/ImageRequest.h>
|
||||
|
||||
+2
@@ -5,6 +5,8 @@
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*/
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#import <UIKit/UIKit.h>
|
||||
|
||||
#import <React/RCTConvert.h>
|
||||
|
||||
+2
@@ -5,6 +5,8 @@
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*/
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#import <UIKit/UIKit.h>
|
||||
|
||||
#import "RCTImageManagerProtocol.h"
|
||||
|
||||
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#include <string>
|
||||
#include <vector>
|
||||
|
||||
|
||||
Reference in new issue
Block a user