mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Fix matricesDiffer ignoring first value of matrix
Summary: Changelog: [internal] # Problem Implementation of `matricesDiffer` was ignoring first element in the matrix, therefore two matrixes that were different were actually evaluated as same and React didn't pass value to native. # Solution Take first element in the matrix into account when comparing matrices. Reviewed By: cpojer Differential Revision: D20117210 fbshipit-source-id: 84c3b4e580da44bda4fc8bd8669318282ae9aa32
This commit is contained in:
1 parent
6beee039a2
commit
d33ead3f16
2 files changed
+46
No files matched your search
@@ -0,0 +1,45 @@
|
||||
/**
|
||||
* Copyright (c) Facebook, Inc. and its affiliates.
|
||||
*
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @format
|
||||
* @emails oncall+react_native
|
||||
*/
|
||||
|
||||
'use strict';
|
||||
|
||||
const matricesDiffer = require('../matricesDiffer');
|
||||
|
||||
describe('matricesDiffer', function() {
|
||||
it('diffs matrices with single element', () => {
|
||||
var x = [1];
|
||||
var y = [2];
|
||||
expect(matricesDiffer(x, y)).toBe(true);
|
||||
|
||||
x = [1];
|
||||
y = [1];
|
||||
expect(matricesDiffer(x, y)).toBe(false);
|
||||
});
|
||||
|
||||
it('diffs matrices with different number of elements', () => {
|
||||
var x = [1, 1, 1, 1];
|
||||
var y = [1, 1, 1, 2];
|
||||
expect(matricesDiffer(x, y)).toBe(true);
|
||||
});
|
||||
|
||||
it('diffs matrices with 16 elements', () => {
|
||||
var x = [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1];
|
||||
var y = [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1];
|
||||
expect(matricesDiffer(x, y)).toBe(false);
|
||||
|
||||
x = [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1];
|
||||
y = [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 2, 1];
|
||||
expect(matricesDiffer(x, y)).toBe(true);
|
||||
|
||||
x = [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1];
|
||||
y = [2, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1];
|
||||
expect(matricesDiffer(x, y)).toBe(true);
|
||||
});
|
||||
});
|
||||
@@ -30,6 +30,7 @@ const matricesDiffer = function(one, two) {
|
||||
one[14] !== two[14] ||
|
||||
one[5] !== two[5] ||
|
||||
one[10] !== two[10] ||
|
||||
one[0] !== two[0] ||
|
||||
one[1] !== two[1] ||
|
||||
one[2] !== two[2] ||
|
||||
one[3] !== two[3] ||
|
||||
|
||||
Reference in new issue
Block a user